2.6.19-rc2-mm2 sysfs: sysfs_write_file() writes zero terminated data
PATCH 1/1 2.6.19-rc2-mm2 sysfs: sysfs_write_file() writes zero terminated data
Hello,
since most of the files in sysfs are text files, it would be nice, if the "store" function called during sysfs_write_file() gets a zero terminated string / data.
The current implementation seems not to ensure this. (But only if it is the first time the zeroed buffer page is allocated.)
So the buffer can be scanned by sscanf() easily, for example.
This patch simply sets a \0 char behind the data in buffer->page.
fs/sysfs/file.c +3 -0
@@ -195,6 +195,9 @@ fill_write_buffer(struct sysfs_buffer * count =PAGE_SIZE -1 ; error =copy_from_user (buffer->page,buf,count); buffer->needs_read_fill =1 ; +/* if buf is assumed to contain a string, terminate it by \0, +so e.g. sscanf() can scan the string easily */ + buffer->page[count] =0 ;return error ? -EFAULT : count; }
Quoted 9 lines · Thomas Maier
Hello,
since most of the files in sysfs are text files, it would be nice, if the "store" function called during
sysfs_write_file()gets a zero terminated string / data.
The current implementation seems not to ensure this. (But only if it is the first time the zeroed buffer page is allocated.)
Have you seen sysfs buffers being passed to the store() function in a non-null terminated manner? How?
Are you seeking backward and then writing again to the file somehow?
thanks,
greg k-h
Hello,
Sorry, maybe i missed something, but according to the code in fs/sysfs/file.c the "write" sequence is:
- call to sysfs_write_file(ubuf, count)
- if (!sysfsbuf->page) alloc zeroed page
- copy count bytes from ubuf to sysfsbuf->page
- call store(sysfsbuf->page, count)
When you write again to the file before closing it (possible?!), and count is less the the previous count you may not pass a zero terminated string/data to store().
-Thomas
Am 22.10.2006, 20:39 Uhr, schrieb Greg KH <[email protected]>:
Quoted 21 lines · Thomas Maier
Quoted 9 lines
Hello,
since most of the files in sysfs are text files, it would be nice, if the "store" function called during
sysfs_write_file()gets a zero terminated string / data.
The current implementation seems not to ensure this. (But only if it is the first time the zeroed buffer page is allocated.)Have you seen sysfs buffers being passed to the
store()function in a non-null terminated manner? How?Are you seeking backward and then writing again to the file somehow?
thanks,
greg k-h
Quoted 5 lines · Thomas Maier
Hello,
Sorry, maybe i missed something, but according to the code in
fs/sysfs/file.cthe "write" sequence is:
Quoted 8 lines
- call to
sysfs_write_file(ubuf, count)
- if (!sysfsbuf->page) alloc zeroed page
- copy count bytes from ubuf tosysfsbuf->page
- callstore(sysfsbuf->page, count)When you write again to the file before closing it (possible?!), and count is less the the previous count you may not pass a zero terminated string/data to
store().
Yeah, that might happen, but writing to a sysfs file again after the first time is not the normal case here. I'll add your patch to the queue to keep this from happening though, good catch.
greg k-h