Skip to contentSkip to conversation

Patch for ModNET50 board and NET+50 CPU

U-Boot-Users Thomas Elste 2 participants 6 messages Feb 6, 2004 – Feb 26, 2004 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi all,

I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.

The patch is against todays CVS version, I've tested it by downloading, flashing and booting uCLinux, everything seems to work fine. If nevertheless anything is wrong with the code, please let me know.

best regards
Thomas

--
Thomas Elste
Institut fuer Mikroelektronik- und Mechatronik-Systeme
www.imms.de
Langewiesener Strasse 22
98693 Ilmenau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-modnet50.patch.bz2
Type: application/bzip2
Size: 25581 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040206/de837a86/attachment.bin

#1 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.

At first glance I see little difference between your code in cpu/netarm and what we already have in cpu/arm720t - and nothing that could not be implemente dby a few #ifdef's.

Why do you think this is a so different type of CPU that we will need a new CPU directory?

If possible, I would like to avoid creating a new CPU directory which just duplicates existing code.

Quoted 4 lines

The patch is against todays CVS version, I've tested it by downloading, flashing and booting uCLinux, everything seems to work fine. If nevertheless anything is wrong with the code, please let me know.

In the meantime I added the patch which changed the ARM memory layout. This obsoletes your patch.

I'm afraid I have to ask you to resubmit this patch.

Best regards,

Wolfgang Denk

Signature · 4 lines
See us @ Embedded World, Nuremberg, Feb 17 - 19,  Hall 12.0 Booth 440
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Nothing is easier than to denounce  the  evildoer;  nothing  is  more
difficult than to understand him.                 - Fyodor Dostoevski
#2 lore raw
In reply to Thomas Elste
Quoted 6 lines
Quoted 3 lines

I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.

If possible, I would like to avoid creating a new CPU directory which just duplicates existing code.

Ok, I've changed the layout, so that the arm720t cpu directory is used. The serial i/o stuff differs a lot, so I've created a new file: serial_netarm.c . Anything else is done by ifdefs now.

Quoted 4 lines

In the meantime I added the patch which changed the ARM memory layout. This obsoletes your patch.

I'm afraid I have to ask you to resubmit this patch.

No problem, here's the new one (against todays CVS).

best regards
Thomas

Signature · 12 lines
Thomas Elste
Institut fuer Mikroelektronik- und Mechatronik-Systeme
www.imms.de
Langewiesener Strasse 22
98693 Ilmenau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-modnet50.diff.bz2
Type: application/bzip2
Size: 21906 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040210/4e7d819f/attachment.bin 
#3 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

Ok, I've changed the layout, so that the arm720t cpu directory is used. The serial i/o stuff differs a lot, so I've created a new file: serial_netarm.c . Anything else is done by ifdefs now.

Thanks, added.

I moved some files around to avoid having architecture specific files in the common include/ directory.

Also, I had to cleanup you code a lot - next time please check section "Coding Style" in the README.

Please also submit another patch to add the required entries to the MAINTAINERS and CREDITS files.

Best regards,

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"No one talks peace unless he's ready to back it up with war."
"He talks of peace if it is the only way to live."
	-- Colonel Green and Surak of Vulcan, "The Savage Curtain",
	   stardate 5906.5.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 2 lines

Please also submit another patch to add the required entries to the MAINTAINERS and CREDITS files.

Here's the patch.

regards
Thomas Elste

Signature · 9 lines
Thomas Elste
Institut fuer Mikroelektronik- und Mechatronik-Systeme
www.imms.de
Langewiesener Strasse 22
98693 Ilmenau
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: credits.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040224/96ad4149/attachment.txt 
#6 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Please also submit another patch to add the required entries to the MAINTAINERS and CREDITS files.

Here's the patch.

Thanks, added.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Anyone who isn't confused here doesn't really know what's going on.