Skip to contentSkip to conversation

Build failure of kernel v4.14-rc due to error in tools/perf

PATCH Akemi Yagi 2 participants 2 messages Sep 22, 2017 – Sep 29, 2017 perf events

lore
Share & tools
lore

Akemi Yagi

author
#0 lore raw

Hi,

The build of kernel v4.14-rc1 for i686 fails on RHEL 6 with the error in tools/perf:

util/syscalltbl.c:157: error: expected ';', ',' or ')' before '__maybe_unused'
mv: cannot stat `util/.syscalltbl.o.tmp': No such file or directory

This is fixed by placing/moving

#include <linux/compiler.h>

outside of #ifdef HAVE_SYSCALL_TABLE as shown in the patch below.

Thanks,

Akemi Yagi <[email protected]>
2017-09-22

tools/perf/util/syscalltbl.c 2017-09-22 00:16:16.119007615 -0700 renamed from tools/perf/util/syscalltbl.c 2017-09-16 15:47:51.000000000 -0700 +1 -1
@@ -15,9 +15,9 @@
 
 #include "syscalltbl.h"
 #include <stdlib.h>
+#include <linux/compiler.h>
 
 #ifdef HAVE_SYSCALL_TABLE
-#include <linux/compiler.h>
 #include <string.h>
 #include "string2.h"
 #include "util.h"
#1 lore raw

[tip:perf/urgent] perf tools: Fix syscalltbl build failure

perf tools: Fix syscalltbl build failure
Commit-ID:  090657c9fb7094e4c1b05c1713d6c2a12ef43dea
Gitweb:     https://git.kernel.org/tip/090657c9fb7094e4c1b05c1713d6c2a12ef43dea
Author:     Akemi Yagi <[email protected]>
AuthorDate: Fri, 22 Sep 2017 22:11:53 +0000
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 25 Sep 2017 12:21:05 -0300

perf tools: Fix syscalltbl build failure

The build of kernel v4.14-rc1 for i686 fails on RHEL 6 with the error in tools/perf:

util/syscalltbl.c:157: error: expected ';', ',' or ')' before '__maybe_unused'
mv: cannot stat `util/.syscalltbl.o.tmp': No such file or directory

Fix it by placing/moving:

  #include <linux/compiler.h>

outside of #ifdef HAVE_SYSCALL_TABLE block.

---
 tools/perf/util/syscalltbl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/syscalltbl.c +1 -1
index 19e5db9..6eea7cf 100644
@@ -15,9 +15,9 @@
 
 #include "syscalltbl.h"
 #include <stdlib.h>
+#include <linux/compiler.h>
 
 #ifdef HAVE_SYSCALL_TABLE
-#include <linux/compiler.h>
 #include <string.h>
 #include "string2.h"
 #include "util.h"