57630: regressions - FAIL
osstest service user
Reviewed-by John Snowflight 57630 xen-4.2-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/57630/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xend-winxpsp3 16 guest-stop fail REGR. vs. 53018
test-amd64-i386-xend-qemut-winxpsp3 16 guest-stop fail REGR. vs. 53018
Regressions which are regarded as allowable (not blocking):
test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail like 53018
test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 53018
test-amd64-i386-xl-win7-amd64 16 guest-stop fail like 53018
Tests which did not succeed, but are not blocking:
test-amd64-amd64-rumpuserxen-amd64 1 build-check(1) blocked n/a
test-i386-i386-rumpuserxen-i386 1 build-check(1) blocked n/a
test-amd64-i386-rumpuserxen-i386 1 build-check(1) blocked n/a
build-i386-rumpuserxen 5 rumpuserxen-build fail never pass
test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail never pass
test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail never pass
build-amd64-rumpuserxen 5 rumpuserxen-build fail never pass test-amd64-amd64-libvirt 12 migrate-support-check fail never pass test-amd64-i386-libvirt 12 migrate-support-check fail never pass test-i386-i386-libvirt 12 migrate-support-check fail never pass
test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail never pass
version targeted for testing:
xen 63aeca00c805fa1c47d9f7b1978e83e41ab482d4
baseline version:
xen 7e527e2ab6c95ef84035d02e9e50b956a0d469c9
------------------------------------------------------------
People who touched revisions under test:
Ian Jackson <[email protected]>
Petr Matousek <[email protected]>
------------------------------------------------------------
jobs:
build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass build-amd64-rumpuserxen fail build-i386-rumpuserxen fail test-amd64-amd64-xl pass test-amd64-i386-xl pass test-i386-i386-xl pass test-amd64-i386-rhel6hvm-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-qemuu-freebsd10-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-rumpuserxen-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-win7-amd64 pass test-amd64-i386-xl-win7-amd64 fail test-amd64-amd64-xl-credit2 pass test-i386-i386-xl-credit2 pass test-amd64-i386-qemuu-freebsd10-i386 pass test-amd64-i386-rumpuserxen-i386 blocked test-i386-i386-rumpuserxen-i386 blocked test-amd64-i386-rhel6hvm-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-amd64-i386-libvirt pass test-i386-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-i386-i386-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-i386-i386-pair pass test-amd64-amd64-xl-sedf-pin pass test-i386-i386-xl-sedf-pin pass test-amd64-amd64-pv pass test-amd64-i386-pv pass test-i386-i386-pv pass test-amd64-amd64-xl-sedf pass test-i386-i386-xl-sedf pass test-amd64-i386-xl-qemut-winxpsp3-vcpus1 pass test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 pass test-amd64-i386-xl-winxpsp3-vcpus1 pass test-amd64-i386-xend-qemut-winxpsp3 fail test-amd64-amd64-xl-qemut-winxpsp3 pass test-i386-i386-xl-qemut-winxpsp3 pass test-amd64-amd64-xl-qemuu-winxpsp3 pass test-i386-i386-xl-qemuu-winxpsp3 pass test-amd64-i386-xend-winxpsp3 fail test-amd64-amd64-xl-winxpsp3 pass test-i386-i386-xl-winxpsp3 pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit 63aeca00c805fa1c47d9f7b1978e83e41ab482d4
Author: Ian Jackson <[email protected]> Date: Wed May 27 16:57:21 2015 +0100
QEMU_TAG update
========================================
commit 63a2748f7a97462c9d967daaabaeb5749aee24ea
Author: Petr Matousek <[email protected]> Date: Wed May 6 09:48:59 2015 +0200
fdc: force the fifo access to be in bounds of the allocated buffer
During processing of certain commands such as FD_CMD_READ_ID and FD_CMD_DRIVE_SPECIFICATION_COMMAND the fifo memory access could get out of bounds leading to memory corruption with values coming from the guest.
Fix this by making sure that the index is always bounded by the allocated memory.
This is XSA-133 / CVE-2015-3456.
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 00:57, <[email protected]> wrote:
flight 57630 xen-4.2-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/57630/Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xend-winxpsp3 16 guest-stop fail REGR. vs. 53018
test-amd64-i386-xend-qemut-winxpsp3 16 guest-stop fail REGR. vs. 53018
This seems to be due to osstest using an unrecognized option:
2015-05-31 20:32:59 Z executing ssh ... [email protected] xm shutdown -wF win.guest.osstest
Error: option -F not recognized
Usage: xm shutdown <Domain> [-waRH]
Shutdown a domain.
[options] [DOM]
Shutdown one or more domains gracefully.
Jan
PATCH 1/1 Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
Quoted 11 lines · Jan Beulich
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 00:57, <[email protected]> wrote:
flight 57630 xen-4.2-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/57630/Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xend-winxpsp3 16 guest-stop fail REGR. vs. 53018
test-amd64-i386-xend-qemut-winxpsp3 16 guest-stop fail REGR. vs. 53018
Quoted 4 lines
This seems to be due to osstest using an unrecognized option:
2015-05-31 20:32:59 Z executing ssh ... [email protected] xm shutdown -wF win.guest.osstestError: option -F not recognized
I think this osstest patch ought to fix it. I've only "tested" with perl -c though.
--------8>--------
Quoted 1 line
From
aa79bd958fe42da2876fd76e61468c183a7fabdcMon Sep 17 00:00:00 2001
From: Ian Campbell <[email protected]>
Date: Mon, 1 Jun 2015 09:32:37 +0100
Subject: [PATCH] Toolstack: Do not pass -F to xm shutdown
This is a feature of xl only.
--- Osstest/Toolstack/xl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Osstest/Toolstack/xl.pm +1 -1
@@ -56,7 +56,7 @@ sub shutdown_wait ($$$) { my $ho = $self->{Host}; my $gn = $gho->{Name}; my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true' - ? "F" : ""; + && $self->{Name} eq 'xl' ? "F" : ""; target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout); }
Signature · 1 line
2.1.4
PATCH 1/1 Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
Quoted 15 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 10:34, <[email protected]> wrote:
Subject: [PATCH] Toolstack: Do not pass -F to xm shutdown
This is a feature of xl only.
Signed-off-by Ian Campbell <[email protected]>--- Osstest/Toolstack/xl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Osstest/Toolstack/xl.pm +0
-0
Osstest/Toolstack/xl.pm sub shutdown_wait ($$$) { · line 60
Quoted 6 lines
Osstest/Toolstack/xl.pm +1
-1@@ -56,7 +56,7 @@ sub shutdown_wait ($$$) { my $ho = $self->{Host}; my $gn = $gho->{Name}; my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true' - ? "F" : ""; + && $self->{Name} eq 'xl' ? "F" : ""; target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout);
Well - to me, not knowing much about osstest's structure, catering for xm in a file called xl.pm seems odd. And then, taking into consideration a hypothetical 3rd toolstack, I wonder whether assuming only xl supports -F (instead of "only xm does not support it") is the more suitable check.
Jan
Re: [PATCH OSSTEST] Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
Quoted 19 lines · Jan Beulich
Quoted 19 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 10:34, <[email protected]> wrote:
Subject: [PATCH] Toolstack: Do not pass -F to xm shutdown
This is a feature of xl only.
Signed-off-by Ian Campbell <[email protected]>--- Osstest/Toolstack/xl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Osstest/Toolstack/xl.pm +0
-1@@ -56,7 +56,7 @@ sub shutdown_wait ($$$) { my $ho = $self->{Host}; my $gn = $gho->{Name}; my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true' - ? "F" : "";
Quoted 8 lines
Osstest/Toolstack/xl.pm sub shutdown_wait ($$$) { · line 60
Quoted 2 lines
Osstest/Toolstack/xl.pm +1
-0+ && $self->{Name} eq 'xl' ? "F" : ""; target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout);Well - to me, not knowing much about osstest's structure, catering for xm in a file called xl.pm seems odd. And then, taking into consideration a hypothetical 3rd toolstack, I wonder whether assuming only xl supports -F (instead of "only xm does not support it") is the more suitable check.
xend.pm inherits from xl.pm in a oo-ish way.
I did consider adding shutdown_wait to xend.pm to overload this one, but that meant duplicating 95% unaltered.
A third toolstack is not hypothetical, libvirt's virsh is supported, but virsh.pm sharing no historical legacy with xl/xm inherets from the toplevel toolstack parent, not the xl one.
Ian.
Re: [PATCH OSSTEST] Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
Quoted 31 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 11:42, <[email protected]> wrote:
Quoted 10 lines · Jan Beulich
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 01.06.15 at 10:34, <[email protected]> wrote:
Subject: [PATCH] Toolstack: Do not pass -F to xm shutdown
This is a feature of xl only.
Signed-off-by Ian Campbell <[email protected]>--- Osstest/Toolstack/xl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
Osstest/Toolstack/xl.pm sub shutdown_wait ($$$) { · line 60
Quoted 11 lines
Osstest/Toolstack/xl.pm +1
-1@@ -56,7 +56,7 @@ sub shutdown_wait ($$$) { my $ho = $self->{Host}; my $gn = $gho->{Name}; my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true' - ? "F" : ""; + && $self->{Name} eq 'xl' ? "F" : ""; target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback}$gn", $timeout);
Quoted 6 lines
Well - to me, not knowing much about osstest's structure, catering for xm in a file called xl.pm seems odd. And then, taking into consideration a hypothetical 3rd toolstack, I wonder whether assuming only xl supports -F (instead of "only xm does not support it") is the more suitable check.
Quoted 8 lines
xend.pm inherits from xl.pm in a oo-ish way.
I did consider adding
shutdown_waitto xend.pm to overload this one, but that meant duplicating 95% unaltered.A third toolstack is not hypothetical, libvirt's virsh is supported, but virsh.pm sharing no historical legacy with xl/xm inherets from the toplevel toolstack parent, not the xl one.
Makes sense, thanks for explaining.
Jan
Re: [PATCH OSSTEST] Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
In reply to Ian CampbellQuoted 8 lines · Ian Campbell
From
aa79bd958fe42da2876fd76e61468c183a7fabdcMon Sep 17 00:00:00 2001
From: Ian Campbell <[email protected]>
Date: Mon, 1 Jun 2015 09:32:37 +0100
Subject: [PATCH] Toolstack: Do not pass -F to xm shutdownThis is a feature of xl only.
Signed-off-by Ian Campbell <[email protected]>
With Ian being away for a bit and this blocking testing of older branches which contain xend I've pushed this to osstest's pretest branch.
Ian.
Quoted 17 lines
--- Osstest/Toolstack/xl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Osstest/Toolstack/xl.pm +1
-1@@ -56,7 +56,7 @@ sub shutdown_wait ($$$) { my $ho = $self->{Host}; my $gn = $gho->{Name}; my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true' - ? "F" : ""; + && $self->{Name} eq 'xl' ? "F" : ""; target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout); }