Skip to contentSkip to conversation

powerpc: remove non-dependent load fsl_booke PTE_64BIT

PATCH Applied Milton Miller 2 participants 3 messages Oct 10, 2008 PowerPC

lore
Share & tools
lore

Milton Miller

author
#0 lore raw

PATCH 1/1 powerpc: remove non-dependent load fsl_booke PTE_64BIT

b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys to order the load of upper and lower halfs of the pte, but only adjusted whitespace instead of deleting the old load in the iside handler, letting the hardware see the non-dependent load.

This patch removes the extra load.

Signed-off-by Milton Miller <[email protected]>

---
Kumar, I think this is right from my inspection, please review.

arch/powerpc/kernel/head_fsl_booke.S +0 -4
Index: next.git/arch/powerpc/kernel/head_fsl_booke.S
===================================================================
@@ -658,10 +658,6 @@ interrupt_base:
 
 	bne	2f			/* Bail if permission mismach */
 
-#ifdef CONFIG_PTE_64BIT
-	lwz	r13,0(r12)
-#endif
-
 	/* Jump to common TLB load point */
 	b	finish_tlb_load
#1 lore raw
Quoted 10 lines · Milton Miller

b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys to order the load of upper and lower halfs of the pte, but only adjusted whitespace instead of deleting the old load in the iside handler, letting the hardware see the non-dependent load.

This patch removes the extra load.

Signed-off-by Milton Miller <[email protected]>

---
Kumar, I think this is right from my inspection, please review.

good catch, thanks.

- k

Applied
#2 lore raw
In reply to Milton Miller
Quoted 10 lines · Milton Miller

b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys to order the load of upper and lower halfs of the pte, but only adjusted whitespace instead of deleting the old load in the iside handler, letting the hardware see the non-dependent load.

This patch removes the extra load.

Signed-off-by Milton Miller <[email protected]>

---
Kumar, I think this is right from my inspection, please review.

applied

- k