Skip to contentSkip to conversation

vfio-ccw: make vfio_ccw_async_region_ops static

PATCH In review Vasily Gorbik 2 participants 3 messages Jul 29, 2019

Subsystems (3)
lore
Share & tools
lore

Vasily Gorbik

author maintainer
#0 lore raw

PATCH 1/1 vfio-ccw: make vfio_ccw_async_region_ops static

Since vfio_ccw_async_region_ops is not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:
drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?

---
 drivers/s390/cio/vfio_ccw_async.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_async.c +1 -1
index 8c1d2357ef5b..7a838e3d7c0f 100644
@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private,
 
 }
 
-const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
+static const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
 	.read = vfio_ccw_async_region_read,
 	.write = vfio_ccw_async_region_write,
 	.release = vfio_ccw_async_region_release,
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · On Mon, 29 Jul 2019 10:38:52 +0200 Vasily Gorbik <[email protected]> wrote:

Since vfio_ccw_async_region_ops is not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:
drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?

Fixes d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
Quoted 11 lines
---
 drivers/s390/cio/vfio_ccw_async.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_async.c +0 -0
index 8c1d2357ef5b..7a838e3d7c0f 100644

drivers/s390/cio/vfio_ccw_async.c static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, · line 76

Quoted 8 lines
drivers/s390/cio/vfio_ccw_async.c +1 -1
@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private,
 
 }
 
-const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
+static const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
 	.read = vfio_ccw_async_region_read,
 	.write = vfio_ccw_async_region_write,
 	.release = vfio_ccw_async_region_release,

Should I queue this and send a pull request (currently, there's nothing else pending), or do you want to apply this directly?

author maintainer
#2 lore raw
Quoted 30 lines · Cornelia Huck
Quoted 3 lines · On Mon, 29 Jul 2019 10:38:52 +0200 Vasily Gorbik <[email protected]> wrote:

Since vfio_ccw_async_region_ops is not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:
drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?

Fixes d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
Quoted 11 lines
---
 drivers/s390/cio/vfio_ccw_async.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_async.c +0 -0
index 8c1d2357ef5b..7a838e3d7c0f 100644

drivers/s390/cio/vfio_ccw_async.c static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, · line 76

Quoted 8 lines
drivers/s390/cio/vfio_ccw_async.c +1 -1
@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private,
 
 }
 
-const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
+static const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
 	.read = vfio_ccw_async_region_read,
 	.write = vfio_ccw_async_region_write,
 	.release = vfio_ccw_async_region_release,
Quoted 2 lines

Should I queue this and send a pull request (currently, there's nothing else pending), or do you want to apply this directly?

Then I'll just take it directly to avoid pull request overhead, thanks!