vfio-ccw: make vfio_ccw_async_region_ops static
Subsystems (3)
Vasily Gorbik
maintainerPATCH 1/1 vfio-ccw: make vfio_ccw_async_region_ops static
Since vfio_ccw_async_region_ops is not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?
--- drivers/s390/cio/vfio_ccw_async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_async.c +1 -1
@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, } -const struct vfio_ccw_regops vfio_ccw_async_region_ops = { +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = { .read = vfio_ccw_async_region_read, .write = vfio_ccw_async_region_write, .release = vfio_ccw_async_region_release,
Signature · 1 line
2.21.0
Quoted 3 lines · On Mon, 29 Jul 2019 10:38:52 +0200 Vasily Gorbik <[email protected]> wrote:
Since
vfio_ccw_async_region_opsis not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?
Quoted 11 lines
Signed-off-by Vasily Gorbik <[email protected]>--- drivers/s390/cio/vfio_ccw_async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/s390/cio/vfio_ccw_async.c +0
-0
drivers/s390/cio/vfio_ccw_async.c static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, · line 76
Quoted 8 lines
drivers/s390/cio/vfio_ccw_async.c +1
-1@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, } -const struct vfio_ccw_regops vfio_ccw_async_region_ops = { +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = { .read = vfio_ccw_async_region_read, .write = vfio_ccw_async_region_write, .release = vfio_ccw_async_region_release,
Should I queue this and send a pull request (currently, there's nothing else pending), or do you want to apply this directly?
Vasily Gorbik
maintainerQuoted 30 lines · Cornelia Huck
Quoted 3 lines · On Mon, 29 Jul 2019 10:38:52 +0200 Vasily Gorbik <[email protected]> wrote:
Since
vfio_ccw_async_region_opsis not exported and has no reason to be
globally visible make it static to avoid the following sparse warning:drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?Fixes d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")Quoted 11 lines
Signed-off-by Vasily Gorbik <[email protected]>--- drivers/s390/cio/vfio_ccw_async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/s390/cio/vfio_ccw_async.c +0
-0drivers/s390/cio/vfio_ccw_async.c static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, · line 76
Quoted 8 lines
drivers/s390/cio/vfio_ccw_async.c +1
-1@@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, } -const struct vfio_ccw_regops vfio_ccw_async_region_ops = { +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = { .read = vfio_ccw_async_region_read, .write = vfio_ccw_async_region_write, .release = vfio_ccw_async_region_release,Reviewed-by Cornelia Huck <[email protected]>
Quoted 2 lines
Should I queue this and send a pull request (currently, there's nothing else pending), or do you want to apply this directly?
Then I'll just take it directly to avoid pull request overhead, thanks!