Skip to contentSkip to conversation

Unionfs: Stackable Namespace Unification Filesystem

PATCH Andrew Morton 3 participants 3 messages Oct 12, 2006 – Oct 13, 2006 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 1 line · On Thu, 12 Oct 2006 02:18:37 -0400 Josef "Jeff" Sipek <[email protected]>…

This set of patches constitutes Unionfs version 2.0.

So we need to get this reviewed.

Christoph and I are pretty much the only people who do filesystem reviewing, despite the fact that we have hoards of filesystem developers out there busily doing their own stuff (and that includes the unionfs developers, I might add).

Our review-to-development ratio is wildly out of whack and I don't know how to fix that.

Meanwhile, from a quick scan I'd say that unionfs is much, much too lightly
commented for a review to be particularly effective. Please work on that.

#2 lore raw
Quoted 2 lines · Andrew Morton

Meanwhile, from a quick scan I'd say that unionfs is much, much too lightly
commented for a review to be particularly effective. Please work on that.

Could use some basic coding style fixes too.

- Move assignments outside of if statement expression "if (err = foo_bar())"
- No C99-style comments "//"
- Use struct kmem_cache instead of the deprecated kmem_cache_t
- Don't use function-like macros as the left hand side of assignment expression "itohi_ptr(inode) = kzalloc(size, GFP_KERNEL);". It's much better to open-code the assignment or introduce a setter function (e.g. inode_set_hiptr).
- Kill wrappers (e.g. unionfs_kill_block_super can be replaced with generic_shutdown_super)

Pekka

#3 lore raw
Quoted 7 lines
Quoted 4 lines

Meanwhile, from a quick scan I'd say that unionfs is much, much too lightly
commented for a review to be particularly effective. Please work on
that.

- Kill wrappers (e.g. unionfs_kill_block_super can be replaced with generic_shutdown_super)

Possibly the unionfs_kill_block_super function was once written with more than just generic_shutdown_super in mind. Just a guess, though.

	-`J'