Skip to contentSkip to conversation

cosmetic fixes

PATCH Applied Hollis Blanchard 2 participants 5 messages Nov 19, 2007 – Nov 20, 2007 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cosmetic fixes

These are a few fixes to minor/cosmetic issues I've stumbled across recently.

3 files changed, 7 insertions(+), 8 deletions(-)
drivers/kvm/kvm.h      |   11 +++++------
drivers/kvm/kvm_main.c |    2 +-
drivers/kvm/x86.c      |    2 +-

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

#1 lore raw

PATCH 1/1 Correct consistent typo: "destory" -> "destroy"

---

3 files changed, 3 insertions(+), 3 deletions(-)
drivers/kvm/kvm.h      |    2 +-
drivers/kvm/kvm_main.c |    2 +-
drivers/kvm/x86.c      |    2 +-
drivers/kvm/kvm.h +1 -1
@@ -462,7 +462,7 @@ void kvm_arch_vcpu_load(struct kvm_vcpu 
 void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu);
 void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu);
 struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, unsigned int id);
-void kvm_arch_vcpu_destory(struct kvm_vcpu *vcpu);
+void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu);
 
 int kvm_arch_vcpu_reset(struct kvm_vcpu *vcpu);
 void kvm_arch_hardware_enable(void *garbage);
drivers/kvm/kvm_main.c +1 -1
@@ -838,7 +838,7 @@ unlink:
 	kvm->vcpus[n] = NULL;
 	mutex_unlock(&kvm->lock);
 vcpu_destroy:
-	kvm_arch_vcpu_destory(vcpu);
+	kvm_arch_vcpu_destroy(vcpu);
 	return r;
 }
 
drivers/kvm/x86.c +1 -1
@@ -2513,7 +2513,7 @@ fail:
 	return ERR_PTR(r);
 }
 
-void kvm_arch_vcpu_destory(struct kvm_vcpu *vcpu)
+void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
 {
 	vcpu_load(vcpu);
 	kvm_mmu_unload(vcpu);

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

#2 lore raw

PATCH 1/1 Move misplaced comment

In reply to Hollis Blanchard

---

1 file changed, 4 insertions(+), 4 deletions(-)

drivers/kvm/kvm.h | 8 ++++----

drivers/kvm/kvm.h +4 -4
@@ -135,15 +135,15 @@ struct kvm_mmu {
 
 #define KVM_NR_MEM_OBJS 40
 
+/*
+ * We don't want allocation failures within the mmu code, so we preallocate
+ * enough memory for a single page fault in a cache.
+ */
 struct kvm_mmu_memory_cache {
 	int nobjs;
 	void *objects[KVM_NR_MEM_OBJS];
 };
 
-/*
- * We don't want allocation failures within the mmu code, so we preallocate
- * enough memory for a single page fault in a cache.
- */
 struct kvm_guest_debug {
 	int enabled;
 	unsigned long bp[4];

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

#3 lore raw

PATCH 1/1 Remove unused "rmap_overflow" variable

In reply to Hollis Blanchard

---

1 file changed, 1 deletion(-)

drivers/kvm/kvm.h | 1 -

drivers/kvm/kvm.h +0 -1
@@ -318,7 +318,6 @@ struct kvm {
 	unsigned int n_alloc_mmu_pages;
 	struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
 	struct kvm_vcpu *vcpus[KVM_MAX_VCPUS];
-	unsigned long rmap_overflow;
 	struct list_head vm_list;
 	struct file *filp;
 	struct kvm_io_bus mmio_bus;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Applied
#4 lore raw
In reply to Hollis Blanchard
Quoted 3 lines · Hollis Blanchard

These are a few fixes to minor/cosmetic issues I've stumbled across recently.

Thanks, applied all three.

Signature · 7 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/