linux: add linux-update and allow vmlinux for all architectures
PATCH 1/1 linux: add linux-update and allow vmlinux for all architectures
--- linux/Config.in | 1 - linux/linux.mk | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletions(-)
PATCH 1/1 linux: add linux-update target to save configuration
In analogy to build targets uclibc-update and busybox-update, add linux-update that copies the current configuration to the custom configuration file set in buildroot.
This facilitates the work of developers adding support for a specific board to buildroot.
--- linux/linux.mk | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
linux/linux.mk +7 -0
@@ -188,6 +188,13 @@ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \ $(subst linux-,,$(subst linux26-,,$@)) +ifeq ($(BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG),y) +linux-update linux26-update: $(LINUX_DIR)/.config + cp -f $(LINUX_DIR)/.config $(BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE) +else +linux-update linux26-update: ; +endif + # Support for rebuilding the kernel after the initramfs file list has # been generated in $(BINARIES_DIR)/rootfs.initramfs. $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LINUX_DIR)/.stamp_images_installed $(BINARIES_DIR)/rootfs.initramfs
PATCH 1/1 linux: make vmlinux target available to all architectures
In reply to Thomas De SchampheleireThe 'vmlinux' target in the linux build directory is a generic target. It may not be directly bootable for all architectures, but for projects where a custom bootloader is used, it can be of value.
Previously, this target was only available for mips architectures. This patch removes this restriction.
--- linux/Config.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
linux/Config.in +0 -1
@@ -146,7 +146,6 @@ config BR2_LINUX_KERNEL_VMLINUX bool "vmlinux" - depends on BR2_mips || BR2_mipsel config BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM bool "custom target"
PATCH 1/1 linux: add linux-update target to save configuration
In reply to Thomas De SchampheleireHello,
Le Wed, 21 Sep 2011 08:46:15 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :
Quoted 5 lines
In analogy to build targets uclibc-update and busybox-update, add linux-update that copies the current configuration to the custom configuration file set in buildroot.
This facilitates the work of developers adding support for a specific board to buildroot.
Definitely a good thing to have. However:
* The name if misleading. "linux-update" "busybox-update": one is not "updating" Linux or Busybox, but rather copying or updating the configuration. So presumably the name of those targets should be changed.
* I don't like the existing behaviour of busybox-update and uclibc-update, because they can overwrite the default configuration in package/busybox/busybox-xxx.config or toolchain/uClibc/uClibc-xxx.config. I think those *-update should only take effect if a non-standard configuration file was proposed, as you did for the Linux one.
* For the Linux kernel, I do use savedefconfig, so I'd like to see either this "linux-update" thing use savedefconfig, or have a separate option that does the same thing as "linux-update" but using savedefconfig. Maybe "linux-update-config" and "linux-update-minconfig" ?
Regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 linux: make vmlinux target available to all architectures
In reply to Thomas De SchampheleireLe Wed, 21 Sep 2011 08:46:16 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :
Quoted 8 lines
The 'vmlinux' target in the linux build directory is a generic target. It may not be directly bootable for all architectures, but for projects where a custom bootloader is used, it can be of value.
Previously, this target was only available for mips architectures. This patch removes this restriction.
Signed-off-by Thomas De Schampheleire <[email protected]>
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 linux: add linux-update target to save configuration
In reply to Thomas PetazzoniHi Thomas,
Quoted 11 lines · Thomas Petazzoni
Hello,
Le Wed, 21 Sep 2011 08:46:15 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :Quoted 5 lines
In analogy to build targets uclibc-update and busybox-update, add linux-update that copies the current configuration to the custom configuration file set in buildroot.
This facilitates the work of developers adding support for a specific board to buildroot.
Quoted 6 lines
Definitely a good thing to have. However:
?* The name if misleading. "linux-update" "busybox-update": one is not ? "updating" Linux or Busybox, but rather copying or updating the ? configuration. So presumably the name of those targets should be ? changed.
I agree that the name is a bit strange. "busybox-update" and "uclibc-update" were introduced back in 2007:
Thomas Petazzoni
AppliedPATCH 1/1 linux: make vmlinux target available to all architectures
In reply to Thomas PetazzoniLe Wed, 21 Sep 2011 09:29:29 +0200,
Thomas Petazzoni <[email protected]> a ?crit :
Quoted 1 line
Acked-by Thomas Petazzoni <[email protected]>
I've merged the patch in a linux-changes branch I will push to Peter.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 linux: make vmlinux target available to all architectures
Hi Thomas,
Quoted 6 lines · Thomas Petazzoni
Le Wed, 21 Sep 2011 09:29:29 +0200,
Thomas Petazzoni <[email protected]> a ?crit :Quoted 1 line
Acked-by Thomas Petazzoni <[email protected]>I've merged the patch in a linux-changes branch I will push to Peter.
Could you tell me the status of the linux-changes branch? Do you still have other patches that should go in before you push it to Peter?
Thanks,
Thomas
PATCH 1/1 linux: make vmlinux target available to all architectures
Le Sun, 16 Oct 2011 12:35:00 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :
Quoted 2 lines
Could you tell me the status of the linux-changes branch? Do you still have other patches that should go in before you push it to Peter?
I will check this and post the patches soon.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 linux: make vmlinux target available to all architectures
Quoted 7 lines · Thomas Petazzoni
Le Sun, 16 Oct 2011 12:35:00 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :Quoted 2 lines
Could you tell me the status of the linux-changes branch? Do you still have other patches that should go in before you push it to Peter?
I will check this and post the patches soon.
Thanks.
PATCH 1/1 linux: make vmlinux target available to all architectures
In reply to Thomas De SchampheleireQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
Thomas> The 'vmlinux' target in the linux build directory is a generic Thomas> target. It may not be directly bootable for all architectures, Thomas> but for projects where a custom bootloader is used, it can be Thomas> of value.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard