usb: misc: eud: Remove error print for devm_add_action_or_reset()
Subsystems (3)
PATCH v2 1/1 usb: misc: eud: Remove error print for devm_add_action_or_reset()
When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/usb/misc/qcom_eud.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/misc/qcom_eud.c +1 -2
@@ -193,8 +193,7 @@ static int eud_probe(struct platform_device *pdev) ret =devm_add_action_or_reset (chip->dev, eud_role_switch_release, chip);if (ret) -return dev_err_probe (chip->dev, ret, -"failed to add role switch release action\n" ); +return ret; chip->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (chip->base))
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
Signature · 1 line
2.39.5
Quoted 7 lines · Waqar Hameed
When
devm_add_action_or_reset()fails, it is due to a failed memory allocation and will thus return-ENOMEM.dev_err_probe()doesn't do anything when error is-ENOMEM. Therefore, remove the useless call todev_err_probe()whendevm_add_action_or_reset()fails, and just return the value instead.Signed-off-by Waqar Hameed <[email protected]>
Regards,
Bjorn
Quoted 29 lines
---
Changes in v2:* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/usb/misc/qcom_eud.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/usb/misc/qcom_eud.c +1
-2@@ -193,8 +193,7 @@ static int eud_probe(struct platform_device *pdev) ret =devm_add_action_or_reset (chip->dev, eud_role_switch_release, chip);if (ret) -return dev_err_probe (chip->dev, ret, -"failed to add role switch release action\n" ); +return ret; chip->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (chip->base))base-commit:
260f6f4fda93c8485c8037865c941b42b9cba5d2Signature · 1 line
2.39.5