powerpc: add static and ifdef prom_strtoul and prom_memparse

PATCH Milton Miller 1 participant 1 message Oct 21, 2008 PowerPC

Share & tools

Milton Miller

author

2008-10-21 01:37 UTC #0 lore raw

These functions should have been static, and inspection shows they
are no longer used. (We used to parse mem= but now we defer that
to early_param, and move the initrd and move the device tree if needed).

Signed-off-by Milton Miller <[email protected]>

---
X-Patchwork-ID: 19580
Changelog edited, compile tested on next-20081017

Should we just remove them instead?

---

arch/powerpc/kernel/prom_init.c +4 -2

index 1ea8c8d..bf1f922 100644
@@ -489,6 +489,7 @@ static int __init prom_setprop(phandle node, const char *nodename,
 	return call_prom("interpret", 1, 1, (u32)(unsigned long) cmd);
 }
 
+#if 0
 /* We can't use the standard versions because of RELOC headaches. */
 #define isxdigit(c)	(('0' <= (c) && (c) <= '9') \
 			 || ('a' <= (c) && (c) <= 'f') \

@@ -498,7 +499,7 @@ static int __init prom_setprop(phandle node, const char *nodename,
 #define islower(c)	('a' <= (c) && (c) <= 'z')
 #define toupper(c)	(islower(c) ? ((c) - 'a' + 'A') : (c))
 
-unsigned long prom_strtoul(const char *cp, const char **endp)
+static unsigned long prom_strtoul(const char *cp, const char **endp)
 {
 	unsigned long result = 0, base = 10, value;

@@ -523,7 +524,7 @@ unsigned long prom_strtoul(const char *cp, const char **endp)
 	return result;
 }
 
-unsigned long prom_memparse(const char *ptr, const char **retptr)
+static unsigned long prom_memparse(const char *ptr, const char **retptr)
 {
 	unsigned long ret = prom_strtoul(ptr, retptr);
 	int shift = 0;

@@ -549,6 +550,7 @@ unsigned long prom_memparse(const char *ptr, const char **retptr)
 
 	return ret;
 }
+#endif
 
 /*
  * Early parsing of the command line passed to the kernel, used for