t/README: fix typo
PATCH 1/1 t/README: fix typo
From: Marc Strapetz <[email protected]>
---
t/README: fix typo
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1110
t/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
t/README +1 -1
@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is complete or needs to be abandoned for whatever reason (in which case the migrated codepaths still retain their performance benefits). -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of prereqs that are required to succeed. If a prereq in this list is triggered by a test and then fails then the whole test run will abort. This can help to make sure the expected tests are executed and not silently skipped when their
base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
Signature · 1 line
gitgitgadget
Hi Marc,
Quoted 18 lines · Marc Strapetz via GitGitGadget
From: Marc Strapetz <[email protected]>
Signed-off-by Marc Strapetz <[email protected]>---
t/README: fix typoPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1110t/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)t/README +0
-0
t/README explicitly providing repositories when accessing submodule objects is · line 469
Quoted 5 lines
t/README +1
-1@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is complete or needs to be abandoned for whatever reason (in which case the migrated codepaths still retain their performance benefits). -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Good find!
I'm curious, how did you find it? If it was a spell checker, did it also find the "dotsh" typo in the same file (it should be "dots", I think)?
Ciao,
Dscho
Quoted 8 lines
t/README +0
-0prereqs that are required to succeed. If a prereq in this list is triggered by a test and then fails then the whole test run will abort. This can help to make sure the expected tests are executed and not silently skipped when theirbase-commit:
dcc0cd074f0c639a0df20461a301af6d45bd582e--
gitgitgadget
Hi Dscho,
Quoted 10 lines · Johannes Schindelin
t/README explicitly providing repositories when accessing submodule objects is · line 469
Quoted 6 lines
t/README +1
-1@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is complete or needs to be abandoned for whatever reason (in which case the migrated codepaths still retain their performance benefits). -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list ofGood find!
I'm curious, how did you find it? If it was a spell checker, did it also
I found it by plain reading :) as I had troubles to get a test working.
Quoted 1 line
find the "dotsh" typo in the same file (it should be "dots", I think)?
I wouldn't have noticed that, but I agree that it should be "test_name_without_dots".
-Marc
Quoted 15 lines · Marc Strapetz
Hi Dscho,
Quoted 12 lines · Johannes Schindelin
Quoted 9 lines
(quoted diff) +0
-0@@ -466,7 +466,7 @@ explicitly providing repositories when accessingsubmodule objects is
complete or needs to be abandoned for whatever reason (in which case the migrated codepaths still retain their performance benefits).-GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
+GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list ofGood find!
Quoted 7 lines
Quoted 1 line
I'm curious, how did you find it? If it was a spell checker, did it also
I found it by plain reading :) as I had troubles to get a test working.
Quoted 1 line
find the "dotsh" typo in the same file (it should be "dots", I think)?
I wouldn't have noticed that, but I agree that it should be "
test_name_without_dots".
Please disregard my last statement. "test_name_without_dotsh" means "test name without .sh extension". For "t2109-update-index-index-version.sh", the directory will be "trash directory.t2109-update-index-index-version".
-Marc
Quoted 9 lines · Marc Strapetz
Quoted 4 lines
Quoted 1 line
find the "dotsh" typo in the same file (it should be "dots", I
think)?
I wouldn't have noticed that, but I agree that it should be "test_name_without_dots".Please disregard my last statement. "
test_name_without_dotsh" means "test name without .sh extension". For "t2109-update-index-index-version.sh", the directory will be "trash directory.t2109-update-index-index-version".
Yup. "without_dot_sh" might have been a better way to spell it, but "without_dotsh" certainly is better than "without_dots".
Thanks for being extra careful. In any case, the original fix is good and has already been queued.
t/README explicitly providing repositories when accessing submodule objects is · line 469
Quoted 2 lines · Marc Strapetz via GitGitGadget
t/README +1
-1-GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Thanks, queued.