Skip to contentSkip to conversation

setup: fix function name

PATCH In review Cleber Rosa via GitGitGadget 2 participants 2 messages Jun 9, 2022 – Jun 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 setup: fix function name

From: Cleber Rosa <[email protected]>

The reference given to users when the result of setup_git_directory_gently_1() is unexpected is incorrect.

This fixes the name of the function when presenting the BUG message.

---
setup: fix function name

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1255%2Fclebergnu%2Ffix_function_name-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1255/clebergnu/fix_function_name-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1255

 setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
setup.c +1 -1
index faf5095e44d..b5a537258d2 100644
@@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
 		 * find a repository.
 		 */
 	default:
-		BUG("unhandled setup_git_directory_1() result");
+		BUG("unhandled setup_git_directory_gently_1() result");
 	}
 
 	/*

base-commit: 9c897eef06347cc5a3eb07c3ae409970ab1052c8

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 2 lines · Cleber Rosa via GitGitGadget

From: Cleber Rosa <[email protected]>
Subject: Re: [PATCH] setup: fix function name

I'd add "in a BUG() message" at the end.

setup.c const char *setup_git_directory_gently(int *nongit_ok) · line 1406

Quoted 11 lines
setup.c +1 -1
index faf5095e44d..b5a537258d2 100644
@@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
 		 * find a repository.
 		 */
 	default:
-		BUG("unhandled setup_git_directory_1() result");
+		BUG("unhandled setup_git_directory_gently_1() result");
 	}

Did you actually hit this BUG() and was sent to a wild goose chase because of this typo? Just checking, because BUG() that triggers is a more serious issue itself.

Thanks.