ci(main): upgrade actions/checkout to v3

PATCH Superseded Oscar Dominguez via GitGitGadget 3 participants 13 messages Oct 10, 2022 – Dec 7, 2022

lore

Share & tools

lore

Oscar Dominguez via GitGitGadget

author

2022-10-10 07:50 UTC #0 lore raw

cover ci(main): upgrade actions/checkout to v3

Description
===========

Upgrades actions/checkout to v3 in .github/workflows/main.yml

Oscar Dominguez (2):
ci(main): upgrade actions/checkout to v3
ci(main): linux32 uses actions/checkout@v2

 .github/workflows/main.yml | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v1
Pull-Request: https://github.com/git/git/pull/1354

Signature · 1 line

gitgitgadget

Oscar Dominguez via GitGitGadget

author

2022-10-10 07:50 UTC #3 lore raw

PATCH 2/2 ci(main): linux32 uses actions/checkout@v2

From: Oscar Dominguez <[email protected]>

to prevent issue tracked in https://github.com/actions/checkout/issues/560

Signed-off-by Oscar Dominguez <[email protected]>

---
 .github/workflows/main.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

.github/workflows/main.yml +4 -1

index 8dc9d938159..4eb5042f0d6 100644
@@ -281,17 +281,20 @@ jobs:
         vector:
         - jobname: linux-musl
           image: alpine
+          checkout_version: 3
         - jobname: linux32
           os: ubuntu32
           image: daald/ubuntu32:xenial
+          checkout_version: 2
         - jobname: pedantic
           image: fedora
+          checkout_version: 3
     env:
       jobname: ${{matrix.vector.jobname}}
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@${{matrix.vector.checkout_version}}
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

Signature · 1 line

gitgitgadget

Oscar Dominguez via GitGitGadget

author

2022-10-10 07:50 UTC #1 lore raw

PATCH 1/2 ci(main): upgrade actions/checkout to v3

In reply to Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>

to be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches.

Signed-off-by Oscar Dominguez Celada <[email protected]>

---
 .github/workflows/main.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

.github/workflows/main.yml +8 -8

index 831f4df56c5..8dc9d938159 100644
@@ -83,7 +83,7 @@ jobs:
     if: needs.ci-config.outputs.enabled == 'yes'
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: build
       shell: bash

@@ -138,10 +138,10 @@ jobs:
       GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'"
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: initialize vcpkg
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'microsoft/vcpkg'
         path: 'compat/vcbuild/vcpkg'

@@ -258,7 +258,7 @@ jobs:
       runs_on_pool: ${{matrix.vector.pool}}
     runs-on: ${{matrix.vector.pool}}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

@@ -291,7 +291,7 @@ jobs:
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v3
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

@@ -311,7 +311,7 @@ jobs:
       jobname: StaticAnalysis
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-static-analysis.sh
     - run: ci/check-directional-formatting.bash

@@ -331,7 +331,7 @@ jobs:
         artifact: sparse-20.04
     - name: Install the current `sparse` package
       run: sudo dpkg -i sparse-20.04/sparse_*.deb
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Install other dependencies
       run: ci/install-dependencies.sh
     - run: make sparse

@@ -343,6 +343,6 @@ jobs:
       jobname: Documentation
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/test-documentation.sh

Signature · 1 line

gitgitgadget

Junio C Hamano

2022-10-10 20:56 UTC #2 lore raw

Quoted 9 lines · Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>
to be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches.
Signed-off-by Oscar Dominguez Celada <[email protected]>
---
 .github/workflows/main.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Hmph. When 0dc787a9 (ci: accelerate the checkout, 2021-07-04) updated us from actions/checkout@v1 to actions/checkout@v2 it listed a lot more concrete "what we gain by doing this change", than the hand-wavy "opens the door" argument.

And it left container jobs at @v1 with an explanation that @v2 seemed to be incompatible. If the issue has that been resolved in @v3, it would be necessary to say that the issue has been resolved and it is safe to use @v3 there in the proposed log message.

Quoted 14 lines

.github/workflows/main.yml +1 -1

index 831f4df56c5..8dc9d938159 100644
...

@@ -291,7 +291,7 @@ jobs:
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v3
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

Junio C Hamano

2022-10-10 21:02 UTC #4 lore raw

Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2

In reply to Oscar Dominguez via GitGitGadget

Quoted 8 lines · Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>
to prevent issue tracked in https://github.com/actions/checkout/issues/560
Signed-off-by Oscar Dominguez <[email protected]>
---
 .github/workflows/main.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

So, this is "[Patch 1/2] broke the musl job by blindly updating them to v3 and here is a fix-up" patch? Can we rearrange so that we have no such "oops here is a fix" that breaks bisection easily?

Quoted 26 lines

.github/workflows/main.yml +4 -1

index 8dc9d938159..4eb5042f0d6 100644
@@ -281,17 +281,20 @@ jobs:
         vector:
         - jobname: linux-musl
           image: alpine
+          checkout_version: 3
         - jobname: linux32
           os: ubuntu32
           image: daald/ubuntu32:xenial
+          checkout_version: 2
         - jobname: pedantic
           image: fedora
+          checkout_version: 3
     env:
       jobname: ${{matrix.vector.jobname}}
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@${{matrix.vector.checkout_version}}
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

Junio C Hamano

2022-10-10 21:43 UTC #5 lore raw

Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2

In reply to Oscar Dominguez via GitGitGadget

Quoted 14 lines · Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>
to prevent issue tracked in https://github.com/actions/checkout/issues/560
Signed-off-by Oscar Dominguez <[email protected]>
---
 .github/workflows/main.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
.github/workflows/main.yml +0 -0
index 8dc9d938159..4eb5042f0d6 100644

.github/workflows/main.yml jobs: · line 300

Quoted 7 lines

.github/workflows/main.yml +1 -1

@@ -281,17 +281,20 @@ jobs:
...
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@${{matrix.vector.checkout_version}}
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

I think the breakage we see in

    https://github.com/git/git/actions/runs/3222517697

is due to this change.

Oscar Dominguez via GitGitGadget

author

2022-12-05 10:01 UTC #6 lore raw

PATCH v2 1/1 ci(main): upgrade actions/checkout to v3

In reply to Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>

To be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches.

This also avoids a couple of deprecation warnings in the CI runs.

Note: The actions/checkout Action has been known to be broken in i686 containers as of v2, therefore we keep forcing it to v1 there. See actions/runner#2115 for more details.

Signed-off-by Oscar Dominguez <[email protected]>

Signed-off-by Junio C Hamano <[email protected]>

Signed-off-by Johannes Schindelin <[email protected]>

---
ci(main): upgrade actions/checkout to v3

Description
===========

Upgrades actions/checkout to v3 in .github/workflows/main.yml

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v2
Pull-Request: https://github.com/git/git/pull/1354

Range-diff vs v1:

1: 2dbb779f7fd ! 1: 26fad15f97a ci(main): upgrade actions/checkout to v3
@@ Metadata
## Commit message ##
ci(main): upgrade actions/checkout to v3

- to be up to date with actions/checkout opens the door to use the latest
+ To be up to date with actions/checkout opens the door to use the latest
features if necessary and get the latest security patches.

- Signed-off-by: Oscar Dominguez Celada <[email protected]>
+ This also avoids a couple of deprecation warnings in the CI runs.
+
+ Note: The actions/checkout Action has been known to be broken in i686
+ containers as of v2, therefore we keep forcing it to v1 there. See
+ actions/runner#2115 for more details.
+
+ Signed-off-by: Oscar Dominguez <[email protected]>
+ Signed-off-by: Junio C Hamano <[email protected]>
+ Signed-off-by: Johannes Schindelin <[email protected]>

## .github/workflows/main.yml ##
@@ .github/workflows/main.yml: jobs:
@@ .github/workflows/main.yml: jobs:
runs-on: ubuntu-latest
container: ${{matrix.vector.image}}
steps:
-- - uses: actions/checkout@v1
+ - uses: actions/checkout@v3
++ if: matrix.vector.jobname != 'linux32'
+ - uses: actions/checkout@v1
++ if: matrix.vector.jobname == 'linux32'
- run: ci/install-docker-dependencies.sh
- run: ci/run-build-and-tests.sh
- name: print test failures
2: 4ee163b9a2c < -: ----------- ci(main): linux32 uses actions/checkout@v2

 .github/workflows/main.yml | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

.github/workflows/main.yml +10 -7

index 831f4df56c5..5262823eb1c 100644
@@ -83,7 +83,7 @@ jobs:
     if: needs.ci-config.outputs.enabled == 'yes'
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: build
       shell: bash

@@ -138,10 +138,10 @@ jobs:
       GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'"
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: initialize vcpkg
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'microsoft/vcpkg'
         path: 'compat/vcbuild/vcpkg'

@@ -258,7 +258,7 @@ jobs:
       runs_on_pool: ${{matrix.vector.pool}}
     runs-on: ${{matrix.vector.pool}}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

@@ -291,7 +291,10 @@ jobs:
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
+    - uses: actions/checkout@v3
+      if: matrix.vector.jobname != 'linux32'
     - uses: actions/checkout@v1
+      if: matrix.vector.jobname == 'linux32'
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures

@@ -311,7 +314,7 @@ jobs:
       jobname: StaticAnalysis
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-static-analysis.sh
     - run: ci/check-directional-formatting.bash

@@ -331,7 +334,7 @@ jobs:
         artifact: sparse-20.04
     - name: Install the current `sparse` package
       run: sudo dpkg -i sparse-20.04/sparse_*.deb
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Install other dependencies
       run: ci/install-dependencies.sh
     - run: make sparse

@@ -343,6 +346,6 @@ jobs:
       jobname: Documentation
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/test-documentation.sh

base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb

Signature · 1 line

gitgitgadget

Junio C Hamano

2022-12-05 23:28 UTC #7 lore raw

Quoted 7 lines · Oscar Dominguez via GitGitGadget

From: Oscar Dominguez <[email protected]>
To be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches.
This also avoids a couple of deprecation warnings in the CI runs.

Quoted 8 lines

Note: The actions/checkout Action has been known to be broken in i686 containers as of v2, therefore we keep forcing it to v1 there. See actions/runner#2115 for more details.
Signed-off-by Oscar Dominguez <[email protected]>
Signed-off-by Junio C Hamano <[email protected]>
Signed-off-by Johannes Schindelin <[email protected]>
---

I do not know about Johannes, but the latter two S-o-b by others are very questionable, as this is the first time I see this iteration of the patch. The chain of S-o-b is used to record that the author handed the patch to somebody else who forwarded it to another (i.e. the order of custody), and the above makes it look as if I picked this iteration of your patch up, passed it to Johannes, and he gave it to the mailing list readers with this message.

If you wanted to say "Input from Johannes helped me greatly while I polished the earlier work to produce this version", it is more appropriate to end the proposed log message with:

Helped-by: Johannes Schindelin <...>
Signed-off-by: Oscar Dominguez <...>

in chronological order.

In any case, I've been disturbed by the "Node 12 is going away, use the one that works with Node 16" warning at GitHub CI for the past few weeks and it is very welcome to see this topic moving forward.

Thanks for working on it.

Junio C Hamano

2022-12-06 08:24 UTC #8 lore raw

PATCH 1/1 ci: use actions/{upload,download}-artifact@v3

In reply to Oscar Dominguez via GitGitGadget

GitHub CI jobs stopped complaining about use of deprecated actions that requires deprecated Node.js 12 for some steps, thanks to a recent work by Oscar Dominguez to upgrade actions/checkout from v2 (which required Node.js 12) to v3 (which runs with recommended Node.js 16).

Upgrade actions/upload-artifact and actions/download-artifact from v2 to v3, following suit.

Signed-off-by Junio C Hamano <[email protected]>

---
* The CI run hasn't finished, but it seems to be doing well
https://github.com/git/git/actions/runs/3627513480

We are also getting complaint about our use of set-output command that is deprecated, which will need to be addressed, too.

 .github/workflows/main.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

.github/workflows/main.yml +7 -7

index 5262823eb1..7a24c6613e 100644
@@ -94,7 +94,7 @@ jobs:
     - name: zip up tracked files
       run: git archive -o artifacts/tracked.tar.gz HEAD
     - name: upload tracked files and build artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: windows-artifacts
         path: artifacts

@@ -108,7 +108,7 @@ jobs:
         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
     steps:
     - name: download tracked files and build artifacts
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v3
       with:
         name: windows-artifacts
         path: ${{github.workspace}}

@@ -125,7 +125,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: failed-tests-windows
         path: ${{env.FAILED_TEST_ARTIFACTS}}

@@ -177,7 +177,7 @@ jobs:
     - name: zip up tracked files
       run: git archive -o artifacts/tracked.tar.gz HEAD
     - name: upload tracked files and build artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: vs-artifacts
         path: artifacts

@@ -192,7 +192,7 @@ jobs:
     steps:
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: download tracked files and build artifacts
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v3
       with:
         name: vs-artifacts
         path: ${{github.workspace}}

@@ -210,7 +210,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: failed-tests-windows
         path: ${{env.FAILED_TEST_ARTIFACTS}}

@@ -267,7 +267,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: failed-tests-${{matrix.vector.jobname}}
         path: ${{env.FAILED_TEST_ARTIFACTS}}

Signature · 1 line

2.39.0-rc2

Johannes Schindelin

2022-12-06 21:21 UTC #9 lore raw

Re: [PATCH] ci: use actions/{upload,download}-artifact@v3

Hi Junio,

Quoted 9 lines · Junio C Hamano

GitHub CI jobs stopped complaining about use of deprecated actions that requires deprecated Node.js 12 for some steps, thanks to a recent work by Oscar Dominguez to upgrade actions/checkout from v2 (which required Node.js 12) to v3 (which runs with recommended Node.js 16).
Upgrade actions/upload-artifact and actions/download-artifact from v2 to v3, following suit.

Quoted 7 lines

Signed-off-by Junio C Hamano <[email protected]>
---
* The CI run hasn't finished, but it seems to be doing well
https://github.com/git/git/actions/runs/3627513480
We are also getting complaint about our use of set-output command that is deprecated, which will need to be addressed, too.

See below.

Quoted 53 lines

 .github/workflows/main.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

.github/workflows/main.yml +5 -5

index 5262823eb1..7a24c6613e 100644
@@ -94,7 +94,7 @@ jobs:
     - name: zip up tracked files
       run: git archive -o artifacts/tracked.tar.gz HEAD
     - name: upload tracked files and build artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: windows-artifacts
         path: artifacts

@@ -108,7 +108,7 @@ jobs:
         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
     steps:
     - name: download tracked files and build artifacts
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v3
       with:
         name: windows-artifacts
         path: ${{github.workspace}}

@@ -125,7 +125,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: failed-tests-windows
         path: ${{env.FAILED_TEST_ARTIFACTS}}

@@ -177,7 +177,7 @@ jobs:
     - name: zip up tracked files
       run: git archive -o artifacts/tracked.tar.gz HEAD
     - name: upload tracked files and build artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: vs-artifacts
         path: artifacts

@@ -192,7 +192,7 @@ jobs:
     steps:
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: download tracked files and build artifacts
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v3
       with:
         name: vs-artifacts
         path: ${{github.workspace}}

.github/workflows/main.yml jobs: · line 213

Quoted 5 lines

.github/workflows/main.yml +1 -1

@@ -210,7 +210,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3

This is probably incorrect, but you wouldn't know until something failed in the linux32 job.

I already have a correct fix in
https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations.

Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to next once it is done, and the other patches following after that?

Ciao,
Johannes

Quoted 17 lines

.github/workflows/main.yml +1 -2

       with:
         name: failed-tests-windows
         path: ${{env.FAILED_TEST_ARTIFACTS}}

@@ -267,7 +267,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: failed-tests-${{matrix.vector.jobname}}
         path: ${{env.FAILED_TEST_ARTIFACTS}}
--

2.39.0-rc2

Junio C Hamano

2022-12-06 23:41 UTC #10 lore raw

Re: [PATCH] ci: use actions/{upload,download}-artifact@v3

Quoted 9 lines · Johannes Schindelin

.github/workflows/main.yml jobs: · line 213
Quoted 6 lines
.github/workflows/main.yml +1 -1
@@ -210,7 +210,7 @@ jobs:
       run: ci/print-test-failures.sh
     - name: Upload failed tests' directories
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
This is probably incorrect, but you wouldn't know until something failed in the linux32 job.

Yeah, that was what I was afraid to see.

Quoted 5 lines

I already have a correct fix in
https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations.

Wonderful.

Quoted 3 lines

Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to next once it is done, and the other patches following after that?

That was what I was planning to do anyway. Thanks.

Junio C Hamano

2022-12-07 00:35 UTC #11 lore raw

Re: [PATCH] ci: use actions/{upload,download}-artifact@v3

Quoted 11 lines · Junio C Hamano

Quoted 2 lines
This is probably incorrect, but you wouldn't know until something failed in the linux32 job.
Yeah, that was what I was afraid to see.
Quoted 5 lines
I already have a correct fix in
https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations.

Quoted 7 lines

Wonderful.
Quoted 3 lines
Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to next once it is done, and the other patches following after that?
That was what I was planning to do anyway. Thanks.

Eh, I should have made my intention clear. I'll drop this one (as I posted it primarily to fish out those who are interested in and more capable than I am at clearing the deprecation warnings from the CI), will mark Oscar's for 'next' (if I haven't done so already), wait for your updates and queue them on a topic forked from Oscar's (or on the same Oscar's topic), and cook them for the first or the second batch of the next cycle.

Thanks.

Johannes Schindelin

2022-12-07 12:34 UTC #12 lore raw

Re: [PATCH] ci: use actions/{upload,download}-artifact@v3

Hi Junio,

Quoted 21 lines · Junio C Hamano

Quoted 11 lines · Junio C Hamano
Quoted 2 lines
This is probably incorrect, but you wouldn't know until something failed in the linux32 job.
Yeah, that was what I was afraid to see.
Quoted 5 lines
I already have a correct fix in
https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations.
Quoted 7 lines
Wonderful.
Quoted 3 lines
Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to next once it is done, and the other patches following after that?
That was what I was planning to do anyway. Thanks.

Quoted 7 lines

Eh, I should have made my intention clear. I'll drop this one (as I posted it primarily to fish out those who are interested in and more capable than I am at clearing the deprecation warnings from the CI), will mark Oscar's for 'next' (if I haven't done so already), wait for your updates and queue them on a topic forked from Oscar's (or on the same Oscar's topic), and cook them for the first or the second batch of the next cycle.

Thank you for clarifying your intention, much appreciated.

Ciao,
Johannes