Fix two grammar errors related to the word "save"
cover Fix two grammar errors related to the word "save"
I stumbled over the one in git-compat-util.h while working on an unrelated bug fix, and then got curious whether there are other places where we use save instead of safe, too. Turns out we do not, but there was another grammar error where a spurious . interrupted a sentence.
Johannes Schindelin (2):
git-compat-util.h: fix typo
remote-curl: remove spurious period
git-compat-util.h | 2 +- remote-curl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
base-commit: 1d89318c48d233d52f1db230cf622935ac3c69fa
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-16%2Fdscho%2Fsave-typos-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-16/dscho/save-typos-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/16
Signature · 1 line
gitgitgadget
PATCH 1/2 git-compat-util.h: fix typo
From: Johannes Schindelin <[email protected]>
The words "save" and "safe" are both very wonderful words, each with their own set of meanings. Let's not confuse them with one another save on occasion of a pun.
--- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
git-compat-util.h +1 -1
@@ -220,7 +220,7 @@#endif #ifdef NO_INTPTR_T /* -* On I16LP32, ILP32 and LP64 "long" is the save bet, however +* On I16LP32, ILP32 and LP64 "long" is the safe bet, however * on LLP86, IL33LLP64 and P64 it needs to be "long long", * while on IP16 and IP16L32 it is "int" (resp. "short") * Size needs to match (or exceed) 'sizeof(void *)'.
Signature · 1 line
gitgitgadget
PATCH 2/2 remote-curl: remove spurious period
In reply to Johannes Schindelin via GitGitGadgetFrom: Johannes Schindelin <[email protected]>
We should not interrupt. sentences in the middle.
--- remote-curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
remote-curl.c +1 -1
@@ -714,7 +714,7 @@ retry: }else if (use_gzip &&1024 < rpc->len) {/* The client backend isn't giving us compressed data so -* we can try to deflate it ourselves, this may save on. +* we can try to deflate it ourselves, this may save on * the transfer time. */ git_zstream stream;
Signature · 1 line
gitgitgadget
"Johannes Schindelin via GitGitGadget" <[email protected]>
Quoted 5 lines · writes:
I stumbled over the one in
git-compat-util.hwhile working on an unrelated bug fix, and then got curious whether there are other places where we use save instead of safe, too. Turns out we do not, but there was another grammar error where a spurious . interrupted a sentence.
Quoted 7 lines
Johannes Schindelin (2):
git-compat-util.h: fix typo
remote-curl: remove spurious periodgit-compat-util.h | 2 +- remote-curl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Fix for typos made in 2009 and 2012, better late than never ;-)
Will queue.
Re: [PATCH 2/2] remote-curl: remove spurious period
In reply to Johannes Schindelin via GitGitGadgetQuoted 2 lines · Johannes Schindelin via GitGitGadget
We should not interrupt. sentences in the middle.
I love this. commit message. :-)
...
Quoted 4 lines
/* The client backend isn't giving us compressed data soremote-curl.c +1
-1-* we can try to deflate it ourselves, this may save on. +* we can try to deflate it ourselves, this may save on * the transfer time.