chore: fix typo in .clang-format comment
PATCH 1/1 chore: fix typo in .clang-format comment
From: Aditya Neelamraju <[email protected]>
---
chore: fix typo in .clang-format comment
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v1
Pull-Request: https://github.com/git/git/pull/1602
.clang-format | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
.clang-format +3 -3
@@ -83,9 +83,9 @@ BinPackParameters: true BreakBeforeBraces: Linux # Break after operators -# int valuve = aaaaaaaaaaaaa + -# bbbbbb - -# ccccccccccc; +# int value = aaaaaaaaaaaaa + +# bbbbbb - +# ccccccccccc; BreakBeforeBinaryOperators: None BreakBeforeTernaryOperators: false
base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14
Signature · 1 line
gitgitgadget
Quoted 1 line · Aditya Neelamraju via GitGitGadget
From: Aditya Neelamraju <[email protected]>
We typically prefix commit messages with the subject area they're working in, not with "chore", or "feat" like some Git workflows recommend.
That said, the contents of this patch look obviously correct to me. Thanks for noticing and fixing!
Thanks,
Taylor
Quoted 9 lines · Taylor Blau
Quoted 1 line · Aditya Neelamraju via GitGitGadget
From: Aditya Neelamraju <[email protected]>
We typically prefix commit messages with the subject area they're working in, not with "chore", or "feat" like some Git workflows recommend.
...
That said, the contents of this patch look obviously correct to me. Thanks for noticing and fixing!
As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think.
I also suspected that valuve may be a valid word in some language, as the indentation in the example looked as if the six-letter word was meant, not typoed. https://www.gasolineravaluve.com/ was one of the first hits I saw in my search ;-)
PATCH v2 1/1 clang-format: fix typo in comment
In reply to Aditya Neelamraju via GitGitGadgetFrom: Aditya Neelamraju <[email protected]>
---
clang-format: fix typo in comment for formatting binary operations.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v2
Pull-Request: https://github.com/git/git/pull/1602
Range-diff vs v1:
1: e3ff8aa76fe ! 1: dfb442ea338 chore: fix typo in .clang-format comment
@@ Metadata
Author: Aditya Neelamraju <[email protected]>
## Commit message ##
- chore: fix typo in .clang-format comment
+ clang-format: fix typo in comment
.clang-format | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
.clang-format +3 -3
@@ -83,9 +83,9 @@ BinPackParameters: true BreakBeforeBraces: Linux # Break after operators -# int valuve = aaaaaaaaaaaaa + -# bbbbbb - -# ccccccccccc; +# int value = aaaaaaaaaaaaa + +# bbbbbb - +# ccccccccccc; BreakBeforeBinaryOperators: None BreakBeforeTernaryOperators: false
base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14
Signature · 1 line
gitgitgadget
Quoted 12 lines · Junio C Hamano
Quoted 9 lines · Taylor Blau
Quoted 1 line · Aditya Neelamraju via GitGitGadget
From: Aditya Neelamraju <[email protected]>
We typically prefix commit messages with the subject area they're working in, not with "chore", or "feat" like some Git workflows recommend.
...
That said, the contents of this patch look obviously correct to me. Thanks for noticing and fixing!
Quoted 3 lines
As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think.
Good suggestion. I would have suggested "clang-format", which is exactly Aditya ended up choosing, anyway. Thanks, Aditya!
Quoted 4 lines
I also suspected that valuve may be a valid word in some language, as the indentation in the example looked as if the six-letter word was meant, not typoed. https://www.gasolineravaluve.com/ was one of the first hits I saw in my search ;-)
;-)
Thanks,
Taylor
Re: [PATCH v2] clang-format: fix typo in comment
In reply to Aditya Neelamraju via GitGitGadgetQuoted 4 lines · Aditya Neelamraju via GitGitGadget
From: Aditya Neelamraju <[email protected]>
Signed-off-by Aditya Neelamraju <[email protected]>---
Thanks, this version looks great to me.
Thanks,
Taylor
Quoted 6 lines · Taylor Blau
Quoted 3 lines
As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think.
Good suggestion. I would have suggested "clang-format", which is exactly Aditya ended up choosing, anyway. Thanks, Aditya!
Thanks. I was being lazy when I said the above ;-)
Teaching how to fish instead of giving fish, the way I would have done is
$ git log --no-merges --stat --full-diff .clang-format
and inspect what they use. The ones that used "clang-format:" are indeed very similar in spirit to what this one does, I would say.
Thanks.