Skip to contentSkip to conversation

strvec: drop unnecessary include of hex.h

PATCH In review Linus Arver via GitGitGadget 2 participants 2 messages Nov 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 strvec: drop unnecessary include of hex.h

From: Linus Arver <[email protected]>

In 41771fa435 (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

---
strvec: drop unnecessary include of hex.h

In 41771fa435 (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1608

 strvec.c | 1 -
 1 file changed, 1 deletion(-)
strvec.c +0 -1
index 89dc9e7e753..178f4f37480 100644
@@ -1,6 +1,5 @@
 #include "git-compat-util.h"
 #include "strvec.h"
-#include "hex.h"
 #include "strbuf.h"
 
 const char *empty_strvec[] = { NULL };

base-commit: bc5204569f7db44d22477485afd52ea410d83743

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 7 lines · Linus Arver via GitGitGadget

From: Linus Arver <[email protected]>

In 41771fa435 (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

Quoted 8 lines

---
strvec: drop unnecessary include of hex.h

In 41771fa435 (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

This change somehow looks familiar.

Quoted 12 lines

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1608

 strvec.c | 1 -
 1 file changed, 1 deletion(-)
strvec.c +0 -0
index 89dc9e7e753..178f4f37480 100644

strvec.c line 3

Quoted 4 lines
strvec.c +0 -1
@@ -1,6 +1,5 @@
 #include "git-compat-util.h"
 #include "strvec.h"
-#include "hex.h"
 #include "strbuf.h"

Makes sense.
Will queue.

Thanks.