Skip to contentSkip to conversation

docs: remove duplicate entry and fix typo in 2.45 changelog

PATCH In review Orgad Shaneh via GitGitGadget 3 participants 3 messages Apr 20, 2024 – Apr 22, 2024 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: remove duplicate entry and fix typo in 2.45 changelog

From: Orgad Shaneh <[email protected]>

---
docs: remove duplicate entry and fix typo in 2.45 changelog

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1711%2Forgads%2Fchangelog-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1711/orgads/changelog-v1
Pull-Request: https://github.com/git/git/pull/1711

 Documentation/RelNotes/2.45.0.txt | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Documentation/RelNotes/2.45.0.txt +1 -4
index 0570dcd8773..38458664407 100644
@@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
 
  * The way placeholders are to be marked-up in documentation have been
    specified; use "_<placeholder>_" to typeset the word inside a pair
-   of <angle-brakets> emphasized.
+   of <angle-brackets> emphasized.
 
  * "git --no-lazy-fetch cmd" allows to run "cmd" while disabling lazy
    fetching of objects from the promisor remote, which may be handy
@@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
    clean.requireForce has been simplified, together with the
    documentation.
 
- * The code to iterate over refs with the reftable backend has seen
-   some optimization.
-
  * Uses of xwrite() helper have been audited and updated for better
    error checking and simpler code.
 

base-commit: ae3196a5ea84a9e88991d576020cf66512487088

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 13 lines · Orgad Shaneh via GitGitGadget

From: Orgad Shaneh <[email protected]>

---

 Documentation/RelNotes/2.45.0.txt | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Documentation/RelNotes/2.45.0.txt +0 -0
index 0570dcd8773..38458664407 100644

Documentation/RelNotes/2.45.0.txt Performance, Internal Implementation, Development Support etc. · line 103

Quoted 5 lines
Documentation/RelNotes/2.45.0.txt +1 -1
@@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
 
  * The way placeholders are to be marked-up in documentation have been
    specified; use "_<placeholder>_" to typeset the word inside a pair
-   of <angle-brakets> emphasized.
+   of <angle-brackets> emphasized.

Thanks.

Documentation/RelNotes/2.45.0.txt Performance, Internal Implementation, Development Support etc. · line 114

Quoted 9 lines
Documentation/RelNotes/2.45.0.txt +0 -3
@@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
    clean.requireForce has been simplified, together with the
    documentation.
 
- * The code to iterate over refs with the reftable backend has seen
-   some optimization.
-
  * Uses of xwrite() helper have been audited and updated for better
    error checking and simpler code.

Interesting. It is likely that we had two topics that did things that summarised down to the same description. They are

448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14) 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)

I do not know which is better between removing the second entry (which is what this patch is doing, as the entries are in chronological order of the topics' graduation to 'master'), or amending it to say "has seen some more optimization".

#2 lore raw
Quoted 18 lines · Junio C Hamano

Documentation/RelNotes/2.45.0.txt Performance, Internal Implementation, Development Support etc. · line 114

Quoted 12 lines · Orgad Shaneh via GitGitGadget

From: Orgad Shaneh <[email protected]>

Documentation/RelNotes/2.45.0.txt +0 -3
@@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
    clean.requireForce has been simplified, together with the
    documentation.
 
- * The code to iterate over refs with the reftable backend has seen
-   some optimization.
-
  * Uses of xwrite() helper have been audited and updated for better
    error checking and simpler code.

Interesting. It is likely that we had two topics that did things that summarised down to the same description. They are

Quoted 7 lines

448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14) 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)

I do not know which is better between removing the second entry (which is what this patch is doing, as the entries are in chronological order of the topics' graduation to 'master'), or amending it to say "has seen some more optimization".

Squashing these into a single entry should be fine in my opinion. The split was artificial anyway to make the review process easier.

Patrick