Skip to contentSkip to conversation

doc: add missing commit C to the graph for --ancestry-path=H D..M

PATCH In review Han Jiang via GitGitGadget 3 participants 3 messages Mar 16, 2025 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: add missing commit C to the graph for --ancestry-path=H D..M

From: Han Jiang <[email protected]>

The graph for --ancestry-path=H D..M should contain commit C.

---
doc: add missing commit C to the graph for --ancestry-path=H D..M

cc Elijah Newren [email protected],D. Ben Knoble [email protected]

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1883%2Fjhcarl0814%2Fpatch_ancestry_path_doc_graph_20250315-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1883/jhcarl0814/patch_ancestry_path_doc_graph_20250315-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1883

 Documentation/rev-list-options.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/rev-list-options.adoc +1 -1
index 785c0786e0c..5e5cedb9127 100644
@@ -640,7 +640,7 @@ commits affected by that topic, we may only want to view the subset of
 -----------------------------------------------------------------------
 		E
 		 \
-		  G---H---I---J
+	      C---G---H---I---J
 			       \
 				L--M
 -----------------------------------------------------------------------

base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 4 lines · Han Jiang via GitGitGadget

From: Han Jiang <[email protected]>

The graph for --ancestry-path=H D..M should contain commit C.

Yep, C is in the range D..M and C is also an ancestor of H.

Quoted 5 lines

---
doc: add missing commit C to the graph for --ancestry-path=H D..M

cc Elijah Newren [email protected],D. Ben Knoble [email protected]

In the future, you'll probably want to use separate cc lines for each person you are cc'ing; I think gitgitgadget expects that to work. You also might want to add a space after the "cc:", though I don't know if that's required.

Quoted 21 lines

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1883%2Fjhcarl0814%2Fpatch_ancestry_path_doc_graph_20250315-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1883/jhcarl0814/patch_ancestry_path_doc_graph_20250315-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1883

 Documentation/rev-list-options.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/rev-list-options.adoc +1 -1
index 785c0786e0c..5e5cedb9127 100644
@@ -640,7 +640,7 @@ commits affected by that topic, we may only want to view the subset of
 -----------------------------------------------------------------------
                E
                 \
-                 G---H---I---J
+             C---G---H---I---J
                               \
                                L--M
 -----------------------------------------------------------------------
Quoted 3 lines

base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e --
gitgitgadget

Patch looks good.

#2 lore raw
Quoted 5 lines · Elijah Newren

In the future, you'll probably want to use separate cc lines for each person you are cc'ing; I think gitgitgadget expects that to work. You also might want to add a space after the "cc:", though I don't know if that's required.

Thank you for your suggestion! I will follow it next time.