Skip to contentSkip to conversation

commit-graph: emit trace2 cmd_mode for each sub-command

PATCH In review Garima Singh via GitGitGadget 4 participants 5 messages Aug 27, 2019 – Oct 2, 2019

lore
Share & tools
lore

Garima Singh via GitGitGadget

author
#0 lore raw

cover commit-graph: emit trace2 cmd_mode for each sub-command

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start.

Signed-off-by Garima Singh [email protected]
[[email protected]]

CC: [email protected], [email protected], [email protected], [email protected]

Garima Singh (1):
commit-graph: emit trace2 cmd_mode for each sub-command

 builtin/commit-graph.c | 6 ++++++
 1 file changed, 6 insertions(+)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323

Signature · 1 line
gitgitgadget
author
#1 lore raw

PATCH 1/1 commit-graph: emit trace2 cmd_mode for each sub-command

From: Garima Singh <[email protected]>

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start.

Signed-off-by Garima Singh <[email protected]>
---
 builtin/commit-graph.c | 6 ++++++
 1 file changed, 6 insertions(+)
builtin/commit-graph.c +6 -0
index 57863619b7..ef68b26744 100644
@@ -58,6 +58,8 @@ static int graph_verify(int argc, const char **argv)
 		OPT_END(),
 	};
 
+	trace2_cmd_mode("verify");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_verify_options,
 			     builtin_commit_graph_verify_usage, 0);

@@ -102,6 +104,8 @@ static int graph_read(int argc, const char **argv)
 		OPT_END(),
 	};
 
+	trace2_cmd_mode("read");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_read_options,
 			     builtin_commit_graph_read_usage, 0);

@@ -183,6 +187,8 @@ static int graph_write(int argc, const char **argv)
 	split_opts.max_commits = 0;
 	split_opts.expire_time = 0;
 
+	trace2_cmd_mode("write");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_write_options,
 			     builtin_commit_graph_write_usage, 0);
Signature · 1 line
gitgitgadget
#2 lore raw
In reply to Garima Singh via GitGitGadget

Ping :) Any thoughts on this?

Quoted 25 lines · Garima Singh via GitGitGadget

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start.

Signed-off-by Garima Singh [email protected]
[[email protected]]

CC: [email protected], [email protected], [email protected], [email protected]

Garima Singh (1):
commit-graph: emit trace2 cmd_mode for each sub-command

  builtin/commit-graph.c | 6 ++++++
  1 file changed, 6 insertions(+)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323

#3 lore raw
Quoted 29 lines · Garima Singh

Ping :) Any thoughts on this?

Quoted 26 lines · Garima Singh via GitGitGadget

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start.

Signed-off-by Garima Singh [email protected]
[[email protected]]

CC: [email protected], [email protected], [email protected], [email protected]

Garima Singh (1):
   commit-graph: emit trace2 cmd_mode for each sub-command

  builtin/commit-graph.c | 6 ++++++

  1 file changed, 6 insertions(+)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1

Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323

Looks good to me. Thanks!

Signed-off-by Jeff Hostetler <[email protected]>
#4 lore raw

Hi,

Quoted 30 lines · Jeff Hostetler
Quoted 29 lines · Garima Singh

Ping :) Any thoughts on this?

Quoted 26 lines · Garima Singh via GitGitGadget

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the
various modes within them. Distinguishing between read, write and verify is
a great start.

Signed-off-by Garima Singh [email protected]
[[email protected]]

CC: [email protected], [email protected], [email protected], [email protected]

Garima Singh (1):
   commit-graph: emit trace2 cmd_mode for each sub-command

  builtin/commit-graph.c | 6 ++++++

  1 file changed, 6 insertions(+)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 Published-As:
https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323

Looks good to me. Thanks!

This was not yet picked up into pu, correct? Or did I miss anything?

Ciao,
Dscho

Quoted 4 lines
Signed-off-by Jeff Hostetler <[email protected]>