Skip to contentSkip to conversation

Fix stale .gitignore change, introduced via js/visual-studio

PATCH In review Johannes Schindelin via GitGitGadget 2 participants 3 messages Sep 5, 2019

lore
Share & tools
lore
#0 lore raw

cover Fix stale .gitignore change, introduced via js/visual-studio

As reported in
https://public-inbox.org/git/[email protected]/, we added a line to ignore .manifest files, but that is a left-over from a long time ago, before we added and used compat/win32/git.manifest.

This fixes that left-over.

Johannes Schindelin (1):
.gitignore: stop ignoring .manifest files

 .gitignore | 1 -
 1 file changed, 1 deletion(-)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-332%2Fdscho%2Fstop-ignoring-manifest-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-332/dscho/stop-ignoring-manifest-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/332

Signature · 1 line
gitgitgadget
#1 lore raw

PATCH 1/1 .gitignore: stop ignoring `.manifest` files

From: Johannes Schindelin <[email protected]>

On Windows, it is possible to embed additional metadata into an executable by linking in a "manifest", i.e. an XML document that describes capabilities and requirements (such as minimum or maximum Windows version). These XML documents are expected to be stored in .manifest files.

At least _some_ Visual Studio versions auto-generate .manifest files when none is specified explicitly, therefore we used to ask Git to ignore them.

However, we do have a beautiful .manifest file now:
compat/win32/git.manifest, so neither does Visual Studio auto-generate a manifest for us, nor do we want Git to ignore the .manifest files anymore.

Further reading on auto-generated .manifest files:
https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio

---
 .gitignore | 1 -
 1 file changed, 1 deletion(-)
.gitignore +0 -1
index 521d8f4fb4..fc445edea9 100644
@@ -231,7 +231,6 @@
 *.ipdb
 *.dll
 .vs/
-*.manifest
 Debug/
 Release/
 /UpgradeLog*.htm
Signature · 1 line
gitgitgadget
#2 lore raw

Re: [PATCH 1/1] .gitignore: stop ignoring `.manifest` files

"Johannes Schindelin via GitGitGadget" <[email protected]>

Quoted 8 lines · writes:

...
Further reading on auto-generated .manifest files:
https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio

---
 .gitignore | 1 -
 1 file changed, 1 deletion(-)

Thanks.

Quoted 12 lines
.gitignore +0 -1
index 521d8f4fb4..fc445edea9 100644
@@ -231,7 +231,6 @@
 *.ipdb
 *.dll
 .vs/
-*.manifest
 Debug/
 Release/
 /UpgradeLog*.htm