Skip to contentSkip to conversation

gitk: Preserve window dimensions on exit when not using ttk themes

PATCH In review Eric Huber via GitGitGadget 2 participants 3 messages Oct 15, 2019 – Dec 15, 2019

lore
Share & tools
lore
#0 lore raw

cover gitk: Preserve window dimensions on exit when not using ttk themes

This fix is intended to let gitk preserve the window pane dimensions regardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but as far as I can tell, this edit works and doesn't cause problems. Please double-check what I did.

Eric Huber (1):
gitk: Preserve window dimensions on exit when not using ttk themes

 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-389%2Fechuber2%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-389/echuber2/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/389

Signature · 1 line
gitgitgadget
#1 lore raw

PATCH 1/1 gitk: Preserve window dimensions on exit when not using ttk themes

From: Eric Huber <[email protected]>

Bug was: gitk would overwrite the botwidth setting in .gitk with a nonsense value when not using tk themes. I'm not sure if this is the right fix or not but it seems to work. Moving the affected line within the conditional results in the expected behavior.

---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
gitk-git/gitk +2 -2
index abe4805ade..4846f2a983 100755
@@ -2526,9 +2526,9 @@ proc makewindow {} {
             bind %W <Map> {}
             %W sashpos 0 $::geometry(botwidth)
         }
+	bind .pwbottom <Configure> {resizecdetpanes %W %w}
     }
-
-    bind .pwbottom <Configure> {resizecdetpanes %W %w}
+    
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
     #bindall <B1-Motion> {selcanvline %W %x %y}
Signature · 1 line
gitgitgadget
#2 lore raw
Quoted 8 lines · Eric Huber via GitGitGadget

From: Eric Huber <[email protected]>

Bug was: gitk would overwrite the botwidth setting in .gitk with a nonsense value when not using tk themes. I'm not sure if this is the right fix or not but it seems to work. Moving the affected line within the conditional results in the expected behavior.

Thanks, patch applied.

Paul.