GitHub workflow: automatically follow minor updates of setup-msbuild

From: Johannes Schindelin <[email protected]>

It is the custom to follow minor updates of GitHub Actions automatically, by using the suffix @v1. Actions' maintainers will then update that v1 ref to point to the newest.

However, for microsoft/setup-msbuild, 889cacb6897 (ci: configure GitHub Actions for CI/PR, 2020-04-11) uses a very specific @v1.0.0 suffix.

In this instance, that is a problem: should setup-msbuild release a new version that intends to fix a critical bug, we won't know it, and we won't use it.

Such a scenario is not theoretical. It is happening right now:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands

Let's simplify our setup, allowing us to benefit from automatically using the newest v1.x.

---
GitHub workflow: automatically follow minor updates of setup-msbuild

This patch was based on dd/ci-swap-azure-pipelines-with-github-actions, but due to changes outside of Git, that GitHub workflow does not even begin to work anymore. Therefore, the patch is now actually based on master.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-744%2Fdscho%2Fsimplify-setup-msbuild-upgrades-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-744/dscho/simplify-setup-msbuild-upgrades-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/744

 .github/workflows/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index fcfd138ff1..14ff94dcbe 100644
@@ -154,7 +154,7 @@ jobs:
         Expand-Archive compat.zip -DestinationPath . -Force
         Remove-Item compat.zip
     - name: add msbuild to PATH
-      uses: microsoft/[email protected]
+      uses: microsoft/setup-msbuild@v1
     - name: copy dlls to root
       shell: powershell
       run: |

base-commit: d98273ba77e1ab9ec755576bc86c716a97bf59d7

gitgitgadget

Thanks, that explanation makes perfect sense and the patch looks obviously correct.

-Peff