Skip to contentSkip to conversation

t3040: remove stale note

PATCH In review Johannes Schindelin via GitGitGadget 3 participants 3 messages Nov 18, 2020 – Nov 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t3040: remove stale note

From: Johannes Schindelin <[email protected]>

This comment was most likely a "note to self" during the development of 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is neither needed nor comprehensible at this point. Let's remove it.

---
t3040: remove stale note

And yet another thing I noticed while working on
https://github.com/gitgitgadget/git/pull/762.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-793%2Fdscho%2Ft3040-and-default-branch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-793/dscho/t3040-and-default-branch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/793

 t/t3040-subprojects-basic.sh | 3 ---
 1 file changed, 3 deletions(-)
t/t3040-subprojects-basic.sh +0 -3
index b81eb5fd6f..6abdcbbc94 100755
@@ -79,7 +79,4 @@ test_expect_success 'checkout in superproject' '
 	git diff-index --exit-code --raw --cached save -- sub1
 '
 
-# just interesting what happened...
-# git diff --name-status -M save master
-
 test_done

base-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500

Signature · 1 line
gitgitgadget
#1 lore raw

"Johannes Schindelin via GitGitGadget" <[email protected]>

Quoted 6 lines · writes:

From: Johannes Schindelin <[email protected]>

This comment was most likely a "note to self" during the development of 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is neither needed nor comprehensible at this point. Let's remove it.

Quoted 6 lines

---
t3040: remove stale note

And yet another thing I noticed while working on
https://github.com/gitgitgadget/git/pull/762.

It seems that all test updates from you today are some form of refinement to the 27-patch series we have in 'seen'. I'll resolve conflicts in favor of these new ones as they look strict improvement (modulo @{2} thing I mentioned separately) in the meantime, but let's not forget to remove them from a reroll of the large series.

Thanks.

#2 lore raw

Hi Junio,

Quoted 13 lines · Junio C Hamano

"Johannes Schindelin via GitGitGadget" <[email protected]>

Quoted 10 lines · writes:

From: Johannes Schindelin <[email protected]>

This comment was most likely a "note to self" during the development of 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is neither needed nor comprehensible at this point. Let's remove it.

---
t3040: remove stale note

Quoted 8 lines
Quoted 2 lines

And yet another thing I noticed while working on
https://github.com/gitgitgadget/git/pull/762.

It seems that all test updates from you today are some form of refinement to the 27-patch series we have in 'seen'. I'll resolve conflicts in favor of these new ones as they look strict improvement (modulo @{2} thing I mentioned separately) in the meantime, but let's not forget to remove them from a reroll of the large series.

I didn't ;-) See
https://lore.kernel.org/git/[email protected]/

Ciao,
Dscho