Remove warning that repack only works on non-promisor packfiles
PATCH 1/1 Remove warning that repack only works on non-promisor packfiles
From: Tao Klerks <[email protected]>
The git-repack doc clearly states that it *does* operate on promisor packfiles (in a separate partition), with "-a" specified. Presumably the statements here are outdated, as they feature from the first doc in 2017 (and the repack support was added in 2018)
---
Remove warning that repack only works on non-promisor packfiles
The git-repack doc clearly states that it does operate on promisor packfiles (in a separate partition), with "-a" specified. Presumably the statements here are outdated, as they feature from the first doc in 2017 (and the repack support was added in 2018)
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-968%2FTaoK%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-968/TaoK/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/968
Documentation/technical/partial-clone.txt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
Documentation/technical/partial-clone.txt +1 -5
@@ -242,8 +242,7 @@ remote in a specific order. repository and can satisfy all such requests. - Repack essentially treats promisor and non-promisor packfiles as 2 - distinct partitions and does not mix them. Repack currently only works - on non-promisor packfiles and loose objects. + distinct partitions and does not mix them. - Dynamic object fetching invokes fetch-pack once *for each item* because most algorithms stumble upon a missing object and need to have
@@ -273,9 +272,6 @@ to use those promisor remotes in that order." The user might want to work in a triangular work flow with multiple promisor remotes that each have an incomplete view of the repository. -- Allow repack to work on promisor packfiles (while keeping them distinct - from non-promisor packfiles). - - Allow non-pathname-based filters to make use of packfile bitmaps (when present). This was just an omission during the initial implementation.
base-commit: ed125c4f07ba69c53c9f4d74ff395a4bf7854ea7
Signature · 1 line
gitgitgadget
Quoted 6 lines · Tao Klerks via GitGitGadget
From: Tao Klerks <[email protected]>
The git-repack doc clearly states that it *does* operate on promisor packfiles (in a separate partition), with "-a" specified. Presumably the statements here are outdated, as they feature from the first doc in 2017 (and the repack support was added in 2018)
Yeah, this all originally comes from Jeff H.'s design document in 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should have been updated in 5d19e8138d (repack: repack promisor objects if -a or -A is set, 2018-08-08).
This looks good to me, but I'll add Jonathan Tan to the CC list to double check.
Thanks,
Taylor
Quoted 13 lines · Tao Klerks via GitGitGadget
Quoted 6 lines
From: Tao Klerks <[email protected]>
The git-repack doc clearly states that it *does* operate on promisor packfiles (in a separate partition), with "-a" specified. Presumably the statements here are outdated, as they feature from the first doc in 2017 (and the repack support was added in 2018)
Yeah, this all originally comes from Jeff H.'s design document in
637fc4467e(partial-clone: design doc, 2017-12-14), but probably should have been updated in5d19e8138d(repack: repack promisor objects if -a or -A is set, 2018-08-08).
Quoted 4 lines
This looks good to me, but I'll add Jonathan Tan to the CC list to double check.
Reviewed-by Taylor Blau <[email protected]>
Thanks, Taylor. Yes, the patch is correct.
Quoted 13 lines · Jonathan Tan
Quoted 13 lines · Tao Klerks via GitGitGadget
Quoted 6 lines
From: Tao Klerks <[email protected]>
The git-repack doc clearly states that it *does* operate on promisor packfiles (in a separate partition), with "-a" specified. Presumably the statements here are outdated, as they feature from the first doc in 2017 (and the repack support was added in 2018)
Yeah, this all originally comes from Jeff H.'s design document in
637fc4467e(partial-clone: design doc, 2017-12-14), but probably should have been updated in5d19e8138d(repack: repack promisor objects if -a or -A is set, 2018-08-08).
Quoted 6 lines
Quoted 4 lines
This looks good to me, but I'll add Jonathan Tan to the CC list to double check.
Reviewed-by Taylor Blau <[email protected]>Thanks, Taylor. Yes, the patch is correct.
Thanks, all of you. Will queue.