Skip to contentSkip to conversation

deb: allow custom dpkg command

PATCH Tim Blechmann 2 participants 2 messages Aug 8, 2019

lore
Share & tools
lore
#0 lore raw

trying to reduce the turnaround times for local builds, i'm trying to find a way to inject -Zgzip -z1 into the dkpg-deb command line.

attached patch introduces a DPKG_BUILDCMD variable for this purpose. (i'm not very familiar with the whole bitbake infrastructure, so i'm
wondering: do i have to add it to the vardeps of do_package_deb?)

tia,
tim

From 62d4930d307d5d07844889001e8a1c3111b72b98 Mon Sep 17 00:00:00 2001
From: Tim Blechmann <[email protected]>
Date: Thu, 8 Aug 2019 06:48:54 +0200
Subject: [PATCH] package_deb: allow dpkg-deb to be customized via
DPKG_BUILDCMD

the command line to invoke dpkg-deb is hardcoded. there are certain use cases where we want to tweak how debian packages are compiled: e.g. the default uses xz compression, which is rather CPU intensive. for local builds one might want to pass -Zgzip -z1 to favor speed over compression ratio.

we therefore introduce a DPKG_BUILDCMD variable which allows downstream code to customize how dpkg-deb is executed

---
 meta/classes/package_deb.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/classes/package_deb.bbclass +4 -1
index 6f81591653..790b26aef2 100644
@@ -6,6 +6,8 @@ inherit package
 
 IMAGE_PKGTYPE ?= "deb"
 
+DPKG_BUILDCMD ??= "dpkg-deb"
+
 DPKG_ARCH ?= "${@debian_arch_map(d.getVar('TARGET_ARCH'), d.getVar('TUNE_FEATURES'))}"
 DPKG_ARCH[vardepvalue] = "${DPKG_ARCH}"
 
@@ -269,7 +271,8 @@ def deb_write_pkg(pkg, d):
             conffiles.close()
 
         os.chdir(basedir)
-        subprocess.check_output("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir),
+        subprocess.check_output("PATH=\"%s\" %s -b %s %s" % (localdata.getVar("PATH"), localdata.getVar("DPKG_BUILDCMD"),
+                                                             root, pkgoutdir),
                                 stderr=subprocess.STDOUT,
                                 shell=True)
 
Signature · 1 line
2.18.0
#1 lore raw

The patch seems ok, but can you resend it directly (instead of sending attachments) please? Use 'git send-email'.

Alex

Quoted 15 lines · Tim Blechmann

trying to reduce the turnaround times for local builds, i'm trying to find a way to inject -Zgzip -z1 into the dkpg-deb command line.

attached patch introduces a DPKG_BUILDCMD variable for this purpose. (i'm not very familiar with the whole bitbake infrastructure, so i'm
wondering: do i have to add it to the vardeps of do_package_deb?)

tia,
tim
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core