git svn log: Use of uninitialized value $sha1_short
Running 'git svn log' in a repository that was cloned from an SVN repo results in this warning:
$ git svn log > /dev/null Use of uninitialized value $sha1_short in regexp compilation at /usr/lib64/perl5/vendor_perl/5.30.3/Git/SVN/Log.pm line 301, <$fh> line 6.
This doesn't appear to have any ill effects, but the warning might indicate a problem somewhere.
[System Info]
git version:
git version 2.29.0
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Linux 5.4.72-gentoo #1 SMP PREEMPT Sat Oct 17 18:27:41 EEST 2020 x86_64 compiler info: gnuc: 10.2
libc info: glibc: 2.31
$SHELL (typically, interactive shell): /bin/bash
[Enabled Hooks]
Quoted 9 lines · Nikos Chantziaras
Running 'git svn log' in a repository that was cloned from an SVN repo results in this warning:
$ git svn log > /dev/null Use of uninitialized value $sha1_short in regexp compilation at /usr/lib64/perl5/vendor_perl/5.30.3/Git/SVN/Log.pm line 301, <$fh> line 6.This doesn't appear to have any ill effects, but the warning might indicate a problem somewhere.
It seems to only get mentioned once and never set:
$ git grep sha1_short perl
perl/Git/SVN/Log.pm: } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) {Looks like it got renamed, and this reference was somehow missed?
$ git log -1 -Ssha1_short perl commit 9ab33150a0d14089d0496dd8354d4a969e849571 Author: brian m. carlson <[email protected]> Date: Mon Jun 22 18:04:12 2020 +0000
perl: create and switch variables for hash constants
git-svn has several variables for SHA-1 constants, including short hash values and full length hash values. Since these are no longer SHA-1 specific, let's start them with "oid" instead of "sha1". Add a constant, oid_length, which is the length of the hash algorithm in use in hex. We use the hex version because overwhelmingly that's what's used by git-svn.
[...]
-Peff
Quoted 14 lines · Jeff King
It seems to only get mentioned once and never set:
$ git grep sha1_short perl perl/Git/SVN/Log.pm: } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) {Looks like it got renamed, and this reference was somehow missed?
$ git log -1 -Ssha1_short perl commit 9ab33150a0d14089d0496dd8354d4a969e849571 Author: brian m. carlson <[email protected]> Date: Mon Jun 22 18:04:12 2020 +0000perl: create and switch variables for hash constants
Quoted 7 lines
git-svn has several variables for SHA-1 constants, including short hash values and full length hash values. Since these are no longer SHA-1 specific, let's start them with "oid" instead of "sha1". Add a constant,
oid_length, which is the length of the hash algorithm in use in hex. We use the hex version because overwhelmingly that's what's used by git-svn.
[...]
Looks that way. '$::' as opposed to plain '$' threw the replacement off the track?
perl/Git/SVN/Log.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
perl/Git/SVN/Log.pm +1 -1
@@ -298,7 +298,7 @@ sub cmd_show_log { get_author_info($c, $1, $2, $3); } elsif (/^${esc_color}(?:tree|parent|committer) /o) { # ignore - } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) { + } elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) { push @{$c->{raw}}, $_; } elsif (/^${esc_color}[ACRMDT]\t/) { # we could add $SVN->{svn_path} here, but that requires
Quoted 17 lines · Junio C Hamano
Quoted 9 lines
Looks like it got renamed, and this reference was somehow missed?
$ git log -1 -Ssha1_short perl commit 9ab33150a0d14089d0496dd8354d4a969e849571 Author: brian m. carlson <[email protected]> Date: Mon Jun 22 18:04:12 2020 +0000perl: create and switch variables for hash constants
Quoted 7 lines
git-svn has several variables for SHA-1 constants, including short hash values and full length hash values. Since these are no longer SHA-1 specific, let's start them with "oid" instead of "sha1". Add a constant,
oid_length, which is the length of the hash algorithm in use in hex. We use the hex version because overwhelmingly that's what's used by git-svn.
[...]
Quoted 2 lines
Looks that way. '$::' as opposed to plain '$' threw the replacement off the track?
That was my guess, too, but that commit does convert some other references of that form. <shrug>
Quoted 8 lines
perl/Git/SVN/Log.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)perl/Git/SVN/Log.pm +0
-0
perl/Git/SVN/Log.pm sub cmd_show_log { · line 304
Quoted 8 lines
perl/Git/SVN/Log.pm +1
-1@@ -298,7 +298,7 @@ sub cmd_show_log { get_author_info($c, $1, $2, $3); } elsif (/^${esc_color}(?:tree|parent|committer) /o) { # ignore - } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) { + } elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) { push @{$c->{raw}}, $_; } elsif (/^${esc_color}[ACRMDT]\t/) { # we could add $SVN->{svn_path} here, but that requires
Yeah, I'm almost certain this is the solution, but it was a little disturbing that no tests catch it. Besides the warning, it probably is a functional problem (I guess that regex is now overly broad since its last half is blank). But maybe it doesn't matter much. It looks like we're parsing raw diff output from git-log. Short of a really bizarre --format parameter, those are the only lines that would match /^:/ anyway.
The tests do catch it if we do:
perl/Git/SVN/Log.pm +1 -1
@@ -1,6 +1,6 @@ package Git::SVN::Log; use strict; -use warnings; +use warnings FATAL => qw(all); use Git::SVN::Utils qw(fatal); use Git qw(command command_oneline
but:
- we'd need to do that in each .pm file, as well as git-svn.perl
- I wonder if it's suitable for production use (i.e., would it become annoying when a newer version of perl issues a harmless warning; right now that's a minor inconvenience, but aborting the whole program might be a show-stopper).
It would be nice if we could crank up the severity just while running the tests, but I don't think there's an easy built-in way to do that. This seems to work:
use warnings ($ENV{GIT_PERL_STRICT} ? qw(FATAL all) : ());though I'm honestly surprised it does (because "use" is generally resolved at read/compile time. I guess perl is smart enough to run that code snippet at that point.
-Peff
Quoted 11 lines · Junio C Hamano
Looks that way. '$::' as opposed to plain '$' threw the replacement off the track?
perl/Git/SVN/Log.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)perl/Git/SVN/Log.pm +0
-0
perl/Git/SVN/Log.pm sub cmd_show_log { · line 304
Quoted 8 lines
perl/Git/SVN/Log.pm +1
-1@@ -298,7 +298,7 @@ sub cmd_show_log { get_author_info($c, $1, $2, $3); } elsif (/^${esc_color}(?:tree|parent|committer) /o) { # ignore - } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) { + } elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) { push @{$c->{raw}}, $_; } elsif (/^${esc_color}[ACRMDT]\t/) { # we could add $SVN->{svn_path} here, but that requires
Yeah, this is correct. I'll try to get a format patch written up tonight with this if nobody gets to it before me.
Signature · 2 lines
brian m. carlson (he/him or they/them) Houston, Texas, US
Quoted 23 lines · Jeff King
Yeah, I'm almost certain this is the solution, but it was a little disturbing that no tests catch it. Besides the warning, it probably is a functional problem (I guess that regex is now overly broad since its last half is blank). But maybe it doesn't matter much. It looks like we're parsing raw diff output from git-log. Short of a really bizarre --format parameter, those are the only lines that would match /^:/ anyway.
The tests do catch it if we do:
perl/Git/SVN/Log.pm +1
-1@@ -1,6 +1,6 @@ package Git::SVN::Log; use strict; -use warnings; +use warnings FATAL => qw(all); use Git::SVN::Utils qw(fatal); use Git qw(command command_oneline
Quoted 8 lines
but:
- we'd need to do that in each .pm file, as well as git-svn.perl
- I wonder if it's suitable for production use (i.e., would it become annoying when a newer version of perl issues a harmless warning; right now that's a minor inconvenience, but aborting the whole program might be a show-stopper).
No, that's not suitable for production use. Perl does add new warnings from time to time and breaking things when Perl gets upgraded will definitely not make us the friends of Linux distros. Doing this is like using -Werror: fine for your personal development needs, but not suitable for shipping to others.
We could run "perl -w" on each file and look for a single-line output with "OK"; that's what we did at a previous job. However, any change we make here needs to be conditional on DEVELOPER, because otherwise anyone who needs to build an Git with a new version of Perl will potentially have a broken testsuite.
Quoted 9 lines
It would be nice if we could crank up the severity just while running the tests, but I don't think there's an easy built-in way to do that. This seems to work:
use warnings ($ENV{GIT_PERL_STRICT} ? qw(FATAL all) : ());though I'm honestly surprised it does (because "use" is generally resolved at read/compile time. I guess perl is smart enough to run that code snippet at that point.
Yup, that would run at BEGIN time.
Signature · 2 lines
brian m. carlson (he/him or they/them) Houston, Texas, US
PATCH 1/1 svn: use correct variable name for short OID
In reply to Nikos ChantziarasThe commit 9ab33150a0 ("perl: create and switch variables for hash constants", 2020-06-22) converted each instance of the variable $sha1_short into $oid_short in the Subversion code, since git-svn now understands SHA-256. However, one conversion was missed.
As a result, Perl complains about the use of this variable:
Use of uninitialized value $sha1_short in regexp compilation at /usr/lib64/perl5/vendor_perl/5.30.3/Git/SVN/Log.pm line 301, <$fh> line 6.
Because we're parsing raw diff output here, the likelihood is very low that we'll actually misparse the data, since the only lines we're going to get starting with colons are the ones we're expecting. Even if we had a newline in a path, we'd end up with a quoted path. Our regex is just less strict than we'd like it to be.
However, it's obviously undesirable that our code is emitting Perl warnings, so let's convert it to use the proper variable name.
--- perl/Git/SVN/Log.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
perl/Git/SVN/Log.pm +1 -1
@@ -298,7 +298,7 @@ sub cmd_show_log { get_author_info($c, $1, $2, $3); } elsif (/^${esc_color}(?:tree|parent|committer) /o) { # ignore - } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) { + } elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) { push @{$c->{raw}}, $_; } elsif (/^${esc_color}[ACRMDT]\t/) { # we could add $SVN->{svn_path} here, but that requires
Quoted 10 lines · brian m. carlson
Quoted 4 lines
- I wonder if it's suitable for production use (i.e., would it become annoying when a newer version of perl issues a harmless warning; right now that's a minor inconvenience, but aborting the whole program might be a show-stopper).
No, that's not suitable for production use. Perl does add new warnings from time to time and breaking things when Perl gets upgraded will definitely not make us the friends of Linux distros. Doing this is like using -Werror: fine for your personal development needs, but not suitable for shipping to others.
OK, that matches my general sense.
Quoted 5 lines
We could run "perl -w" on each file and look for a single-line output with "OK"; that's what we did at a previous job. However, any change we make here needs to be conditional on DEVELOPER, because otherwise anyone who needs to build an Git with a new version of Perl will potentially have a broken testsuite.
Yeah, I've done something similar as well. I agree it would be potentially annoying for distros building. But unlike the -Wall/-Werror distinction, where the builder may be annoyed by extra messages but the end result is presumably OK, this _does_ affect end users. I.e., if it triggers, it also means the users of your package are going to see annoying warnings. The change I'm proposing is just whether that's fatal or not.
So it might actually be of interest to distro builders to know that the version of Git they're building is going to produce annoying warnings. And the escape hatch there is likely not to turn warnings from fatal to non-fatal, but to suppress the particular warning entirely with a patch to the code.
I dunno. I admit I don't really care enough about our perl code in general (which I consider mostly legacy; I doubt we'd introduce new perl scripts lightly). So it may not even be worth putting a lot of effort into it. But it is unfortunate that this bug _could_ have been caught automatically but wasn't.
-Peff
Re: [PATCH] svn: use correct variable name for short OID
In reply to brian m. carlsonQuoted 11 lines · brian m. carlson
The commit
9ab33150a0("perl: create and switch variables for hash constants", 2020-06-22) converted each instance of the variable $sha1_short into $oid_short in the Subversion code, since git-svn now understands SHA-256. However, one conversion was missed.As a result, Perl complains about the use of this variable:
Use of uninitialized value $sha1_short in regexp compilation at
/usr/lib64/perl5/vendor_perl/5.30.3/Git/SVN/Log.pmline 301, <$fh> line 6.
Quoted 5 lines
Because we're parsing raw diff output here, the likelihood is very low that we'll actually misparse the data, since the only lines we're going to get starting with colons are the ones we're expecting. Even if we had a newline in a path, we'd end up with a quoted path. Our regex is just less strict than we'd like it to be.
I agree this is unlikely to matter much in the happy path, but I wondered how confused things could get. I'd never looked at this code before, but it looks like we take git-log @args from the user. So:
git svn log --format=":123456 123456 foo"
gets mis-parsed. But not only is that exceedingly unlikely in the first place, AFAICT the command was never meant to allow arbitrary formats anyway. It's expecting its own "--pretty=raw" to be respected, so the command above is broken even with your fix.
None of that changes the fix, which is obviously correct, but I wondered if we ought to have better test coverage here. And I've convinced myself the answer is "no"; there's no reasonable-to-test functional impact of this bug or its fix (aside from generating the warning, but it would be silly to write a test for this one warning; if we do anything it should be to complain about any warnings during the test run).
-Peff
Re: [PATCH] svn: use correct variable name for short OID
Quoted 6 lines · Jeff King
None of that changes the fix, which is obviously correct, but I wondered if we ought to have better test coverage here. And I've convinced myself the answer is "no"; there's no reasonable-to-test functional impact of this bug or its fix (aside from generating the warning, but it would be silly to write a test for this one warning; if we do anything it should be to complain about any warnings during the test run).
We talked about it enough that I was curious how bad the patch would look. So here it is. It does catch the problem in DEVELOPER=1 mode, but not otherwise.
The fact that we have to touch every perl file is a bit ugly. So I dunno. Maybe worth it, or maybe too nasty.
-- >8 --
Subject: [PATCH] perl: check for perl warnings while running tests
We set "use warnings" in most of our perl code to catch problems. But as the name implies, warnings just emit a message to stderr and don't otherwise affect the program. So our tests are quite likely to miss that warnings are being spewed, as most of them do not look at stderr.
We could ask perl to make all warnings fatal, but this is likely annoying for non-developers, who would rather have a running program with a warning than something that refuses to work at all.
So instead, let's teach the perl code to respect an environment variable (GIT_PERL_FATAL_WARNINGS) to increase the severity of the warnings. This can be set for day-to-day running if people want to be really pedantic, but the primary use is to trigger it within the test suite.
We could also trigger that for every test run, but likewise even the tests failing may be annoying to distro builders, etc (just as -Werror would be for compiling C code). So we'll tie it to a special test-mode variable (GIT_TEST_PERL_FATAL_WARNINGS) that can be set in the environment or as a Makefile knob, and we'll automatically turn the knob when DEVELOPER=1 is set. That should give developers and CI the more careful view without disrupting normal users or packagers.
Note that the mapping from the GIT_TEST_* form to the GIT_* form in test-lib.sh is necessary even if they had the same name: the perl scripts need it to be normalized to a perl truth value, and we also have to make sure it's exported (we might have gotten it from the environment, but we might also have gotten it from GIT-BUILD-OPTIONS directly).
--- Makefile | 3 +++ config.mak.dev | 2 ++ git-svn.perl | 2 +- perl/FromCPAN/Error.pm | 2 +- perl/Git.pm | 2 +- perl/Git/I18N.pm | 2 +- perl/Git/IndexInfo.pm | 2 +- perl/Git/LoadCPAN.pm | 2 +- perl/Git/LoadCPAN/Error.pm | 2 +- perl/Git/LoadCPAN/Mail/Address.pm | 2 +- perl/Git/Packet.pm | 2 +- perl/Git/SVN.pm | 2 +- perl/Git/SVN/Editor.pm | 2 +- perl/Git/SVN/Fetcher.pm | 2 +- perl/Git/SVN/GlobSpec.pm | 2 +- perl/Git/SVN/Log.pm | 2 +- perl/Git/SVN/Memoize/YAML.pm | 2 +- perl/Git/SVN/Migration.pm | 2 +- perl/Git/SVN/Prompt.pm | 2 +- perl/Git/SVN/Ra.pm | 2 +- perl/Git/SVN/Utils.pm | 2 +- t/test-lib.sh | 6 ++++++ 22 files changed, 30 insertions(+), 19 deletions(-)
Makefile +3 -0
@@ -2767,6 +2767,9 @@ ifdef GIT_INTEROP_MAKE_OPTS endif ifdef GIT_TEST_INDEX_VERSION @echo GIT_TEST_INDEX_VERSION=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_INDEX_VERSION)))'\' >>$@+ +endif +ifdef GIT_TEST_PERL_FATAL_WARNINGS + @echo GIT_TEST_PERL_FATAL_WARNINGS=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_PERL_FATAL_WARNINGS)))'\' >>$@+ endif @if cmp $@+ $@ >/dev/null 2>&1; then $(RM) $@+; else mv $@+ $@; fi
config.mak.dev +2 -0
@@ -45,3 +45,5 @@ ifeq ($(filter gcc5,$(COMPILER_FEATURES)),) DEVELOPER_CFLAGS += -Wno-uninitialized endif endif + +GIT_TEST_PERL_FATAL_WARNINGS = YesPlease
git-svn.perl +1 -1
@@ -2,7 +2,7 @@ # Copyright (C) 2006, Eric Wong <[email protected]> # License: GPL v2 or later use 5.008; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use strict; use vars qw/ $AUTHOR $VERSION $oid $oid_short $oid_length
perl/FromCPAN/Error.pm +1 -1
@@ -12,7 +12,7 @@ package Error; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use vars qw($VERSION); use 5.004;
perl/Git.pm +1 -1
@@ -9,7 +9,7 @@ package Git; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use File::Temp (); use File::Spec ();
perl/Git/I18N.pm +1 -1
@@ -1,7 +1,7 @@ package Git::I18N; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); BEGIN { require Exporter; if ($] < 5.008003) {
perl/Git/IndexInfo.pm +1 -1
@@ -1,6 +1,6 @@ package Git::IndexInfo; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Git qw/command_input_pipe command_close_pipe/; sub new {
perl/Git/LoadCPAN.pm +1 -1
@@ -1,7 +1,7 @@ package Git::LoadCPAN; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); =head1 NAME
perl/Git/LoadCPAN/Error.pm +1 -1
@@ -1,7 +1,7 @@ package Git::LoadCPAN::Error; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Git::LoadCPAN ( module => 'Error', import => 1,
perl/Git/LoadCPAN/Mail/Address.pm +1 -1
@@ -1,7 +1,7 @@ package Git::LoadCPAN::Mail::Address; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Git::LoadCPAN ( module => 'Mail::Address', import => 0,
perl/Git/Packet.pm +1 -1
@@ -1,7 +1,7 @@ package Git::Packet; use 5.008; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); BEGIN { require Exporter; if ($] < 5.008003) {
perl/Git/SVN.pm +1 -1
@@ -1,6 +1,6 @@ package Git::SVN; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Fcntl qw/:DEFAULT :seek/; use constant rev_map_fmt => 'NH*'; use vars qw/$_no_metadata
perl/Git/SVN/Editor.pm +1 -1
@@ -1,7 +1,7 @@ package Git::SVN::Editor; use vars qw/@ISA $_rmdir $_cp_similarity $_find_copies_harder $_rename_limit/; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use SVN::Core; use SVN::Delta; use Carp qw/croak/;
perl/Git/SVN/Fetcher.pm +1 -1
@@ -3,7 +3,7 @@ package Git::SVN::Fetcher; $_placeholder_filename @deleted_gpath %added_placeholder $repo_id/; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use SVN::Delta; use Carp qw/croak/; use File::Basename qw/dirname/;
perl/Git/SVN/GlobSpec.pm +1 -1
@@ -1,6 +1,6 @@ package Git::SVN::GlobSpec; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); sub new { my ($class, $glob, $pattern_ok) = @_;
perl/Git/SVN/Log.pm +1 -1
@@ -1,6 +1,6 @@ package Git::SVN::Log; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Git::SVN::Utils qw(fatal); use Git qw(command command_oneline
perl/Git/SVN/Memoize/YAML.pm +1 -1
@@ -1,5 +1,5 @@ package Git::SVN::Memoize::YAML; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use strict; use YAML::Any ();
perl/Git/SVN/Migration.pm +1 -1
@@ -33,7 +33,7 @@ package Git::SVN::Migration; # possible if noMetadata or useSvmProps are set; but should # be no problem for users that use the (sensible) defaults. use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Carp qw/croak/; use File::Path qw/mkpath/; use File::Basename qw/dirname basename/;
perl/Git/SVN/Prompt.pm +1 -1
@@ -1,6 +1,6 @@ package Git::SVN::Prompt; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); require SVN::Core; use vars qw/$_no_auth_cache $_username/;
perl/Git/SVN/Ra.pm +1 -1
@@ -1,7 +1,7 @@ package Git::SVN::Ra; use vars qw/@ISA $config_dir $_ignore_refs_regex $_log_window_size/; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use Memoize; use Git::SVN::Utils qw( canonicalize_url
perl/Git/SVN/Utils.pm +1 -1
@@ -1,7 +1,7 @@ package Git::SVN::Utils; use strict; -use warnings; +use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : (); use SVN::Core;
t/test-lib.sh +6 -0
@@ -499,6 +499,12 @@ then export GIT_INDEX_VERSION fi +if test -n "$GIT_TEST_PERL_FATAL_WARNINGS" +then + GIT_PERL_FATAL_WARNINGS=1 + export GIT_PERL_FATAL_WARNINGS +fi + # Add libc MALLOC and MALLOC_PERTURB test # only if we are not executing the test with valgrind if test -n "$valgrind" ||
Signature · 1 line
2.29.0.579.g559558a5ea
Re: [PATCH] svn: use correct variable name for short OID
Quoted 2 lines · Jeff King
The fact that we have to touch every perl file is a bit ugly. So I dunno. Maybe worth it, or maybe too nasty.
Just a single pragma per file? That does not sound too bad at least to me.
Thanks, queued.
Quoted 6 lines
Note that the mapping from the GIT_TEST_* form to the GIT_* form in
test-lib.shis necessary even if they had the same name: the perl scripts need it to be normalized to a perl truth value, and we also have to make sure it's exported (we might have gotten it from the environment, but we might also have gotten it from GIT-BUILD-OPTIONS directly).
And GIT_PERL_FATAL_WARNINGS is cleared together with the other GIT_* options upfront, so here we only need to worry about setting and exporting it. Makes sense.
Quoted 17 lines
t/test-lib.sh +6
-0@@ -499,6 +499,12 @@ then export GIT_INDEX_VERSION fi +if test -n "$GIT_TEST_PERL_FATAL_WARNINGS" +then + GIT_PERL_FATAL_WARNINGS=1 + export GIT_PERL_FATAL_WARNINGS +fi + # Add libc MALLOC and MALLOC_PERTURB test # only if we are not executing the test with valgrind if test -n "$valgrind" ||