Skip to contentSkip to conversation

i386 entry.S problems

DISCUSSION Jan Beulich 1 participant 1 message Sep 27, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines
Quoted 1 line
Quoted 1 line

Andi Kleen <[email protected]> 27.09.04 12:58:57 >>>

Quoted 2 lines · Jan Beulich

I don't think so. Otherwise, why would arch/i386/Makefile

specifically

Quoted 6 lines
Quoted 1 line

deal with this situation?

It shouldn't be enabled for 2.95, there are known miscompilations caused by it there. The i386 Makefile enforces this:

cflags-$(CONFIG_REGPARM) += $(shell if [ $(GCC_VERSION) -ge 0300

] ; then echo "-mregparm=3"; fi ;)

But that is exactly what I'm trying to account for: As we appear to all agree, with CONFIG_REGPARM but too old a gcc (which is unknown at configuration time and thus the user can't be prevented from turning this option on), mismatches between assembly and C would result. Thus the need for checking the gcc version in (some) assembly files (of course this implies that for preprocessing assembly files one would not try to use a different gcc than that used for compiling the C stuff).

I do, however, believe that it is an inherent weakness of gcc that it doesn't decorate names of functions employing non-standard parameter passing schemes in some way (i.e. similar to the __stdcall decoration on Windows); with such functionality, it'd be much easier and safer to use mixed schemes.

Quoted 6 lines

However this points to a bug in that when someone sets this on 2.95 the assembly functions who check for CONFIG_REGPARM explicitely will be subtly miscompiled. Perhaps having a #error for this case would be better, although that would break allyesconfig on prehistoric compilers. Maybe it needs to be special cased in autoconf.h

Jan