Skip to contentSkip to conversation

uml: extend cmd line limits

PATCH Blaisorblade 1 participant 1 message Mar 24, 2005 1 message not in the archive User-mode Linux (UML)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines · Anthony Brock

Blaisor,

Perhaps the error message should be changed from:

"add_arg: Too much command line!\n"

to something like:

"add_arg: Too many command line arguments!\n"

Does this explain the error more clearly? Or am I mistaken?

Yes, I was copying it and didn't notice the message didn't make sense.

Here is the patch, it's queued and will be sent shortly.

Signature · 3 lines
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

From: Paolo 'Blaisorblade' Giarrusso <[email protected]>, "Anthony Brock" <[email protected]>

Replace the message with a more meaningful one. Noted by Anthony Brock.

---

 linux-2.6.11-paolo/arch/um/kernel/um_arch.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/um/kernel/um_arch.c renamed from arch/um/kernel/um_arch.c~uml-correct-message +1 -1
diff -puN arch/um/kernel/um_arch.c~uml-correct-message arch/um/kernel/um_arch.c
@@ -47,7 +47,7 @@ char command_line[COMMAND_LINE_SIZE] = {
 void add_arg(char *arg)
 {
 	if (strlen(command_line) + strlen(arg) + 1 > COMMAND_LINE_SIZE) {
-		printf("add_arg: Too much command line!\n");
+		printf("add_arg: Too many command line arguments!\n");
 		exit(1);
 	}
 	if(strlen(command_line) > 0)

_