Fix "value computed not used" warnings
Subsystems (3)
PATCH 1/1 Fix "value computed not used" warnings
Fixes for annoying gcc-4.1 compile warnings "value computed not used". Simply cast to void.
Signed-off-by Takashi Iwai <[email protected]>
--- drivers/block/paride/comm.c | 16 ++++++++-------- drivers/block/paride/on26.c | 2 +- drivers/net/8139too.c | 2 +- kernel/kexec.c | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-)
drivers/block/paride/comm.c +8 -8
@@ -60,7 +60,7 @@ static int comm_read_regr( PIA *pi, intcase 2 :case 3 : -case 4 :w3 (r+0x20 );r1 (); +case 4 :w3 (r+0x20 ); (void )r1 ();w2 (0x24 ); h =r4 ();w2 (4 );return h;
@@ -82,7 +82,7 @@ static void comm_write_regr( PIA *pi, incase 2 :case 3 : -case 4 :w3 (r);r1 ();w4 (val); +case 4 :w3 (r); (void )r1 ();w4 (val);break ; } }
@@ -126,17 +126,17 @@ static void comm_read_block( PIA *pi, chw2 (4 );break ; -case 2 :w3 (0x68 );r1 ();w2 (0x24 ); +case 2 :w3 (0x68 ); (void )r1 ();w2 (0x24 );for (i=0 ;i<count;i++) buf[i] =r4 ();w2 (4 );break ; -case 3 :w3 (0x68 );r1 ();w2 (0x24 ); +case 3 :w3 (0x68 ); (void )r1 ();w2 (0x24 );for (i=0 ;i<count/2 ;i++) ((u16 *)buf)[i] =r4w ();w2 (4 );break ; -case 4 :w3 (0x68 );r1 ();w2 (0x24 ); +case 4 :w3 (0x68 ); (void )r1 ();w2 (0x24 );for (i=0 ;i<count/4 ;i++) ((u32 *)buf)[i] =r4l ();w2 (4 );break ;
@@ -160,15 +160,15 @@ static void comm_write_block( PIA *pi, cw2 (5 );w2 (4 );break ; -case 2 :w3 (0x48 );r1 (); +case 2 :w3 (0x48 ); (void )r1 ();for (k=0 ;k<count;k++)w4 (buf[k^1 ]);break ; -case 3 :w3 (0x48 );r1 (); +case 3 :w3 (0x48 ); (void )r1 ();for (k=0 ;k<count/2 ;k++)w4w (pi_swab16 (buf,k));break ; -case 4 :w3 (0x48 );r1 (); +case 4 :w3 (0x48 ); (void )r1 ();for (k=0 ;k<count/4 ;k++)w4l (pi_swab32 (buf,k));break ;
drivers/block/paride/on26.c +1 -1
@@ -66,7 +66,7 @@ static int on26_read_regr( PIA *pi, intcase 3 :case 4 :w3 (1 );w3 (1 );w2 (5 );w4 (r);w2 (4 );w3 (0 );w3 (0 );w2 (0x24 ); a =r4 ();w2 (4 ); -w2 (0x24 );r4 ();w2 (4 ); +w2 (0x24 ); (void )r4 ();w2 (4 );return a; }
drivers/net/8139too.c +1 -1
@@ -1131,7 +1131,7 @@ static void __devexit rtl8139_remove_oneNo extra delay is needed with 33Mhz PCI, but 66Mhz may change this. */ -#define eeprom_delay () RTL_R32(Cfg9346) +#define eeprom_delay () (void) RTL_R32(Cfg9346)/* The EEPROM commands include the alway-set leading bit. */ #define EE_WRITE_CMD (5)
kernel/kexec.c +2 -2
@@ -995,7 +995,7 @@ asmlinkage long sys_kexec_load(unsigned image =xchg (dest_image, image); out: -xchg (&kexec_lock,0 );/* Release the mutex */ + (void )xchg (&kexec_lock,0 );/* Release the mutex */ kimage_free (image);return result;
@@ -1063,7 +1063,7 @@ void crash_kexec(struct pt_regs *regs)machine_crash_shutdown (&fixed_regs);machine_kexec (image); } -xchg (&kexec_lock,0 ); + (void )xchg (&kexec_lock,0 ); } }
Quoted 4 lines
Fixes for annoying gcc-4.1 compile warnings "value computed not used". Simply cast to void.
Iiih, casts.
The thing is defined as
#define r1() (in_p(1) & 0xff)
so what do we call it for - does inb do more than just reading, like resetting the ioport to 0?
Jan Engelhardt