MODULE_ALIAS patch for ALSA

DISCUSSION Rusty Russell 2 participants 2 messages Oct 31, 2003 1 message not in the archive VFS

lore

Share & tools

lore

Rusty Russell

author

2003-10-31 03:43 UTC #1 lore raw

In reply to a message not in the archive

In message <[email protected]> you write:

Quoted 1 line

Hi Rusty,

Hi Takashi!

Quoted 4 lines

while i've played with it, i found that the alias "char-major-14-*" and "char-major-116-*" don't work. "char-major-14" and "char-major-116" do work well. is it a known issue?
the module-init-tools is 0.9.14-pre2, BTW.

Yep, there's one odd one out. Thanks.

Linus, please apply.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Name: request_module char devices fix
Author: Rusty Russell
Status: Trivial

D: Module aliases are all of form "char-major-<major>-<minor>". char_dev.c
D: calls request_module with "char-major-<major>".

fs/char_dev.c +1 -1

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .30462-linux-2.6.0-test9-bk4/fs/char_dev.c .30462-linux-2.6.0-test9-bk4.updated/fs/char_dev.c
@@ -434,7 +434,7 @@ void cdev_init(struct cdev *cdev, struct
 
 static struct kobject *base_probe(dev_t dev, int *part, void *data)
 {
-	request_module("char-major-%d", MAJOR(dev));
+	request_module("char-major-%d-%d", MAJOR(dev), MINOR(dev));
 	return NULL;
 }

Takashi Iwai

2003-10-31 10:57 UTC #2 lore raw

At Fri, 31 Oct 2003 13:21:26 +1100,

Quoted 4 lines · Rusty Russell

In message <[email protected]> you write:
Quoted 1 line
Hi Rusty,

Quoted 8 lines

Hi Takashi!
Quoted 4 lines
while i've played with it, i found that the alias "char-major-14-*" and "char-major-116-*" don't work. "char-major-14" and "char-major-116" do work well. is it a known issue?
the module-init-tools is 0.9.14-pre2, BTW.
Yep, there's one odd one out. Thanks.

Ok, thanks, I'll revert to MODULE_ALIAS_CHAR_MAJORDEV again. I hope Jaroslav will submit the changeset soon...

ciao,
--
Takashi Iwai <[email protected]> ALSA Developer - www.alsa-project.org