Skip to contentSkip to conversation

usermodehelper lock error at resume

DISCUSSION Rafael J. Wysocki 2 participants 2 messages Apr 29, 2014 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): s5h8ur3ujmy.wl%[email protected]

A message that is not in the archive (sent off-list or not yet received): s5hwqe888wv.wl%[email protected]

#2 lore raw
Quoted 7 lines · Takashi Iwai

At Fri, 18 Apr 2014 10:28:05 +0200,

Quoted 2 lines · Takashi Iwai

[my previous post didn't seem to go out by some reason, so I just
resend this; please disregard if you already received it.]

Hmm, I still can't see this in LKML archives...
Did you guys receive my previous post below?

I did, sorry for not responding, I'm buried under stuff at the moment.

Rafael

Quoted 47 lines
Quoted 47 lines

Hi,

we've received a bug report with 3.14.x kernel regarding the firmware loading of intel BT device at suspend/resume:

   https://bugzilla.novell.com/show_bug.cgi?id=873790

It's a WARN_ON() that was recently introduced. And, it turned out that the problem basically comes from a small window between the process resume and the clear of usermodehelper lock.

The request_firmware() function checks the UMH lock and gives up when it's in DISABLE state. This is for avoiding the invalid f/w loading during suspend/resume phase. The problem is that usermodehelper_enable() is called at the end of thaw_processes(). Thus, a thawed process in between can kick off the f/w loader code path (in this case, via btusb_setup_intel()) even before the call of usermodehelper_enable(). Then usermodehelper_read_trylock() returns an error and request_firmware() spews WARN_ON() in the end.

The oneliner patch below seems fixing the problem. But, I'm not quite sure whether it's the best; rather usermodehelper_enable() can be moved there, or better to define yet another state, e.g. UMH_THAWING, instead of reusing UMH_FREEZING?

Suggestions?

Once when we agree, I'll cook up a proper patch.

thanks,

Takashi

---

kernel/power/process.c +2 -0
index 06ec8869dbf1..9c7552f092f2 100644
@@ -181,6 +181,8 @@ void thaw_processes(void)
  	pm_nosig_freezing = false;
 
  	oom_killer_enable();
+	/* allow request_firmare() at this point */
+	__usermodehelper_set_disable_depth(UMH_FREEZING);
 
  	printk("Restarting tasks ... ");
 
#3 lore raw

At Tue, 29 Apr 2014 17:34:32 +0200,

Quoted 11 lines · Rafael J. Wysocki
Quoted 7 lines · Takashi Iwai

At Fri, 18 Apr 2014 10:28:05 +0200,

Quoted 2 lines · Takashi Iwai

[my previous post didn't seem to go out by some reason, so I just
resend this; please disregard if you already received it.]

Hmm, I still can't see this in LKML archives...
Did you guys receive my previous post below?

I did, sorry for not responding, I'm buried under stuff at the moment.

Don't worry, this isn't any urgent issue. (And I've been off in the whole last week in anyway :)

I just wondered why this didn't come up in LKML archive. But if the post went out actually, it's fine.

thanks,

Takashi

Quoted 52 lines

Rafael

Quoted 47 lines
Quoted 47 lines

Hi,

we've received a bug report with 3.14.x kernel regarding the firmware loading of intel BT device at suspend/resume:

   https://bugzilla.novell.com/show_bug.cgi?id=873790

It's a WARN_ON() that was recently introduced. And, it turned out that the problem basically comes from a small window between the process resume and the clear of usermodehelper lock.

The request_firmware() function checks the UMH lock and gives up when it's in DISABLE state. This is for avoiding the invalid f/w loading during suspend/resume phase. The problem is that usermodehelper_enable() is called at the end of thaw_processes(). Thus, a thawed process in between can kick off the f/w loader code path (in this case, via btusb_setup_intel()) even before the call of usermodehelper_enable(). Then usermodehelper_read_trylock() returns an error and request_firmware() spews WARN_ON() in the end.

The oneliner patch below seems fixing the problem. But, I'm not quite sure whether it's the best; rather usermodehelper_enable() can be moved there, or better to define yet another state, e.g. UMH_THAWING, instead of reusing UMH_FREEZING?

Suggestions?

Once when we agree, I'll cook up a proper patch.

thanks,

Takashi

---

kernel/power/process.c +2 -0
index 06ec8869dbf1..9c7552f092f2 100644
@@ -181,6 +181,8 @@ void thaw_processes(void)
  	pm_nosig_freezing = false;
 
  	oom_killer_enable();
+	/* allow request_firmare() at this point */
+	__usermodehelper_set_disable_depth(UMH_FREEZING);
 
  	printk("Restarting tasks ... ");