Missing IRQ via amd_gpio

REGRESSION Takashi Iwai 2 participants 4 messages Apr 22, 2022

Subsystems (2)

GPIO Regressions

lore

Share & tools

lore

Takashi Iwai

author

2022-04-22 13:03 UTC #0 lore raw

Hi,

we received a bug report for 5.17.3 kernel showing a new error:

amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517

Not only an error message but in practice this leads to a missing IRQ assignment; the IRQ 27 is no longer assigned to amd_gpio driver.

As the error number (EPROBE_DEFER) indicates, this seems to be the side-effect of the recent fix, the upstream commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization"). As far as I understand, the problem is in acpi_gpiochip_request_interrupts() call that is called from gpiochip_add_irqchip() itself. Since it's called before the initialized flag set, it always fails now.

Below is a temporary quick fix and it seems working. But I'm not sure whether I overlooked something obvious...

thanks,

Takashi

-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH] gpio: Fix missing IRQ assginment for ACPI gpiochip

The recent fix for gpiolib caused an error like:
amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
It indicates -EPROBE_DEFER, and since the function acpi_gpiochip_request_interrupts() doesn't handle the deferred probe, this leads to the missing IRQs.

The problem is that acpi_gpiochip_request_interrupts() itself is called from gpiochip_add_irqchip() but before gc->irq.initialized flag is set. For fixing the regression, let's move the call of acpi_gpiochip_request_interrupts() after the initialized flag setup.

Fixes 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization")

BugLink https://bugzilla.suse.com/show_bug.cgi?id=1198697

Signed-off-by Takashi Iwai <[email protected]>

---
 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpio/gpiolib.c +2 -2

index 085348e08986..b7694171655c 100644
@@ -1601,8 +1601,6 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
 
 	gpiochip_set_irq_hooks(gc);
 
-	acpi_gpiochip_request_interrupts(gc);
-
 	/*
 	 * Using barrier() here to prevent compiler from reordering
 	 * gc->irq.initialized before initialization of above

@@ -1612,6 +1610,8 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
 
 	gc->irq.initialized = true;
 
+	acpi_gpiochip_request_interrupts(gc);
+
 	return 0;
 }

Signature · 1 line

2.31.1

Thorsten Leemhuis

2022-04-22 14:17 UTC #1 lore raw

Hi Takashi! Thx for CCing the regression list.

Quoted 17 lines · Takashi Iwai

Hi,
we received a bug report for 5.17.3 kernel showing a new error:
amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
Not only an error message but in practice this leads to a missing IRQ assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
As the error number (EPROBE_DEFER) indicates, this seems to be the side-effect of the recent fix, the upstream commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization"). As far as I understand, the problem is in acpi_gpiochip_request_interrupts() call that is called from gpiochip_add_irqchip() itself. Since it's called before the initialized flag set, it always fails now.

Quoted 2 lines

Below is a temporary quick fix and it seems working. But I'm not sure whether I overlooked something obvious...

A patch that afaics will fix this hopefully should get merged really soon now:

https://lore.kernel.org/all/[email protected]/

Thorsten Leemhuis

2022-04-22 14:29 UTC #2 lore raw

Quoted 23 lines · Thorsten Leemhuis

Hi Takashi! Thx for CCing the regression list.
Quoted 17 lines · Takashi Iwai
Hi,
we received a bug report for 5.17.3 kernel showing a new error:
amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
Not only an error message but in practice this leads to a missing IRQ assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
As the error number (EPROBE_DEFER) indicates, this seems to be the side-effect of the recent fix, the upstream commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization"). As far as I understand, the problem is in acpi_gpiochip_request_interrupts() call that is called from gpiochip_add_irqchip() itself. Since it's called before the initialized flag set, it always fails now.
Quoted 2 lines
Below is a temporary quick fix and it seems working. But I'm not sure whether I overlooked something obvious...

Quoted 8 lines

A patch that afaics will fix this hopefully should get merged really soon now:
https://lore.kernel.org/all/[email protected]/
See also v1:
https://lore.kernel.org/all/[email protected]/

Sorry, I shouldn't have stripped the rest of the message, mario might be interested in at least the link, so here it is:

Quoted 43 lines

Quoted 43 lines
-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH] gpio: Fix missing IRQ assginment for ACPI gpiochip
The recent fix for gpiolib caused an error like:
amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
It indicates -EPROBE_DEFER, and since the function acpi_gpiochip_request_interrupts() doesn't handle the deferred probe, this leads to the missing IRQs.
The problem is that acpi_gpiochip_request_interrupts() itself is called from gpiochip_add_irqchip() but before gc->irq.initialized flag is set. For fixing the regression, let's move the call of acpi_gpiochip_request_interrupts() after the initialized flag setup.
Fixes 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization")
BugLink https://bugzilla.suse.com/show_bug.cgi?id=1198697
Signed-off-by Takashi Iwai <[email protected]>
---
 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpiolib.c +2 -2
index 085348e08986..b7694171655c 100644
@@ -1601,8 +1601,6 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
 
 	gpiochip_set_irq_hooks(gc);
 
-	acpi_gpiochip_request_interrupts(gc);
-
 	/*
 	 * Using barrier() here to prevent compiler from reordering
 	 * gc->irq.initialized before initialization of above
@@ -1612,6 +1610,8 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
 
 	gc->irq.initialized = true;
 
+	acpi_gpiochip_request_interrupts(gc);
+
 	return 0;
 }

Takashi Iwai

author Reviewed-by Tested-by

2022-04-22 14:33 UTC #3 lore raw

In reply to Thorsten Leemhuis

Quoted 24 lines · Thorsten Leemhuis

Hi Takashi! Thx for CCing the regression list.
Quoted 17 lines · Takashi Iwai
Hi,
we received a bug report for 5.17.3 kernel showing a new error:
amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
Not only an error message but in practice this leads to a missing IRQ assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
As the error number (EPROBE_DEFER) indicates, this seems to be the side-effect of the recent fix, the upstream commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization"). As far as I understand, the problem is in acpi_gpiochip_request_interrupts() call that is called from gpiochip_add_irqchip() itself. Since it's called before the initialized flag set, it always fails now.
Quoted 2 lines
Below is a temporary quick fix and it seems working. But I'm not sure whether I overlooked something obvious...

Quoted 8 lines

A patch that afaics will fix this hopefully should get merged really soon now:
https://lore.kernel.org/all/[email protected]/
See also v1:
https://lore.kernel.org/all/[email protected]/

Thanks, good to know that we reached to the very same fix :)

So, feel free to take my tags to Mario's patch, if any:

Reviewed-by Takashi Iwai <[email protected]>

Tested-by Takashi Iwai <[email protected]>

Takashi