Skip to contentSkip to conversation

Replace wrong structure type in mmc_ioctl() in cdrom.c

PATCH Jens Axboe 1 participant 1 message Nov 30, 2000 1 message not in the archive

lore
Share & tools
lore

Jens Axboe

author
#1 lore raw
In reply to a message not in the archive
Quoted 5 lines · Richard Pries

Jens,

Please consider the following patch for the wrong type of structure in mmc_ioctl() in cdrom.c.

Quoted 8 lines

Currently, mmc_ioctl() in cdrom.c is passed a cdrom_msf structure when ioctl() is called with CDROMREADRAW, CDROMREADMODE1, or CDROMREADMODE2 as its second argument. This structure does not provide the required buffer for reading the data, and it does not correspond to the structure that cdrom.h says to use with these ioctl() calls. This patch replaces the cdrom_msf structure with a cdrom_read structure (as specified in cdrom.h). Preliminary tests indicate that this patch works for both IDE and SCSI drives.

Sure I bet it works, but you just broke all the programs that currently use any of the above ioctls. I've known about this for years... You can do all that you want with cdrom_msf, it's just more hassle. For 2.5 I'll introduce newer variants of the above ioctls and keep them as-is for compatability, tossing them out is not an option.

I will take a patch that corrects the comment though!

Signature · 6 lines
* Jens Axboe <[email protected]>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/