Add Spreadtrum SoC bindings and serial driver support

Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform.
This driver also support earlycon.

drivers/tty/serial/sprd_serial.c new file +34 -0

+
+	return ret;
+}
+
+static int sprd_remove(struct platform_device *dev)
+{
+	struct sprd_uart_port *sup = platform_get_drvdata(dev);
+
+	if (sup) {
+		uart_remove_one_port(&sprd_uart_driver, &sup->port);
+		sprd_port[sup->port.line] = NULL;
+		sprd_ports_num--;
+	}
+
+	if (!sprd_ports_num)
+		uart_unregister_driver(&sprd_uart_driver);
+
+	return 0;
+}
+
+static int sprd_probe(struct platform_device *pdev)
+{
+	struct resource *res;
+	struct uart_port *up;
+	struct clk *clk;
+	int irq;
+	int index;
+	int ret;
+
+	for (index = 0; index < ARRAY_SIZE(sprd_port); index++)
+		if (sprd_port[index] == NULL)
+			break;
+
+	if (index == ARRAY_SIZE(sprd_port))

drivers/tty/serial/sprd_serial.c new file +51 -0

+
+	up = &sprd_port[index]->port;
+	up->dev = &pdev->dev;
+	up->line = index;
+	up->type = PORT_SPRD;
+	up->iotype = SERIAL_IO_PORT;
+	up->uartclk = SPRD_DEF_RATE;
+	up->fifosize = SPRD_FIFO_SIZE;
+	up->ops = &serial_sprd_ops;
+	up->flags = UPF_BOOT_AUTOCONF;
+
+	clk = devm_clk_get(&pdev->dev, NULL);
+	if (!IS_ERR(clk))
+		up->uartclk = clk_get_rate(clk);
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res) {
+		dev_err(&pdev->dev, "not provide mem resource\n");
+		return -ENODEV;
+	}
+	up->mapbase = res->start;
+	up->membase = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(up->membase))
+		return PTR_ERR(up->membase);
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
+		dev_err(&pdev->dev, "not provide irq resource\n");
+		return -ENODEV;
+	}
+	up->irq = irq;
+
+	if (!sprd_ports_num) {
+		ret = uart_register_driver(&sprd_uart_driver);
+		if (ret < 0) {
+			pr_err("Failed to register SPRD-UART driver\n");
+			return ret;
+		}
+	}
+	sprd_ports_num++;
+
+	ret = uart_add_one_port(&sprd_uart_driver, up);
+	if (ret) {
+		sprd_port[index] = NULL;
+		sprd_remove(pdev);
+	}
+
+	platform_set_drvdata(pdev, up);
+
+	return ret;
+}

Hi Chunyan,

Minor but important fixes below.

And for the v9 version, please only use "To:" for
"Greg Kroah-Hartman <[email protected]>"

All other recipients should only be Cc:

Regards,
Peter Hurley

Quoted 3 lines · Chunyan Zhang

Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform.
This driver also support earlycon.

[...]

drivers/tty/serial/sprd_serial.c line 642

Quoted 5 lines

drivers/tty/serial/sprd_serial.c new file +5 -0

+static int sprd_probe_dt_alias(int index, struct device *dev)
+{
+     struct device_node *np;
+     static bool seen_dev_with_alias;
+     static bool seen_dev_without_alias;

        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

delete these two lines; these were used for the message deleted in a previous patch version.

drivers/tty/serial/sprd_serial.c line 654

Quoted 12 lines

drivers/tty/serial/sprd_serial.c new file +12 -0

+     int ret = index;
+
+     if (!IS_ENABLED(CONFIG_OF))
+             return ret;
+
+     np = dev->of_node;
+     if (!np)
+             return ret;
+
+     ret = of_alias_get_id(np, "serial");
+     if (IS_ERR_VALUE(ret)) {
+             seen_dev_without_alias = true;

                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

delete this line.

drivers/tty/serial/sprd_serial.c line 657

Quoted 3 lines

drivers/tty/serial/sprd_serial.c new file +3 -0

+             ret = index;
+     } else {
+             seen_dev_with_alias = true;

                ^^^^^^^^^^^^^^^^^^^^^^^^^^^

delete this line.

drivers/tty/serial/sprd_serial.c line 662

Quoted 5 lines

drivers/tty/serial/sprd_serial.c new file +5 -0

+             if (ret >= ARRAY_SIZE(sprd_port) || sprd_port[ret] != NULL) {
+                     dev_warn(dev, "requested serial port %d  not available.\n", ret);
+                     ret = index;
+             }
+     }

Simplify the entire "if (IS_ERR_VALUE(ret))" statement to:

        if (IS_ERR_VALUE(ret))
                ret = index;
        else if (ret >= ..................) {
                dev_warn(.....);
                ret = index;
        }

Quoted 34 lines

drivers/tty/serial/sprd_serial.c new file +34 -0

+
+     return ret;
+}
+
+static int sprd_remove(struct platform_device *dev)
+{
+     struct sprd_uart_port *sup = platform_get_drvdata(dev);
+
+     if (sup) {
+             uart_remove_one_port(&sprd_uart_driver, &sup->port);
+             sprd_port[sup->port.line] = NULL;
+             sprd_ports_num--;
+     }
+
+     if (!sprd_ports_num)
+             uart_unregister_driver(&sprd_uart_driver);
+
+     return 0;
+}
+
+static int sprd_probe(struct platform_device *pdev)
+{
+     struct resource *res;
+     struct uart_port *up;
+     struct clk *clk;
+     int irq;
+     int index;
+     int ret;
+
+     for (index = 0; index < ARRAY_SIZE(sprd_port); index++)
+             if (sprd_port[index] == NULL)
+                     break;
+
+     if (index == ARRAY_SIZE(sprd_port))

drivers/tty/serial/sprd_serial.c line 706

Quoted 10 lines

drivers/tty/serial/sprd_serial.c new file +10 -0

+             return -EBUSY;
+
+     index = sprd_probe_dt_alias(index, &pdev->dev);
+
+     sprd_port[index] = devm_kzalloc(&pdev->dev,
+             sizeof(*sprd_port[index]), GFP_KERNEL);
+     if (!sprd_port[index])
+             return -ENOMEM;
+
+     pdev->id = index;

        ^^^^^^^^^^^^^^^^

delete this line.

The platform device id cannot be assigned by the driver. (This was left over from trying to fix sprd_suspend/sprd_resume but that's fixed correctly now.)

Quoted 51 lines

drivers/tty/serial/sprd_serial.c new file +51 -0

+
+     up = &sprd_port[index]->port;
+     up->dev = &pdev->dev;
+     up->line = index;
+     up->type = PORT_SPRD;
+     up->iotype = SERIAL_IO_PORT;
+     up->uartclk = SPRD_DEF_RATE;
+     up->fifosize = SPRD_FIFO_SIZE;
+     up->ops = &serial_sprd_ops;
+     up->flags = UPF_BOOT_AUTOCONF;
+
+     clk = devm_clk_get(&pdev->dev, NULL);
+     if (!IS_ERR(clk))
+             up->uartclk = clk_get_rate(clk);
+
+     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+     if (!res) {
+             dev_err(&pdev->dev, "not provide mem resource\n");
+             return -ENODEV;
+     }
+     up->mapbase = res->start;
+     up->membase = devm_ioremap_resource(&pdev->dev, res);
+     if (IS_ERR(up->membase))
+             return PTR_ERR(up->membase);
+
+     irq = platform_get_irq(pdev, 0);
+     if (irq < 0) {
+             dev_err(&pdev->dev, "not provide irq resource\n");
+             return -ENODEV;
+     }
+     up->irq = irq;
+
+     if (!sprd_ports_num) {
+             ret = uart_register_driver(&sprd_uart_driver);
+             if (ret < 0) {
+                     pr_err("Failed to register SPRD-UART driver\n");
+                     return ret;
+             }
+     }
+     sprd_ports_num++;
+
+     ret = uart_add_one_port(&sprd_uart_driver, up);
+     if (ret) {
+             sprd_port[index] = NULL;
+             sprd_remove(pdev);
+     }
+
+     platform_set_drvdata(pdev, up);
+
+     return ret;
+}

This patch-set split the last version, and addressed the review comments from last version on serial driver code.

Changes from v7:
* Addressed review comments from Peter:
- Initialized the stack local with zero in sprd_set_termios()
- Used dev_get_drvdata() to get sprd_uart_port

Quoted 8 lines · On Tuesday 27 January 2015 15:56:45 Chunyan Zhang wrote:

This patch-set split the last version, and addressed the review comments from last version on serial driver code.

Changes from v7:
* Addressed review comments from Peter:
- Initialized the stack local with zero in sprd_set_termios()
- Used dev_get_drvdata() to get sprd_uart_port

Looks good to me, but you still have too many people on 'To', so Greg might be missing that you expect him to merge it.

Greg, if there are no further comments, can you take both patches through the tty git?

Quoted 13 lines · Arnd Bergmann

Quoted 8 lines · On Tuesday 27 January 2015 15:56:45 Chunyan Zhang wrote:

This patch-set split the last version, and addressed the review comments from last version on serial driver code.

Changes from v7:
* Addressed review comments from Peter:
- Initialized the stack local with zero in sprd_set_termios()
- Used dev_get_drvdata() to get sprd_uart_port

Looks good to me, but you still have too many people on 'To', so Greg might be missing that you expect him to merge it.

Quoted 2 lines

Greg, if there are no further comments, can you take both patches through the tty git?

Will do, thanks.

greg k-h