Skip to contentSkip to conversation

signal/timer/event fds v8 - anonymous inode source ...

PATCH In review Davide Libenzi 4 participants 7 messages Mar 20, 2007 – Mar 31, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/13 signal/timer/event fds v8 - anonymous inode source ...

This patch add an anonymous inode source, to be used for files that need and inode only in order to create a file*. We do not care of having an inode for each file, and we do not even care of having different names in the associated dentries (dentry names will be same for classes of file*). This allow code reuse, and will be used by epoll, signalfd and timerfd (and whatever else there'll be).

- Davide

fs/anon_inodes.c new file +204 -0
Index: linux-2.6.21-rc3.quilt/fs/anon_inodes.c
===================================================================
@@ -0,0 +1,204 @@
+/*
+ *  fs/anon_inodes.c
+ *
+ *  Copyright (C) 2007  Davide Libenzi <[email protected]>
+ *
+ *  Thanks to Arnd Bergmann for code review and suggestions.
+ *  More changes for Thomas Gleixner suggestions.
+ */
+
+#include <linux/file.h>
+#include <linux/poll.h>
+#include <linux/slab.h>
+#include <linux/init.h>
+#include <linux/fs.h>
+#include <linux/mount.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/magic.h>
+#include <linux/anon_inodes.h>
+
+#include <asm/uaccess.h>
+
+
+
+static int ainofs_delete_dentry(struct dentry *dentry);
+static struct inode *aino_mkinode(void);
+static int ainofs_get_sb(struct file_system_type *fs_type, int flags,
+			 const char *dev_name, void *data, struct vfsmount *mnt);
+
+
+
+static struct vfsmount *aino_mnt __read_mostly;
+static struct inode *aino_inode;
+static const struct file_operations aino_fops = { };
+static struct file_system_type aino_fs_type = {
+	.name		= "ainofs",
+	.get_sb		= ainofs_get_sb,
+	.kill_sb	= kill_anon_super,
+};
+static struct dentry_operations ainofs_dentry_operations = {
+	.d_delete	= ainofs_delete_dentry,
+};
+
+
+
+/**
+ * aino_getfd - creates a new file instance by hooking it up to and anonymous
+ *              inode, and a dentry that describe the "class" of the file
+ * @pfd:     [out]   pointer to the file descriptor
+ * @dpinode: [out]   pointer to the inode
+ * @pfile:   [out]   pointer to the file struct
+ * @name:    [in]    name of the "class" of the new file
+ * @fops     [in]    file operations for the new file
+ * @priv     [in]    private data for the new file (will be file's private_data)
+ *
+ * Creates a new file by hooking it on a single inode. This is useful for files
+ * that do not need to have a full-fledged inode in order to operate correctly.
+ * All the files created with aino_getfd() will share a single inode, by hence
+ * saving memory and avoiding code duplication for the file/inode/dentry setup.
+ */
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv)
+{
+	struct qstr this;
+	struct dentry *dentry;
+	struct inode *inode;
+	struct file *file;
+	int error, fd;
+
+	if (IS_ERR(aino_inode))
+		return -ENODEV;
+	file = get_empty_filp();
+	if (!file)
+		return -ENFILE;
+
+	inode = igrab(aino_inode);
+	if (IS_ERR(inode)) {
+		error = PTR_ERR(inode);
+		goto err_put_filp;
+	}
+
+	error = get_unused_fd();
+	if (error < 0)
+		goto err_iput;
+	fd = error;
+
+	/*
+	 * Link the inode to a directory entry by creating a unique name
+	 * using the inode sequence number.
+	 */
+	error = -ENOMEM;
+	this.name = name;
+	this.len = strlen(name);
+	this.hash = 0;
+	dentry = d_alloc(aino_mnt->mnt_sb->s_root, &this);
+	if (!dentry)
+		goto err_put_unused_fd;
+	dentry->d_op = &ainofs_dentry_operations;
+	/* Do not publish this dentry inside the global dentry hash table */
+	dentry->d_flags &= ~DCACHE_UNHASHED;
+	d_instantiate(dentry, inode);
+
+	file->f_path.mnt = mntget(aino_mnt);
+	file->f_path.dentry = dentry;
+	file->f_mapping = inode->i_mapping;
+
+	file->f_pos = 0;
+	file->f_flags = O_RDWR;
+	file->f_op = fops;
+	file->f_mode = FMODE_READ | FMODE_WRITE;
+	file->f_version = 0;
+	file->private_data = priv;
+
+	fd_install(fd, file);
+
+	*pfd = fd;
+	*pinode = inode;
+	*pfile = file;
+	return 0;
+
+err_put_unused_fd:
+	put_unused_fd(fd);
+err_iput:
+	iput(inode);
+err_put_filp:
+	put_filp(file);
+	return error;
+}
+
+static int ainofs_delete_dentry(struct dentry *dentry)
+{
+	/*
+	 * We faked vfs to believe the dentry was hashed when we created it.
+	 * Now we restore the flag so that dput() will work correctly.
+	 */
+	dentry->d_flags |= DCACHE_UNHASHED;
+	return 1;
+}
+
+/*
+ * A single inode exist for all aino files. On the contrary of pipes,
+ * aino inodes has no per-instance data associated, so we can avoid
+ * the allocation of multiple of them.
+ */
+static struct inode *aino_mkinode(void)
+{
+	struct inode *inode = new_inode(aino_mnt->mnt_sb);
+
+	if (!inode)
+		return ERR_PTR(-ENOMEM);
+
+	inode->i_fop = &aino_fops;
+
+	/*
+	 * Mark the inode dirty from the very beginning,
+	 * that way it will never be moved to the dirty
+	 * list because mark_inode_dirty() will think
+	 * that it already _is_ on the dirty list.
+	 */
+	inode->i_state = I_DIRTY;
+	inode->i_mode = S_IRUSR | S_IWUSR;
+	inode->i_uid = current->fsuid;
+	inode->i_gid = current->fsgid;
+	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+	return inode;
+}
+
+static int ainofs_get_sb(struct file_system_type *fs_type, int flags,
+			 const char *dev_name, void *data, struct vfsmount *mnt)
+{
+	return get_sb_pseudo(fs_type, "aino:", NULL, AINOFS_MAGIC, mnt);
+}
+
+static int __init aino_init(void)
+{
+	int error;
+
+	error = register_filesystem(&aino_fs_type);
+	if (error)
+		goto err_exit;
+	aino_mnt = kern_mount(&aino_fs_type);
+	if (IS_ERR(aino_mnt)) {
+		error = PTR_ERR(aino_mnt);
+		goto err_unregister_filesystem;
+	}
+	aino_inode = aino_mkinode();
+	if (IS_ERR(aino_inode)) {
+		error = PTR_ERR(aino_inode);
+		goto err_mntput;
+	}
+
+	return 0;
+
+err_mntput:
+	mntput(aino_mnt);
+err_unregister_filesystem:
+	unregister_filesystem(&aino_fs_type);
+err_exit:
+	printk(KERN_ERR "aino_init() failed (%d)\n", error);
+	return error;
+}
+
+fs_initcall(aino_init);
+
include/linux/anon_inodes.h new file +15 -0
Index: linux-2.6.21-rc3.quilt/include/linux/anon_inodes.h
===================================================================
@@ -0,0 +1,15 @@
+/*
+ *  include/linux/anon_inodes.h
+ *
+ *  Copyright (C) 2007  Davide Libenzi <[email protected]>
+ *
+ */
+
+#ifndef _LINUX_ANON_INODES_H
+#define _LINUX_ANON_INODES_H
+
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv);
+
+#endif /* _LINUX_ANON_INODES_H */
+
fs/Makefile +1 -1
Index: linux-2.6.21-rc3.quilt/fs/Makefile
===================================================================
@@ -11,7 +11,7 @@
 		attr.o bad_inode.o file.o filesystems.o namespace.o aio.o \
 		seq_file.o xattr.o libfs.o fs-writeback.o \
 		pnode.o drop_caches.o splice.o sync.o utimes.o \
-		stack.o
+		stack.o anon_inodes.o
 
 ifeq ($(CONFIG_BLOCK),y)
 obj-y +=	buffer.o bio.o block_dev.o direct-io.o mpage.o ioprio.o
include/linux/magic.h +1 -0
Index: linux-2.6.21-rc3.quilt/include/linux/magic.h
===================================================================
@@ -14,6 +14,7 @@
 #define ISOFS_SUPER_MAGIC	0x9660
 #define JFFS2_SUPER_MAGIC	0x72b6
 #define KVMFS_SUPER_MAGIC	0x19700426
+#define AINOFS_MAGIC		0x09041934
 
 #define MINIX_SUPER_MAGIC	0x137F		/* original minix fs */
 #define MINIX_SUPER_MAGIC2	0x138F		/* minix fs, 30 char names */
#1 lore raw
Quoted 36 lines · On Tue, 20 Mar 2007 11:37:14 -0700 Davide Libenzi <[email protected]>…

This patch add an anonymous inode source, to be used for files that need and inode only in order to create a file*. We do not care of having an inode for each file, and we do not even care of having different names in the associated dentries (dentry names will be same for classes of file*). This allow code reuse, and will be used by epoll, signalfd and timerfd (and whatever else there'll be).

- Davide

Index: linux-2.6.21-rc3.quilt/fs/anon_inodes.c
===================================================================

fs/anon_inodes.c new file +14 -0
@@ -0,0 +1,204 @@
+/*
+ *  fs/anon_inodes.c
+ *
+ *  Copyright (C) 2007  Davide Libenzi <[email protected]>
+ *
+ *  Thanks to Arnd Bergmann for code review and suggestions.
+ *  More changes for Thomas Gleixner suggestions.
+ */
+
+#include <linux/file.h>
+#include <linux/poll.h>
+#include <linux/slab.h>
+#include <linux/init.h>
+#include <linux/fs.h>

fs/anon_inodes.c line 24

Quoted 10 lines
fs/anon_inodes.c new file +10 -0
+#include <linux/mount.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/magic.h>
+#include <linux/anon_inodes.h>
+
+#include <asm/uaccess.h>
+
+
+

Too many blank lines

fs/anon_inodes.c line 26

Quoted 2 lines
fs/anon_inodes.c new file +2 -0
+static int ainofs_delete_dentry(struct dentry *dentry);
+static struct inode *aino_mkinode(void);

Unneeded forward declaration.

fs/anon_inodes.c line 34

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+static int ainofs_get_sb(struct file_system_type *fs_type, int flags,
+			 const char *dev_name, void *data, struct vfsmount *mnt);
+
+
+
+static struct vfsmount *aino_mnt __read_mostly;
+static struct inode *aino_inode;
+static const struct file_operations aino_fops = { };

Unneeded { }

fs/anon_inodes.c line 42

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+static struct file_system_type aino_fs_type = {
+	.name		= "ainofs",
+	.get_sb		= ainofs_get_sb,
+	.kill_sb	= kill_anon_super,
+};
+static struct dentry_operations ainofs_dentry_operations = {
+	.d_delete	= ainofs_delete_dentry,
+};

If this is moved elsewhere we can perhaps remove some or all of the unpleasing static function forward-declarations.

fs/anon_inodes.c line 22

Quoted 3 lines
fs/anon_inodes.c new file +3 -0
+
+
+

Too many blank lines

fs/anon_inodes.c line 54

Quoted 9 lines
fs/anon_inodes.c new file +9 -0
+/**
+ * aino_getfd - creates a new file instance by hooking it up to and anonymous
+ *              inode, and a dentry that describe the "class" of the file
+ * @pfd:     [out]   pointer to the file descriptor
+ * @dpinode: [out]   pointer to the inode
+ * @pfile:   [out]   pointer to the file struct
+ * @name:    [in]    name of the "class" of the new file
+ * @fops     [in]    file operations for the new file
+ * @priv     [in]    private data for the new file (will be file's private_data)

The [in] and [out] thing is nice - does kerneldoc handle it appropriately?

fs/anon_inodes.c line 62

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+ *
+ * Creates a new file by hooking it on a single inode. This is useful for files
+ * that do not need to have a full-fledged inode in order to operate correctly.
+ * All the files created with aino_getfd() will share a single inode, by hence
+ * saving memory and avoiding code duplication for the file/inode/dentry setup.
+ */
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv)

Dunno about others, but the "aino" naming doesn't grab me, really. anon_inode_getfd() would make more sense.

We conventionally use const char *' rather than char const *', and I thnk it is more logical to do so.

Quoted 66 lines
fs/anon_inodes.c new file +66 -0
+{
+	struct qstr this;
+	struct dentry *dentry;
+	struct inode *inode;
+	struct file *file;
+	int error, fd;
+
+	if (IS_ERR(aino_inode))
+		return -ENODEV;
+	file = get_empty_filp();
+	if (!file)
+		return -ENFILE;
+
+	inode = igrab(aino_inode);
+	if (IS_ERR(inode)) {
+		error = PTR_ERR(inode);
+		goto err_put_filp;
+	}
+
+	error = get_unused_fd();
+	if (error < 0)
+		goto err_iput;
+	fd = error;
+
+	/*
+	 * Link the inode to a directory entry by creating a unique name
+	 * using the inode sequence number.
+	 */
+	error = -ENOMEM;
+	this.name = name;
+	this.len = strlen(name);
+	this.hash = 0;
+	dentry = d_alloc(aino_mnt->mnt_sb->s_root, &this);
+	if (!dentry)
+		goto err_put_unused_fd;
+	dentry->d_op = &ainofs_dentry_operations;
+	/* Do not publish this dentry inside the global dentry hash table */
+	dentry->d_flags &= ~DCACHE_UNHASHED;
+	d_instantiate(dentry, inode);
+
+	file->f_path.mnt = mntget(aino_mnt);
+	file->f_path.dentry = dentry;
+	file->f_mapping = inode->i_mapping;
+
+	file->f_pos = 0;
+	file->f_flags = O_RDWR;
+	file->f_op = fops;
+	file->f_mode = FMODE_READ | FMODE_WRITE;
+	file->f_version = 0;
+	file->private_data = priv;
+
+	fd_install(fd, file);
+
+	*pfd = fd;
+	*pinode = inode;
+	*pfile = file;
+	return 0;
+
+err_put_unused_fd:
+	put_unused_fd(fd);
+err_iput:
+	iput(inode);
+err_put_filp:
+	put_filp(file);
+	return error;
+}

fs/anon_inodes.c line 138

Quoted 10 lines
fs/anon_inodes.c new file +10 -0
+
+static int ainofs_delete_dentry(struct dentry *dentry)
+{
+	/*
+	 * We faked vfs to believe the dentry was hashed when we created it.
+	 * Now we restore the flag so that dput() will work correctly.
+	 */
+	dentry->d_flags |= DCACHE_UNHASHED;
+	return 1;
+}

Is that legit, or is it a hack??

fs/anon_inodes.c line 144

Quoted 5 lines
fs/anon_inodes.c new file +5 -0
+/*
+ * A single inode exist for all aino files. On the contrary of pipes,
+ * aino inodes has no per-instance data associated, so we can avoid
+ * the allocation of multiple of them.
+ */

"Contrary to pipes, aino inodes have no ...."

Quoted 5 lines
fs/anon_inodes.c new file +5 -0
+static struct inode *aino_mkinode(void)
+{
+	struct inode *inode = new_inode(aino_mnt->mnt_sb);
+
+	if (!inode)

fs/anon_inodes.c line 159

Quoted 10 lines
fs/anon_inodes.c new file +10 -0
+		return ERR_PTR(-ENOMEM);
+
+	inode->i_fop = &aino_fops;
+
+	/*
+	 * Mark the inode dirty from the very beginning,
+	 * that way it will never be moved to the dirty
+	 * list because mark_inode_dirty() will think
+	 * that it already _is_ on the dirty list.
+	 */

Thus breaking what is hopefully a VFS invariant. How come?

Quoted 30 lines
fs/anon_inodes.c new file +30 -0
+	inode->i_state = I_DIRTY;
+	inode->i_mode = S_IRUSR | S_IWUSR;
+	inode->i_uid = current->fsuid;
+	inode->i_gid = current->fsgid;
+	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+	return inode;
+}
+
+static int ainofs_get_sb(struct file_system_type *fs_type, int flags,
+			 const char *dev_name, void *data, struct vfsmount *mnt)
+{
+	return get_sb_pseudo(fs_type, "aino:", NULL, AINOFS_MAGIC, mnt);
+}
+
+static int __init aino_init(void)
+{
+	int error;
+
+	error = register_filesystem(&aino_fs_type);
+	if (error)
+		goto err_exit;
+	aino_mnt = kern_mount(&aino_fs_type);
+	if (IS_ERR(aino_mnt)) {
+		error = PTR_ERR(aino_mnt);
+		goto err_unregister_filesystem;
+	}
+	aino_inode = aino_mkinode();
+	if (IS_ERR(aino_inode)) {
+		error = PTR_ERR(aino_inode);
+		goto err_mntput;

fs/anon_inodes.c line 199

Quoted 10 lines
fs/anon_inodes.c new file +10 -0
+	}
+
+	return 0;
+
+err_mntput:
+	mntput(aino_mnt);
+err_unregister_filesystem:
+	unregister_filesystem(&aino_fs_type);
+err_exit:
+	printk(KERN_ERR "aino_init() failed (%d)\n", error);

I suspect this is panic time?

Quoted 30 lines
fs/anon_inodes.c new file +5 -0
+	return error;
+}
+
+fs_initcall(aino_init);
+

Index: linux-2.6.21-rc3.quilt/include/linux/anon_inodes.h
===================================================================

include/linux/anon_inodes.h new file +15 -0
@@ -0,0 +1,15 @@
+/*
+ *  include/linux/anon_inodes.h
+ *
+ *  Copyright (C) 2007  Davide Libenzi <[email protected]>
+ *
+ */
+
+#ifndef _LINUX_ANON_INODES_H
+#define _LINUX_ANON_INODES_H
+
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv);
+
+#endif /* _LINUX_ANON_INODES_H */
+

Index: linux-2.6.21-rc3.quilt/fs/Makefile
===================================================================

fs/Makefile line 14

Quoted 5 lines
fs/Makefile +1 -1
@@ -11,7 +11,7 @@
 		attr.o bad_inode.o file.o filesystems.o namespace.o aio.o \
 		seq_file.o xattr.o libfs.o fs-writeback.o \
 		pnode.o drop_caches.o splice.o sync.o utimes.o \
-		stack.o
+		stack.o anon_inodes.o

Can we make this optional if CONFIG_EMBEDDED? You plan on converting epoll to use this facility, but with CONFIG_EPOLL=n, this is all dead code?

Quoted 2 lines
fs/Makefile +0 -0
 ifeq ($(CONFIG_BLOCK),y)
 obj-y +=	buffer.o bio.o block_dev.o direct-io.o mpage.o ioprio.o
#2 lore raw
Quoted 6 lines · Andrew Morton

fs/anon_inodes.c line 24

Quoted 4 lines
fs/anon_inodes.c new file +4 -0
+#include <asm/uaccess.h>
+
+
+

Too many blank lines

It'd be interesting to know how much is enough. You use one, ppl says it is too dense. You use more, ppl says it's too much.
There's the one-line rule for inter-function spacing, but what's the include-functions ones? Or the functions-data ones?

Quoted 4 lines

fs/anon_inodes.c line 26

Quoted 2 lines
fs/anon_inodes.c new file +2 -0
+static int ainofs_delete_dentry(struct dentry *dentry);
+static struct inode *aino_mkinode(void);

Unneeded forward declaration.

Same here. You're the third says this, so I'm gonna change it. But pls consider adding it to the coding style.

Quoted 10 lines

fs/anon_inodes.c line 34

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+static int ainofs_get_sb(struct file_system_type *fs_type, int flags,
+			 const char *dev_name, void *data, struct vfsmount *mnt);
+
+
+
+static struct vfsmount *aino_mnt __read_mostly;
+static struct inode *aino_inode;
+static const struct file_operations aino_fops = { };

Unneeded { }

Ack.

Quoted 11 lines

fs/anon_inodes.c line 42

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+static struct file_system_type aino_fs_type = {
+	.name		= "ainofs",
+	.get_sb		= ainofs_get_sb,
+	.kill_sb	= kill_anon_super,
+};
+static struct dentry_operations ainofs_dentry_operations = {
+	.d_delete	= ainofs_delete_dentry,
+};

If this is moved elsewhere we can perhaps remove some or all of the unpleasing static function forward-declarations.

Grrr :)

Quoted 11 lines
Quoted 9 lines

+/**
+ * aino_getfd - creates a new file instance by hooking it up to and anonymous
+ * inode, and a dentry that describe the "class" of the file

+ * @pfd:     [out]   pointer to the file descriptor
+ * @dpinode: [out]   pointer to the inode
+ * @pfile:   [out]   pointer to the file struct
+ * @name:    [in]    name of the "class" of the new file
+ * @fops     [in]    file operations for the new file
+ * @priv     [in]    private data for the new file (will be file's private_data)

The [in] and [out] thing is nice - does kerneldoc handle it appropriately?

No idea. It should come out as text at least.

Quoted 11 lines

fs/anon_inodes.c line 62

Quoted 8 lines

+ *
+ * Creates a new file by hooking it on a single inode. This is useful for files
+ * that do not need to have a full-fledged inode in order to operate correctly.
+ * All the files created with aino_getfd() will share a single inode, by hence
+ * saving memory and avoiding code duplication for the file/inode/dentry setup.
+ */

fs/anon_inodes.c new file +2 -0
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv)

Dunno about others, but the "aino" naming doesn't grab me, really. anon_inode_getfd() would make more sense.

Why? Don't you like fortran-like compact naming? :)

Quoted 2 lines

We conventionally use const char *' rather than char const *', and I thnk it is more logical to do so.

Okie

Quoted 11 lines

fs/anon_inodes.c line 138

Quoted 9 lines
fs/anon_inodes.c new file +9 -0
+static int ainofs_delete_dentry(struct dentry *dentry)
+{
+	/*
+	 * We faked vfs to believe the dentry was hashed when we created it.
+	 * Now we restore the flag so that dput() will work correctly.
+	 */
+	dentry->d_flags |= DCACHE_UNHASHED;
+	return 1;
+}

Is that legit, or is it a hack??

Same thing used in pipes. Avoid loading the hash for things that'll never be looked up.

Quoted 7 lines
Quoted 5 lines

+/*
+ * A single inode exist for all aino files. On the contrary of pipes,
+ * aino inodes has no per-instance data associated, so we can avoid
+ * the allocation of multiple of them.
+ */

"Contrary to pipes, aino inodes have no ...."

Ok

Quoted 9 lines
Quoted 9 lines
fs/anon_inodes.c new file +9 -0
+static struct inode *aino_mkinode(void)
+{
+	struct inode *inode = new_inode(aino_mnt->mnt_sb);
+
+	if (!inode)
+		return ERR_PTR(-ENOMEM);
+
+	inode->i_fop = &aino_fops;
+
Quoted 8 lines

fs/anon_inodes.c line 159

Quoted 6 lines
fs/anon_inodes.c new file +6 -0
+	/*
+	 * Mark the inode dirty from the very beginning,
+	 * that way it will never be moved to the dirty
+	 * list because mark_inode_dirty() will think
+	 * that it already _is_ on the dirty list.
+	 */

Thus breaking what is hopefully a VFS invariant. How come?

Copied from pipes.

Quoted 20 lines
Quoted 20 lines
fs/anon_inodes.c new file +20 -0
+static int __init aino_init(void)
+{
+	int error;
+
+	error = register_filesystem(&aino_fs_type);
+	if (error)
+		goto err_exit;
+	aino_mnt = kern_mount(&aino_fs_type);
+	if (IS_ERR(aino_mnt)) {
+		error = PTR_ERR(aino_mnt);
+		goto err_unregister_filesystem;
+	}
+	aino_inode = aino_mkinode();
+	if (IS_ERR(aino_inode)) {
+		error = PTR_ERR(aino_inode);
+		goto err_mntput;
+	}
+
+	return 0;
+
Quoted 8 lines

fs/anon_inodes.c line 199

Quoted 6 lines
fs/anon_inodes.c new file +6 -0
+err_mntput:
+	mntput(aino_mnt);
+err_unregister_filesystem:
+	unregister_filesystem(&aino_fs_type);
+err_exit:
+	printk(KERN_ERR "aino_init() failed (%d)\n", error);

I suspect this is panic time?

Ok, it was panincing, and someone made me change it. Would you please agree?
The system can survive w/out, but it'll be a broken system WRT userspace.

Quoted 10 lines
Quoted 10 lines
include/linux/anon_inodes.h new file +5 -0
+int aino_getfd(int *pfd, struct inode **pinode, struct file **pfile,
+	       char const *name, const struct file_operations *fops, void *priv);
+
+#endif /* _LINUX_ANON_INODES_H */
+

Index: linux-2.6.21-rc3.quilt/fs/Makefile
===================================================================

fs/Makefile +0 -0
@@ -11,7 +11,7 @@
Quoted 8 lines

fs/Makefile line 14

Quoted 5 lines
fs/Makefile +1 -1
 		attr.o bad_inode.o file.o filesystems.o namespace.o aio.o \
 		seq_file.o xattr.o libfs.o fs-writeback.o \
 		pnode.o drop_caches.o splice.o sync.o utimes.o \
-		stack.o
+		stack.o anon_inodes.o

Can we make this optional if CONFIG_EMBEDDED? You plan on converting epoll to use this facility, but with CONFIG_EPOLL=n, this is all dead code?

Hmmm, the whole point is that all this stuff works with or without epoll. And epoll need no changes to support this.

- Davide

#3 lore raw
Quoted 9 lines · On Fri, 30 Mar 2007 15:44:15 -0700 (PDT) Davide Libenzi wrote:
Quoted 6 lines · Andrew Morton

fs/anon_inodes.c line 24

Quoted 4 lines
fs/anon_inodes.c new file +4 -0
+#include <asm/uaccess.h>
+
+
+

Too many blank lines

Quoted 4 lines

It'd be interesting to know how much is enough. You use one, ppl says it is too dense. You use more, ppl says it's too much.
There's the one-line rule for inter-function spacing, but what's the include-functions ones? Or the functions-data ones?

1 :)

Quoted 22 lines
Quoted 4 lines

fs/anon_inodes.c line 26

Quoted 2 lines
fs/anon_inodes.c new file +2 -0
+static int ainofs_delete_dentry(struct dentry *dentry);
+static struct inode *aino_mkinode(void);

Unneeded forward declaration.

Same here. You're the third says this, so I'm gonna change it. But pls consider adding it to the coding style.

Quoted 11 lines

fs/anon_inodes.c line 42

Quoted 8 lines
fs/anon_inodes.c new file +8 -0
+static struct file_system_type aino_fs_type = {
+	.name		= "ainofs",
+	.get_sb		= ainofs_get_sb,
+	.kill_sb	= kill_anon_super,
+};
+static struct dentry_operations ainofs_dentry_operations = {
+	.d_delete	= ainofs_delete_dentry,
+};

If this is moved elsewhere we can perhaps remove some or all of the unpleasing static function forward-declarations.

Quoted 1 line

Grrr :)

you are a puttycat

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines

+/**
+ * aino_getfd - creates a new file instance by hooking it up to and anonymous
+ * inode, and a dentry that describe the "class" of the file

+ * @pfd:     [out]   pointer to the file descriptor
+ * @dpinode: [out]   pointer to the inode
+ * @pfile:   [out]   pointer to the file struct
+ * @name:    [in]    name of the "class" of the new file
+ * @fops     [in]    file operations for the new file
+ * @priv     [in]    private data for the new file (will be file's private_data)
Quoted 3 lines
Quoted 1 line

The [in] and [out] thing is nice - does kerneldoc handle it appropriately?

No idea. It should come out as text at least.

Yes, it's just [nice] text.

But the function description needs to fit on one line. If that's not enough, put more description after the @params lines, separated by a
*
"blank" line.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#4 lore raw
In reply to Davide Libenzi
Quoted 9 lines · On Fri, 30 Mar 2007 15:44:15 -0700 (PDT) Davide Libenzi…
Quoted 6 lines · Andrew Morton

fs/anon_inodes.c line 24

Quoted 4 lines
fs/anon_inodes.c new file +4 -0
+#include <asm/uaccess.h>
+
+
+

Too many blank lines

Quoted 5 lines

It'd be interesting to know how much is enough. You use one, ppl says it is too dense. You use more, ppl says it's too much.
There's the one-line rule for inter-function spacing, but what's the include-functions ones? Or the functions-data ones?

less ;)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
fs/anon_inodes.c new file +20 -0
+static int __init aino_init(void)
+{
+	int error;
+
+	error = register_filesystem(&aino_fs_type);
+	if (error)
+		goto err_exit;
+	aino_mnt = kern_mount(&aino_fs_type);
+	if (IS_ERR(aino_mnt)) {
+		error = PTR_ERR(aino_mnt);
+		goto err_unregister_filesystem;
+	}
+	aino_inode = aino_mkinode();
+	if (IS_ERR(aino_inode)) {
+		error = PTR_ERR(aino_inode);
+		goto err_mntput;
+	}
+
+	return 0;
+
Quoted 8 lines

fs/anon_inodes.c line 199

Quoted 6 lines
fs/anon_inodes.c new file +6 -0
+err_mntput:
+	mntput(aino_mnt);
+err_unregister_filesystem:
+	unregister_filesystem(&aino_fs_type);
+err_exit:
+	printk(KERN_ERR "aino_init() failed (%d)\n", error);

I suspect this is panic time?

Quoted 3 lines

Ok, it was panincing, and someone made me change it. Would you please agree?
The system can survive w/out, but it'll be a broken system WRT userspace.

I'd say panic. There's no much point in limping along with an incorrectly-working kernel, only to have some small number of apps fail mysteriously later on.

Quoted 6 lines
Quoted 3 lines

Can we make this optional if CONFIG_EMBEDDED? You plan on converting epoll to use this facility, but with CONFIG_EPOLL=n, this is all dead code?

Hmmm, the whole point is that all this stuff works with or without epoll. And epoll need no changes to support this.

I'm suggesting that all known clients of anon_inode be made optional. Hence anon_iode can become optional too.

It's a desirable objective, at least. The default, really.

#5 lore raw
Quoted 3 lines · Andrew Morton

I'd say panic. There's no much point in limping along with an incorrectly-working kernel, only to have some small number of apps fail mysteriously later on.

Panic it is ...

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

Can we make this optional if CONFIG_EMBEDDED? You plan on converting epoll to use this facility, but with CONFIG_EPOLL=n, this is all dead code?

Hmmm, the whole point is that all this stuff works with or without epoll. And epoll need no changes to support this.

I'm suggesting that all known clients of anon_inode be made optional. Hence anon_iode can become optional too.

It's a desirable objective, at least. The default, really.

Ok, I'll put them under Kconf.

- Davide

#6 lore raw
In reply to Andrew Morton
Quoted 8 lines · Andrew Morton
Quoted 4 lines

Ok, it was panincing, and someone made me change it. Would you please agree?
The system can survive w/out, but it'll be a broken system WRT userspace.

I'd say panic. There's no much point in limping along with an incorrectly-working kernel, only to have some small number of apps fail mysteriously later on.

Well, in this case (since it's at bootup only), I'd agree with panic(), but generally I disagree - it's actually much better to have a broken system limping along and allowing things like syslogd to write the problem to log-files and generally working as well as possible.

If people can do a "dmesg" and send it out as an email, we're much more likely to get good bug-reports.

But for early boot, and for something that can't really happen anyway, panic() sounds fine.

Linus