media: ccs: complement the return check of pm_runtime_get_if_active()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Peiwei,
Quoted 13 lines · Peiwei Hu
pm_runtime_get_if_active()can return the negative value. The operator ! confuses the negative one with positive situation.Signed-off-by Peiwei Hu <[email protected]>--- drivers/media/i2c/ccs/ccs-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/ccs/ccs-core.c +0
-0
drivers/media/i2c/ccs/ccs-core.c static int ccs_set_ctrl(struct v4l2_ctrl *ctrl) · line 675
Quoted 7 lines
drivers/media/i2c/ccs/ccs-core.c +1
-1@@ -670,7 +670,7 @@ static int ccs_set_ctrl(struct v4l2_ctrl *ctrl)break ; } - pm_status =pm_runtime_get_if_active (&client->dev, true); + pm_status =pm_runtime_get_if_active (&client->dev, true) >0 ;if (!pm_status)return 0 ;
This is intentional --- pm_runtime_get_if_active() returns an error if runtime PM is disabled.
Signature · 3 lines
Regards, Sakari Ailus