Skip to contentSkip to conversation

fs/buffer.c: Remove the unnecessary init operation afterallocating buffer_head.

PATCH remaper 1 participant 1 message Apr 19, 2013

Subsystems (2)
lore
Share & tools
lore

remaper

author
#0 lore raw

i don't understand why the init_buffer() should relay on the memory allocation behavior, :)

------------------ Original ------------------

From:  "majianpeng"<[email protected]>;
Date:  Fri, Apr 19, 2013 10:29 AM
To:  "Al Viro"<[email protected]>; "akpm"<[email protected]>; "tytso"<[email protected]>; 

Cc: "linux-fsdevel"<[email protected]>; "linux-kernel"<[email protected]>; "linux-ext4"<[email protected]>;
Subject: [PATCH] fs/buffer.c: Remove the unnecessary init operation afterallocating buffer_head.

Because alloc struct buffer_head using kmem_cache_zalloc,so it's not need to call 'init_buffer(bh, NULL, NULL)'.

---
 fs/buffer.c       | 2 --
 fs/jbd/journal.c  | 1 -
 fs/jbd2/journal.c | 1 -
 3 files changed, 4 deletions(-)
fs/buffer.c +0 -2
index b4dcb34..52b7739 100644
@@ -865,8 +865,6 @@ try_again:
 
         /* Link the buffer to its page */
         set_bh_page(bh, page, offset);
-
-        init_buffer(bh, NULL, NULL);
     }
     return head;
 /*
fs/jbd/journal.c +0 -1
index 81cc7ea..0c3fe90 100644
@@ -311,7 +311,6 @@ int journal_write_metadata_buffer(transaction_t *transaction,
     new_bh = alloc_buffer_head(GFP_NOFS|__GFP_NOFAIL);
     /* keep subsequent assertions sane */
     new_bh->b_state = 0;
-    init_buffer(new_bh, NULL, NULL);
     atomic_set(&new_bh->b_count, 1);
     new_jh = journal_add_journal_head(new_bh);    /* This sleeps */
 
fs/jbd2/journal.c +0 -1
index ed10991..95120c6 100644
@@ -368,7 +368,6 @@ retry_alloc:
 
     /* keep subsequent assertions sane */
     new_bh->b_state = 0;
-    init_buffer(new_bh, NULL, NULL);
     atomic_set(&new_bh->b_count, 1);
     new_jh = jbd2_journal_add_journal_head(new_bh);    /* This sleeps */
 
Signature · 6 lines
1.8.2.rc2.4.g7799588

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html