Skip to contentSkip to conversation

double-check impact of ACPI patch on suspend-resume (PR #3521)

thesofproject/linux Rafael J. Wysocki 1 participant 1 message Mar 16, 2022 3 messages not in the archive ACPI

lore
Share & tools
lore

Rafael J. Wysocki

author maintainer
#3 lore raw
In reply to a message not in the archive

For the information of everyone on the mailing lists:

Commit e38f9ff ("ACPI: scan: Do not add device IDs from _CID if _HID is not valid") is going to be reverted, because it caused multiple systems to misbehave as per the below.

Quoted 10 lines · Rafael J. Wysocki
Quoted 4 lines · Pierre-Louis Bossart

@rafaeljw @andy-shev @ujfalusi I think the results speak for themselves, we have two confirmed regressions with commit e38f9ff, so somehow filtering out the pnp_cid list has a very large impact.

I was able to fix the SoundWire regression by using the DPM_FLAG_SMART_SUSPEND to prevent a spurious pm_runtime resume, the other regression on a Chromebook is not clear at all.

OK, I'll revert that commit, but this pretty much means widespread firmware breakage.