mm/mpol: Create special PROT_NONE infrastructure
Subsystems (5)
Commit-ID: a573b4dfcf58f86235d586ea1f82ed54b2b7e620 Gitweb: http://git.kernel.org/tip/a573b4dfcf58f86235d586ea1f82ed54b2b7e620 Author: Peter Zijlstra <[email protected]> AuthorDate: Tue, 17 Jul 2012 18:25:14 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 26 Sep 2012 11:48:32 +0200
mm/mpol: Create special PROT_NONE infrastructure
In order to facilitate a lazy -- fault driven -- migration of pages, create a special transient PROT_NONE variant, we can then use the 'spurious' protection faults to drive our migrations from.
Pages that already had an effective PROT_NONE mapping will not be detected to generate these 'spuriuos' faults for the simple reason that we cannot distinguish them on their protection bits, see pte_prot_none.
This isn't a problem since PROT_NONE (and possible PROT_WRITE with dirty tracking) aren't used or are rare enough for us to not care about their placement.
Suggested-by Rik van Riel <[email protected]>
Signed-off-by Peter Zijlstra <[email protected]>
Reviewed-by Rik van Riel <[email protected]>
Cc Paul Turner <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Andrew Morton <[email protected]>
[ fixed various cross-arch and THP/!THP details ]
Signed-off-by Ingo Molnar <[email protected]>
--- include/linux/huge_mm.h | 19 +++++++++++ include/linux/mempolicy.h | 4 ++- include/linux/mm.h | 12 +++++++ mm/huge_memory.c | 32 +++++++++++++++++++ mm/memory.c | 75 ++++++++++++++++++++++++++++++++++++++++---- mm/mempolicy.c | 24 ++++++++++++++ mm/mprotect.c | 24 ++++++++++---- 7 files changed, 175 insertions(+), 15 deletions(-)
include/linux/huge_mm.h +19 -0
@@ -160,6 +160,13 @@ static inline struct page *compound_trans_head(struct page *page) }return page; } + +extern bool pmd_prot_none (struct vm_area_struct *vma,pmd_t pmd); + +extern void do_huge_pmd_prot_none (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long address,pmd_t *pmd, +unsigned int flags,pmd_t orig_pmd); +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; })#define HPAGE_PMD_MASK ({ BUILD_BUG(); 0; })
@@ -196,6 +203,18 @@ static inline int pmd_trans_huge_lock(pmd_t *pmd, {return 0 ; } + +static inline bool pmd_prot_none (struct vm_area_struct *vma,pmd_t pmd) +{ +return false; +} + +static inline void do_huge_pmd_prot_none (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long address,pmd_t *pmd, +unsigned int flags,pmd_t orig_pmd) +{ +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif /* _LINUX_HUGE_MM_H */
include/linux/mempolicy.h +3 -1
@@ -254,7 +254,9 @@ static inline int vma_migratable(struct vm_area_struct *vma) return 1; } -#else +extern void lazy_migrate_process (struct mm_struct *mm); + +#else /* CONFIG_NUMA */ struct mempolicy {};
include/linux/mm.h +12 -0
@@ -1088,6 +1088,9 @@ extern unsigned long move_page_tables(struct vm_area_struct *vma,extern unsigned long do_mremap (unsigned long addr,unsigned long old_len,unsigned long new_len,unsigned long flags,unsigned long new_addr); +extern void change_protection (struct vm_area_struct *vma,unsigned long start, +unsigned long end,pgprot_t newprot, +int dirty_accountable);extern int mprotect_fixup (struct vm_area_struct *vma,struct vm_area_struct **pprev,unsigned long start,unsigned long end,unsigned long newflags);
@@ -1539,6 +1542,15 @@ static inline pgprot_t vm_get_page_prot(unsigned long vm_flags) }#endif +static inline pgprot_t vma_prot_none (struct vm_area_struct *vma) +{ +/* +* obtain PROT_NONE by removing READ|WRITE|EXEC privs +*/ +vm_flags_t vmflags = vma->vm_flags & ~(VM_READ |VM_WRITE |VM_EXEC ); +return pgprot_modify (vma->vm_page_prot,vm_get_page_prot (vmflags)); +} +struct vm_area_struct *find_extend_vma (struct mm_struct *,unsigned long addr);int remap_pfn_range (struct vm_area_struct *,unsigned long addr,unsigned long pfn,unsigned long size,pgprot_t );
mm/huge_memory.c +32 -0
@@ -750,6 +750,38 @@ out:return handle_pte_fault (mm, vma, address, pte, pmd, flags); } +bool pmd_prot_none (struct vm_area_struct *vma,pmd_t pmd) +{ +/* +* See pte_prot_none(). +*/ +if (pmd_same (pmd,pmd_modify (pmd, vma->vm_page_prot))) +return false; + +return pmd_same (pmd,pmd_modify (pmd,vma_prot_none (vma))); +} + +void do_huge_pmd_prot_none (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long address,pmd_t *pmd, +unsigned int flags,pmd_t entry) +{ +unsigned long haddr = address &HPAGE_PMD_MASK ; + +spin_lock (&mm->page_table_lock); +if (unlikely (!pmd_same (*pmd, entry))) + goto out_unlock; + +/* do fancy stuff */ + +/* change back to regular protection */ + entry =pmd_modify (entry, vma->vm_page_prot); +if (pmdp_set_access_flags (vma, haddr, pmd, entry,1 )) +update_mmu_cache (vma, address, entry); + +out_unlock: +spin_unlock (&mm->page_table_lock); +} +int copy_huge_pmd (struct mm_struct *dst_mm,struct mm_struct *src_mm,pmd_t *dst_pmd,pmd_t *src_pmd,unsigned long addr,struct vm_area_struct *vma)
mm/memory.c +68 -7
105 lines not on this page · raw message
mm/mempolicy.c +24 -0
@@ -565,6 +565,12 @@ static inline int check_pgd_range(struct vm_area_struct *vma,return 0 ; } +static void +change_prot_none (struct vm_area_struct *vma,unsigned long start,unsigned long end) +{ +change_protection (vma, start, end,vma_prot_none (vma),0 ); +} +/* * Check if all pages in a range are on a set of nodes. * If pagelist != NULL then isolate pages from the LRU and
@@ -1197,6 +1203,24 @@ static long do_mbind(unsigned long start, unsigned long len,return err; } +static void lazy_migrate_vma (struct vm_area_struct *vma) +{ +if (!vma_migratable (vma)) +return ; + +change_prot_none (vma, vma->vm_start, vma->vm_end); +} + +void lazy_migrate_process (struct mm_struct *mm) +{ +struct vm_area_struct *vma; + +down_read (&mm->mmap_sem); +for (vma = mm->mmap; vma; vma = vma->vm_next) +lazy_migrate_vma (vma); +up_read (&mm->mmap_sem); +} +/* * User space interface with variable sized bitmaps for nodelists. */
mm/mprotect.c +17 -7
@@ -112,7 +112,7 @@ static inline void change_pud_range(struct vm_area_struct *vma, pgd_t *pgd, }while (pud++, addr = next, addr != end); } -static void change_protection (struct vm_area_struct *vma, +static void change_protection_range (struct vm_area_struct *vma,unsigned long addr,unsigned long end,pgprot_t newprot,int dirty_accountable) {
@@ -134,6 +134,20 @@ static void change_protection(struct vm_area_struct *vma,flush_tlb_range (vma, start, end); } +void change_protection (struct vm_area_struct *vma,unsigned long start, +unsigned long end,pgprot_t newprot, +int dirty_accountable) +{ +struct mm_struct *mm = vma->vm_mm; + +mmu_notifier_invalidate_range_start (mm, start, end); +if (is_vm_hugetlb_page (vma)) +hugetlb_change_protection (vma, start, end, newprot); +else +change_protection_range (vma, start, end, newprot, dirty_accountable); +mmu_notifier_invalidate_range_end (mm, start, end); +} +int mprotect_fixup (struct vm_area_struct *vma,struct vm_area_struct **pprev,unsigned long start,unsigned long end,unsigned long newflags)
@@ -206,12 +220,8 @@ success: dirty_accountable =1 ; } -mmu_notifier_invalidate_range_start (mm, start, end); -if (is_vm_hugetlb_page (vma)) -hugetlb_change_protection (vma, start, end, vma->vm_page_prot); -else -change_protection (vma, start, end, vma->vm_page_prot, dirty_accountable); -mmu_notifier_invalidate_range_end (mm, start, end); +change_protection (vma, start, end, vma->vm_page_prot, dirty_accountable); +vm_stat_account (mm, oldflags, vma->vm_file, -nrpages);vm_stat_account (mm, newflags, vma->vm_file, nrpages);perf_event_mmap (vma);