tracing: stop command line recording when tracing is disabled
Commit-ID: 18aecd362a1c991fbf5f7919ae051a77532ba2f8 Gitweb: http://git.kernel.org/tip/18aecd362a1c991fbf5f7919ae051a77532ba2f8 Author: Thomas Gleixner <[email protected]> AuthorDate: Wed, 18 Mar 2009 08:56:58 +0100 Commit: Ingo Molnar <[email protected]> CommitDate: Wed, 18 Mar 2009 10:10:16 +0100
tracing: stop command line recording when tracing is disabled
Impact: prevent overwrite of command line entries
When the tracer is stopped the command line recording continues to record. The check for tracing_is_on() is not sufficient here as the ringbuffer status is not affected by setting debug/tracing/tracing_enabled to 0. On a non idle system this can result in the loss of the command line information for the stopped trace, which makes the trace harder to read and analyse.
Check tracer_enabled to allow further recording.
Signed-off-by Thomas Gleixner <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Frederic Weisbecker <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/trace/trace.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/trace/trace.c +2 -1
@@ -797,7 +797,8 @@ void trace_find_cmdline(int pid, char comm[])void tracing_record_cmdline (struct task_struct *tsk) { -if (atomic_read (&trace_record_cmdline_disabled) || !tracing_is_on ()) +if (atomic_read (&trace_record_cmdline_disabled) || !tracer_enabled || + !tracing_is_on ())return ;trace_save_cmdline (tsk);