pinctrl/st: Fix race in installing chained IRQ handler
A message that is not in the archive (sent off-list or not yet received): [email protected]
Maxime Coquelin
Acked-byHello Thomas,
Quoted 60 lines · tip-bot for Thomas Gleixner
Commit-ID: 1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 Gitweb: http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200 Committer: Thomas Gleixner <[email protected]> CommitDate: Thu, 25 Jun 2015 11:57:09 +0200pinctrl/st: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().Search and conversion was done with coccinelle:
@@
expression E1, E2, E3;
@@
((quoted diff) +0
-2-if (irq_set_chained_handler(E1, E3) != 0) - BUG();|
-irq_set_chained_handler(E1, E3);
)(quoted diff) +1
-1-irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2);@@
expression E1, E2, E3;
@@
((quoted diff) +0
-2-if (irq_set_chained_handler(E1, E3) != 0) - BUG();|
-irq_set_chained_handler(E1, E3);
...
)(quoted diff) +1
-1-irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2);Reported-by Russell King <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>Cc Julia Lawall <[email protected]>Cc Srinivas Kandagatla <[email protected]>Cc Maxime Coquelin <[email protected]>Cc Patrice Chotard <[email protected]>Cc Linus Walleij <[email protected]>--- drivers/pinctrl/pinctrl-st.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pinctrl/pinctrl-st.c +0
-0
drivers/pinctrl/pinctrl-st.c static int st_pctl_probe_dt(struct platform_device *pdev, · line 1668
Quoted 10 lines
drivers/pinctrl/pinctrl-st.c +2
-2@@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev,if (IS_ERR (info->irqmux_base))return PTR_ERR (info->irqmux_base); -irq_set_chained_handler (irq, st_gpio_irqmux_handler); -irq_set_handler_data (irq, info); +irq_set_chained_handler_and_data (irq, st_gpio_irqmux_handler, + info); }
I cannot test the patch before Monday, but it looks good to me:
Thanks!
Maxime
Patrice Chotard
Acked-byHi Thomas
Quoted 60 lines · tip-bot for Thomas Gleixner
Commit-ID: 1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 Gitweb: http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200 Committer: Thomas Gleixner <[email protected]> CommitDate: Thu, 25 Jun 2015 11:57:09 +0200pinctrl/st: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().Search and conversion was done with coccinelle:
@@
expression E1, E2, E3;
@@
((quoted diff) +0
-2-if (irq_set_chained_handler(E1, E3) != 0) - BUG();|
-irq_set_chained_handler(E1, E3);
)(quoted diff) +1
-1-irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2);@@
expression E1, E2, E3;
@@
((quoted diff) +0
-2-if (irq_set_chained_handler(E1, E3) != 0) - BUG();|
-irq_set_chained_handler(E1, E3);
...
)(quoted diff) +1
-1-irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2);Reported-by Russell King <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>Cc Julia Lawall <[email protected]>Cc Srinivas Kandagatla <[email protected]>Cc Maxime Coquelin <[email protected]>Cc Patrice Chotard <[email protected]>Cc Linus Walleij <[email protected]>--- drivers/pinctrl/pinctrl-st.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pinctrl/pinctrl-st.c +0
-0
drivers/pinctrl/pinctrl-st.c static int st_pctl_probe_dt(struct platform_device *pdev, · line 1667
Quoted 9 lines
drivers/pinctrl/pinctrl-st.c +2
-2@@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev,if (IS_ERR (info->irqmux_base))return PTR_ERR (info->irqmux_base); -irq_set_chained_handler (irq, st_gpio_irqmux_handler); -irq_set_handler_data (irq, info); +irq_set_chained_handler_and_data (irq, st_gpio_irqmux_handler, + info); }
Thanks