Skip to contentSkip to conversation

perf, x86: Remove PEBS SAMPLE_RAW support

tip:perf/core tip-bot for Peter Zijlstra 1 participant 1 message May 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Commit-ID:  1e9a6d8d44cb6dcd2799b36ceb23007e6a423bfe
Gitweb:     http://git.kernel.org/tip/1e9a6d8d44cb6dcd2799b36ceb23007e6a423bfe
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Tue, 4 May 2010 16:30:21 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 7 May 2010 11:31:01 +0200

perf, x86: Remove PEBS SAMPLE_RAW support

Its broken, we really should get PERF_SAMPLE_REGS sorted.

LKML-Reference: <new-submission>

---
 arch/x86/kernel/cpu/perf_event_intel_ds.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_ds.c +0 -14
index ec8b2e1..080b9b0 100644
@@ -459,7 +459,6 @@ static void intel_pmu_drain_pebs_core(struct pt_regs *iregs)
 	struct perf_event *event = cpuc->events[0]; /* PMC0 only */
 	struct pebs_record_core *at, *top;
 	struct perf_sample_data data;
-	struct perf_raw_record raw;
 	struct pt_regs regs;
 	int n;
 
@@ -499,12 +498,6 @@ static void intel_pmu_drain_pebs_core(struct pt_regs *iregs)
 	perf_sample_data_init(&data, 0);
 	data.period = event->hw.last_period;
 
-	if (event->attr.sample_type & PERF_SAMPLE_RAW) {
-		raw.size = x86_pmu.pebs_record_size;
-		raw.data = at;
-		data.raw = &raw;
-	}
-
 	/*
 	 * We use the interrupt regs as a base because the PEBS record
 	 * does not contain a full regs set, specifically it seems to
@@ -536,7 +529,6 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *iregs)
 	struct pebs_record_nhm *at, *top;
 	struct perf_sample_data data;
 	struct perf_event *event = NULL;
-	struct perf_raw_record raw;
 	struct pt_regs regs;
 	u64 status = 0;
 	int bit, n;
@@ -585,12 +577,6 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *iregs)
 		perf_sample_data_init(&data, 0);
 		data.period = event->hw.last_period;
 
-		if (event->attr.sample_type & PERF_SAMPLE_RAW) {
-			raw.size = x86_pmu.pebs_record_size;
-			raw.data = at;
-			data.raw = &raw;
-		}
-
 		/*
 		 * See the comment in intel_pmu_drain_pebs_core()
 		 */