rcutorture: Make initrd/init execute in userspace
Subsystems (2)
Josh Triplett
maintainerQuoted 9 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +2
-0@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while :
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 10 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +8
-1do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a
Ow. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Please also consider calibrating the delay loop as you do in the C code.
Quoted 15 lines · Josh Triplett
Quoted 14 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-1@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while : do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \
Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 5 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-0+ a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a aOw. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Yeah, that is admittedly a bit strange. The reason for 186 occurrences of "a" to one-time calibration, measuring a few millisecond's worth of delay.
Quoted 1 line
Please also consider calibrating the delay loop as you do in the C code.
Good point. And a quick web search finds me "date '+%s%N'", which gives me nanoseconds since the epoch. I probably don't want to do a 2038 to myself (after all, I might still be alive then), so I should probably try to make something work with "date '+%N'". Or use something like this:
$ date '+%4N'; date '+%4N';date '+%4N'; date '+%4N' 6660 6685 6697 6710
Ah, but that means I need to add the "date" command to my initrd, doesn't it? And calculation requires either bash or the "test" command. And it would be quite good to restrict this to what can be done with Bourne shell built-in commands, since a big point of this is to maintain a small-sized initrd. :-/
So how about the following patch, which attempts to explain the situation?
Thanx, Paul
------------------------------------------------------------------------
commit 23c304cbeda435acd4096ab3213502d6ae9720f3
Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800
torture: Explain odd "for" loop in mkinitrd.sh
Why a Bourne-shell "for" loop? And why 186 instances of "a"? This commit adds a shell comment to present the answer to these mysteries.
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +9 -1
@@ -40,7 +40,15 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. Yes, there are 186 instances +# of "a", which was empirically shown to give a nice multi-millisecond +# burst of user-mode execution on a 2GHz CPU, as desired. Modern CPUs +# will vary from a couple of milliseconds up to perhaps 100 milliseconds, +# which is an acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. while : do q=
Josh Triplett
maintainerQuoted 41 lines · Paul E. McKenney
Quoted 15 lines · Josh Triplett
Quoted 14 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-1@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while : do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 5 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-0+ a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a aOw. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Yeah, that is admittedly a bit strange. The reason for 186 occurrences of "a" to one-time calibration, measuring a few millisecond's worth of delay.
Quoted 1 line
Please also consider calibrating the delay loop as you do in the C code.
Good point. And a quick web search finds me "date '+%s%N'", which gives me nanoseconds since the epoch. I probably don't want to do a 2038 to myself (after all, I might still be alive then), so I should probably try to make something work with "date '+%N'". Or use something like this:
$ date '+%4N'; date '+%4N';date '+%4N'; date '+%4N' 6660 6685 6697 6710
Quoted 5 lines
Ah, but that means I need to add the "date" command to my initrd, doesn't it? And calculation requires either bash or the "test" command. And it would be quite good to restrict this to what can be done with Bourne shell built-in commands, since a big point of this is to maintain a small-sized initrd. :-/
Sure, and I'm not suggesting adding commands to the initrd, hence my mention of "If there's no better way".
Quoted 1 line
So how about the following patch, which attempts to explain the situation?
That would help, but please also consider consolidating with something like a10="a a a a a a a a a a" to make it more readable (and perhaps rounding up to 200 for simplicity).
- Josh
Quoted 48 lines · Josh Triplett
Quoted 41 lines · Paul E. McKenney
Quoted 15 lines · Josh Triplett
Quoted 14 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-1@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while : do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 5 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-0+ a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a aOw. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Yeah, that is admittedly a bit strange. The reason for 186 occurrences of "a" to one-time calibration, measuring a few millisecond's worth of delay.
Quoted 1 line
Please also consider calibrating the delay loop as you do in the C code.
Good point. And a quick web search finds me "date '+%s%N'", which gives me nanoseconds since the epoch. I probably don't want to do a 2038 to myself (after all, I might still be alive then), so I should probably try to make something work with "date '+%N'". Or use something like this:
$ date '+%4N'; date '+%4N';date '+%4N'; date '+%4N' 6660 6685 6697 6710Quoted 5 lines
Ah, but that means I need to add the "date" command to my initrd, doesn't it? And calculation requires either bash or the "test" command. And it would be quite good to restrict this to what can be done with Bourne shell built-in commands, since a big point of this is to maintain a small-sized initrd. :-/
Quoted 8 lines
Sure, and I'm not suggesting adding commands to the initrd, hence my mention of "If there's no better way".
Quoted 1 line
So how about the following patch, which attempts to explain the situation?
That would help, but please also consider consolidating with something like a10="a a a a a a a a a a" to make it more readable (and perhaps rounding up to 200 for simplicity).
How about powers of four and one factor of three for 192, as shown below?
Thanx, Paul
------------------------------------------------------------------------
commit 4f8f751961b536f77c8f82394963e8e2d26efd84
Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800
torture: Explain and simplify odd "for" loop in mkinitrd.sh
Why a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +15 -8
@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8" +a192="$a64 $a64 $a64" while : do q= - for i in \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a + for i in $a192 do q="$q $i" done
Quoted 52 lines · Paul E. McKenney
Quoted 51 lines · Josh Triplett
Quoted 41 lines · Paul E. McKenney
Quoted 15 lines · Josh Triplett
Quoted 14 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-1@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while : do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 5 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-0+ a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a aOw. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Yeah, that is admittedly a bit strange. The reason for 186 occurrences of "a" to one-time calibration, measuring a few millisecond's worth of delay.
Quoted 1 line
Please also consider calibrating the delay loop as you do in the C code.
Good point. And a quick web search finds me "date '+%s%N'", which gives me nanoseconds since the epoch. I probably don't want to do a 2038 to myself (after all, I might still be alive then), so I should probably try to make something work with "date '+%N'". Or use something like this:
$ date '+%4N'; date '+%4N';date '+%4N'; date '+%4N' 6660 6685 6697 6710Quoted 5 lines
Ah, but that means I need to add the "date" command to my initrd, doesn't it? And calculation requires either bash or the "test" command. And it would be quite good to restrict this to what can be done with Bourne shell built-in commands, since a big point of this is to maintain a small-sized initrd. :-/
Sure, and I'm not suggesting adding commands to the initrd, hence my mention of "If there's no better way".
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
So how about the following patch, which attempts to explain the situation?
That would help, but please also consider consolidating with something like a10="a a a a a a a a a a" to make it more readable (and perhaps rounding up to 200 for simplicity).
How about powers of four and one factor of three for 192, as shown below?
Perfect, thanks. That's much better.
Quoted 57 lines
Thanx, Paul
------------------------------------------------------------------------
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +15
-8@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8" +a192="$a64 $a64 $a64" while : do q= - for i in \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a + for i in $a192 do q="$q $i" done
Quoted 27 lines
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +3
-1@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 55
Quoted 10 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +10
-0+# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8"
Mmh, are you sure you don't want s/a8/a16/ here? ;-)
Andrea
Quoted 16 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +2
-7+a192="$a64 $a64 $a64" while : do q= - for i in \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a + for i in $a192 do q="$q $i" done
Josh Triplett
maintainerQuoted 31 lines · Andrea Parri
Quoted 31 lines
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +7
-1@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we
Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 55
Quoted 6 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +6
-0+# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8"Mmh, are you sure you don't want s/a8/a16/ here? ;-)
... *facepalm*
Good catch.
Paul E. McKenney
AppliedQuoted 59 lines · Josh Triplett
Quoted 58 lines · Paul E. McKenney
Quoted 56 lines · Josh Triplett
Quoted 41 lines · Paul E. McKenney
Quoted 15 lines · Josh Triplett
Quoted 14 lines · tip-bot for Paul E. McKenney
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-1@@ -39,9 +39,22 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh +# Run in userspace a few milliseconds every second. This helps to +# exercise the NO_HZ_FULL portions of RCU. while : do - sleep 1000000 + q= + for i in \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 53
Quoted 5 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +5
-0+ a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ + a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a aOw. If there's no better way to do this, please do at least comment how many 'a's this is. (And why 186, exactly?)
Yeah, that is admittedly a bit strange. The reason for 186 occurrences of "a" to one-time calibration, measuring a few millisecond's worth of delay.
Quoted 1 line
Please also consider calibrating the delay loop as you do in the C code.
Good point. And a quick web search finds me "date '+%s%N'", which gives me nanoseconds since the epoch. I probably don't want to do a 2038 to myself (after all, I might still be alive then), so I should probably try to make something work with "date '+%N'". Or use something like this:
$ date '+%4N'; date '+%4N';date '+%4N'; date '+%4N' 6660 6685 6697 6710Quoted 5 lines
Ah, but that means I need to add the "date" command to my initrd, doesn't it? And calculation requires either bash or the "test" command. And it would be quite good to restrict this to what can be done with Bourne shell built-in commands, since a big point of this is to maintain a small-sized initrd. :-/
Sure, and I'm not suggesting adding commands to the initrd, hence my mention of "If there's no better way".
Quoted 1 line
So how about the following patch, which attempts to explain the situation?
That would help, but please also consider consolidating with something like a10="a a a a a a a a a a" to make it more readable (and perhaps rounding up to 200 for simplicity).
Quoted 5 lines
Quoted 1 line
How about powers of four and one factor of three for 192, as shown below?
Perfect, thanks. That's much better.
Reviewed-by Josh Triplett <[email protected]>
Applied, thank you!
Thanx, Paul
Quoted 56 lines
Quoted 55 lines
------------------------------------------------------------------------
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +15
-8@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8" +a192="$a64 $a64 $a64" while : do q= - for i in \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a + for i in $a192 do q="$q $i" done
Paul E. McKenney
Reviewed-by Josh TriplettQuoted 31 lines · Andrea Parri
Quoted 31 lines
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +7
-1@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we
Quoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 55
Quoted 6 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +6
-0+# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8"Mmh, are you sure you don't want s/a8/a16/ here? ;-)
Indeed I do! How about the following?
Thanx, Paul
------------------------------------------------------------------------
commit 94cae122408cdc55470360868a1a4b8f160e576d
Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800
torture: Explain and simplify odd "for" loop in mkinitrd.sh
Why a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +15 -8
@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, we +# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a16 $a16 $a16 $a16" +a192="$a64 $a64 $a64" while : do q= - for i in \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a \ - a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a + for i in $a192 do q="$q $i" done
Quoted 41 lines · Josh Triplett
Quoted 31 lines · Andrea Parri
Quoted 31 lines
commit
4f8f751961b536f77c8f82394963e8e2d26efd84Author: Paul E. McKenney <[email protected]> Date: Tue Dec 4 14:59:12 2018 -0800torture: Explain and simplify odd "for" loop in
mkinitrd.shWhy a Bourne-shell "for" loop? And why 192 instances of "a"? This commit adds a shell comment to present the answer to these mysteries. It also uses a series of factor-of-four Bourne-shell assignments to make it easy to see how many instances there are, replacing the earlier wall of 'a' characters.
Reported-by Josh Triplett <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/mkinitrd.sh +7
-1@@ -40,17 +40,24 @@ mkdir $T cat > $T/init << '__EOF___' #!/bin/sh # Run in userspace a few milliseconds every second. This helps to -# exercise the NO_HZ_FULL portions of RCU. +# exercise the NO_HZ_FULL portions of RCU. The 192 instances of "a" was +# empirically shown to give a nice multi-millisecond burst of user-mode +# execution on a 2GHz CPU, as desired. Modern CPUs will vary from a +# couple of milliseconds up to perhaps 100 milliseconds, which is an +# acceptable range. +# +# Why not calibrate an exact delay? Because within this initrd, weQuoted 8 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh mkdir $T · line 55
Quoted 6 lines
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +6
-0+# are restricted to Bourne-shell builtins, which as far as I know do not +# provide any means of obtaining a fine-grained timestamp. + +a4="a a a a" +a16="$a4 $a4 $a4 $a4" +a64="$a8 $a8 $a8 $a8"Mmh, are you sure you don't want s/a8/a16/ here? ;-)
Quoted 1 line
... *facepalm*
Yeah, me as well...
Quoted 1 line
Good catch.
Thank you both!!!
Thanx, Paul