perf hists: Fix up srcline histogram key formatting
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: b2d53671cdb0cf5070d56359821eb812669bb1ad Gitweb: http://git.kernel.org/tip/b2d53671cdb0cf5070d56359821eb812669bb1ad Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Tue, 18 Nov 2014 18:02:51 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 19 Nov 2014 12:33:48 -0300
perf hists: Fix up srcline histogram key formatting
Problem introduced in:
commit 5b5916696051 "perf report: Honor column width setting"
Where the left justification signal was after the width, which ended up, when the width was, say, 11, always printing:
%11.11-s
Instead of src:line left justified and limited to 11 chars.
Resulting in a like:
70.93% %11.11-s [.] f2 tcall
When it should instead be:
70.93% tcall.c:5 [.] f2 tcall
Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/sort.c +1 -1
@@ -309,7 +309,7 @@ sort__srcline_cmp(struct hist_entry *left, struct hist_entry *right)static int hist_entry__srcline_snprintf (struct hist_entry *he,char *bf,size_t size,unsigned int width) { -return repsep_snprintf (bf, size,"%*.*-s" , width, width, he->srcline); +return repsep_snprintf (bf, size,"%-*.*s" , width, width, he->srcline); }struct sort_entry sort_srcline = {