Skip to contentSkip to conversation

x86/process: Change %8s to %s for pr_warn() in release_thread()

tip:x86/cpu tip-bot for Chen Gang 1 participant 2 messages Jan 24, 2013 – Jan 25, 2013 x86

lore
Share & tools
lore
#0 lore raw
Commit-ID:  349eab6eb07794c59e37703ccbfeb5920721885c
Gitweb:     http://git.kernel.org/tip/349eab6eb07794c59e37703ccbfeb5920721885c
Author:     Chen Gang <[email protected]>
AuthorDate: Tue, 6 Nov 2012 14:45:46 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 24 Jan 2013 18:11:03 +0100

x86/process: Change %8s to %s for pr_warn() in release_thread()

the length of dead_task->comm[] is 16 (TASK_COMM_LEN) on pr_warn(), it is not meaningful to use %8s for task->comm[].

So change it to %s, since the line is not solid anyway.

Additional information:

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.

%.8s truly limit the original string output length (precision)

---
 arch/x86/kernel/process_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/process_64.c +1 -1
index 6e68a61..0f49677 100644
@@ -117,7 +117,7 @@ void release_thread(struct task_struct *dead_task)
 {
 	if (dead_task->mm) {
 		if (dead_task->mm->context.size) {
-			pr_warn("WARNING: dead process %8s still has LDT? <%p/%d>\n",
+			pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
 				dead_task->comm,
 				dead_task->mm->context.ldt,
 				dead_task->mm->context.size);