x86, mce: trivial clean up for mce_amd_64.c
Quoted 3 lines
ERROR: Macros with multiple statements should be enclosed in a do - while loop
That seems more like a checkpatch.pl bug -- clearly you cannot put a do {} while loop into a declaration like here. I don't know who comes up with these useless warnings? At least they should be made warnings, not errors and then be ignored if they don't make any sense like this.
The change imho makes the code worse.
Quoted 10 lines
(quoted diff) +6
-0+#define THRESHOLD_ATTR(_name, _mode, _show, _store) \ +{ \ + .attr = {.name = __stringify(_name), .mode = _mode }, \ + .show = _show, \ + .store = _store, \ +};WARNING: usage of
NR_CPUSis often wrong - consider usingcpu_possible(),num_possible_cpus(),for_each_possible_cpu(), etc
+ if (cpu >=NR_CPUS)
In this case it's not wrong either. It's a bit paranoid, but not wrong.
NR_CPUS is only wrong when used in arrays.
-Andi