Skip to contentSkip to conversation

x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64

tip:x86/vdso Dmitry Safonov 1 participant 1 message Sep 15, 2016 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 34 lines · tip-bot for Ingo Molnar
Commit-ID:  3947f49302e4d1576ee58addd8d20b477faef5ea
Gitweb:     http://git.kernel.org/tip/3947f49302e4d1576ee58addd8d20b477faef5ea
Author:     Ingo Molnar <[email protected]>
AuthorDate: Thu, 15 Sep 2016 08:56:21 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 15 Sep 2016 09:44:32 +0200

x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64

... otherwise the compiler complains:

arch/x86/entry/vdso/vma.c:252:12: warning: ‘map_vdso_randomized’ defined but not used [-Wunused-function]

But the #ifdeffery here is getting pretty ugly, so move around vdso_addr() as well to cluster the dependencies a bit more.

It's still not particulary pretty though ...

Cc Andy Lutomirski <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Brian Gerst <[email protected]>
Cc Denys Vlasenko <[email protected]>
Cc Dmitry Safonov <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Josh Poimboeuf <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Quoted 1 line

---

Thanks!

Signature · 1 line
             Dmitry