Skip to contentSkip to conversation

tools lib traceevent: Add missing break in make_bprint_args

tip:perf/core tip-bot for Peter Huewe 1 participant 1 message Jul 6, 2012

lore
Share & tools
lore
#0 lore raw
Commit-ID:  c9bbabe32a231b5caa8c42fa6783405346983c59
Gitweb:     http://git.kernel.org/tip/c9bbabe32a231b5caa8c42fa6783405346983c59
Author:     Peter Huewe <[email protected]>
AuthorDate: Tue, 24 Apr 2012 23:19:40 +0200
Committer:  Namhyung Kim <[email protected]>
CommitDate: Wed, 4 Jul 2012 13:40:31 +0900

tools lib traceevent: Add missing break in make_bprint_args

In the current code we assign vsize=8 and then fall through to the default and assign vsize=1. -> probably the break is missing here, otherwise we can remove the case.

---
 tools/lib/traceevent/event-parse.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
tools/lib/traceevent/event-parse.c +1 -0
index 8630160..f880db4 100644
@@ -3594,6 +3594,7 @@ static struct print_arg *make_bprint_args(char *fmt, void *data, int size, struc
 					break;
 				case 2:
 					vsize = 8;
+					break;
 				default:
 					vsize = ls; /* ? */
 					break;