Skip to contentSkip to conversation

metag: Use common outgoing-CPU-notification code

tip:core/rcu tip-bot for Paul E. McKenney 1 participant 1 message Mar 27, 2015

lore
Share & tools
lore
#0 lore raw
Commit-ID:  490ab882e2719f5e809a0cb5af7fda4620b66dca
Gitweb:     http://git.kernel.org/tip/490ab882e2719f5e809a0cb5af7fda4620b66dca
Author:     Paul E. McKenney <[email protected]>
AuthorDate: Thu, 26 Feb 2015 14:57:25 -0800
Committer:  Paul E. McKenney <[email protected]>
CommitDate: Wed, 11 Mar 2015 13:22:36 -0700

metag: Use common outgoing-CPU-notification code

This commit removes the open-coded CPU-offline notification with new common code. This change avoids calling scheduler code using RCU from an offline CPU that RCU is ignoring. This commit is compatible with the existing code in not checking for timeout during a prior offline for a given CPU.

---
 arch/metag/kernel/smp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/metag/kernel/smp.c +2 -3
index f006d22..ac3a199 100644
@@ -261,7 +261,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
-static DECLARE_COMPLETION(cpu_killed);
 
 /*
  * __cpu_disable runs on the processor to be shutdown.
@@ -299,7 +298,7 @@ int __cpu_disable(void)
  */
 void __cpu_die(unsigned int cpu)
 {
-	if (!wait_for_completion_timeout(&cpu_killed, msecs_to_jiffies(1)))
+	if (!cpu_wait_death(cpu, 1))
 		pr_err("CPU%u: unable to kill\n", cpu);
 }
 
@@ -314,7 +313,7 @@ void cpu_die(void)
 	local_irq_disable();
 	idle_task_exit();
 
-	complete(&cpu_killed);
+	(void)cpu_report_death();
 
 	asm ("XOR	TXENABLE, D0Re0,D0Re0\n");
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-metag" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html